1. 27 Nov, 2019 1 commit
    • Arjen Hiemstra's avatar
      Add translations for new memory sensors · eedf1ca7
      Arjen Hiemstra authored
      This adds the translated strings for the new Total, Available and
      Allocated sensors.
      Depends on D25305
      Test Plan:
      The sensor browser no longer shows the new sensors as "total", "available"
      and "allocated" but "Total Memory" etc.
      Reviewers: #plasma, davidedmundson
      Reviewed By: #plasma, davidedmundson
      Subscribers: plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D25306
  2. 23 Nov, 2019 3 commits
  3. 12 Nov, 2019 1 commit
  4. 04 Nov, 2019 1 commit
    • David Edmundson's avatar
      Add KDEClangFormat cmake support · 482808cd
      David Edmundson authored
      This allows devs to run: "make clang-format" and format all files easily
      using the preset KDE clang format style
      This patch adds support so devs can easily test the intended formatting
      now, it doesn't change the code yet.
      Doing an initial run to commit everything will happen later.
      Test Plan:
      Ran script
      git diff was full of amazingly cleaned code
      See D25134
  5. 29 Oct, 2019 1 commit
  6. 27 Oct, 2019 1 commit
  7. 22 Oct, 2019 1 commit
  8. 21 Oct, 2019 2 commits
  9. 18 Oct, 2019 1 commit
  10. 13 Oct, 2019 2 commits
  11. 10 Oct, 2019 3 commits
  12. 27 Sep, 2019 3 commits
  13. 26 Sep, 2019 1 commit
  14. 19 Sep, 2019 5 commits
  15. 17 Sep, 2019 1 commit
  16. 13 Sep, 2019 1 commit
    • David Edmundson's avatar
      Create a plugin framework for processes · 06468841
      David Edmundson authored
      Currently everything for processes is hardcoded with a method for each
      process property. This is core functionality like CPU usage and memory
      usage but it's not very extensible.
      Currently ProcessModel is full of extra hacks to add X11 data when
      really it should be a dumb proxier of information.
      We have a pending patch to show network stats, and we have a pending
      patch to add powertop information, which all work in a different way
      from just reading data in /proc
      In order to keep it flexible a more generic format method is added which
      doesn't require hardcoding knowledge of types.
      This patch is part of a series, next steps are adding various plugins,
      stripping proces model - and then using the ProcessAttribute class to
      provide the metadata for the core process attributes so that
      ProcessModel can become a very simple view with no code duplication.
      Reviewers: #plasma, ahiemstra
      Reviewed By: ahiemstra
      Subscribers: meven, zzag, ahiemstra, alexde, broulik, plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D23287
  17. 09 Sep, 2019 1 commit
    • Yunhe Guo's avatar
      HiDPI icon pixmap · 5906261d
      Yunhe Guo authored
      Return HiDPI icon pixmap, so the icon in process list is sharp in HiDPI display.
      Reviewers: #plasma, ngraham
      Reviewed By: ngraham
      Subscribers: GB_2, #plasma, plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D23794
  18. 04 Sep, 2019 2 commits
  19. 02 Sep, 2019 1 commit
    • Arjen Hiemstra's avatar
      Move code to send signals and set priority of processes to a dedicated object · cb3ccfc6
      Arjen Hiemstra authored
      This pulls the code out of KSysGuardProcessList and introduces it in a
      new class called ProcessController. This should help make that code more
      reusable and allow it to eventually be exposed to QML.
      Test Plan:
      Start ksysguard, try to send signals to processes and set priorities, including
      root-owned processes. Everything should still work.
      Reviewers: #plasma, davidedmundson
      Reviewed By: #plasma, davidedmundson
      Subscribers: davidedmundson, plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D23566
  20. 27 Aug, 2019 2 commits
    • Arjen Hiemstra's avatar
      Add vmPSS to Process and display it as "total memory" column · 3a285053
      Arjen Hiemstra authored
      This adds a "proportional state set" value to ProcessCore::Process, that is then
      exposed as "Total Memory" column in KSysGuard. This column is hidden by default.
      PSS is the amount of memory a process uses privately + the amount of shared memory
      divided by the amount of processes sharing that memory. It is, as far as I know, the
      closest we can get to "total physical memory usage" for a process.
      The value for PSS is read from /proc/{pid}/smaps_rollup . This unfortunately means
      we cannot currently display PSS for processes not owned by the current user, as
      smaps_rollup is not world-readable.
      For some background on this, see https://lkml.org/lkml/2017/8/9/1073 , which is the
      patch that adds smaps_rollup and talks about what Android uses it for.
      Test Plan:
      Run ksysguard, then toggle display of the "Total Memory" column. Values should be
      higher than the "Memory" column.
      Reviewers: #plasma, davidedmundson
      Reviewed By: #plasma, davidedmundson
      Subscribers: plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D23382
    • Laurent Montel's avatar
      Use QLatin1String when it's possible + don't assign string when we use · 857ef2a2
      Laurent Montel authored
      replace as it works on same element
  21. 27 Jul, 2019 1 commit
  22. 23 Jul, 2019 1 commit
  23. 16 Jun, 2019 1 commit
    • Kishore Gopalakrishnan's avatar
      Invert controls direction for process priority slider · cf1791d7
      Kishore Gopalakrishnan authored
      Since low 'nice' values correspond to high priority, the slider labels are inverted so that 'higher' corresponds to a lower nice number. However, this was not done for the slider control, resulting in the arrow keys moving the slider in the direction opposite to that expected by the user. This patch fixes this by setting invertedControls to 'true' for the priority slider.
      BUG: 408074
      Test Plan:
      1. Open Ksysguard.
      2. Go to the tab that lists processes.
      3. Right click on a process and select 'Set Priority'.
      4. Click on the slider that sets the CPU priority.
      5. Press the left and right arrow keys on the keyboard and check if they move the slider in the appropriate direction.
      Reviewers: cfeck
      Reviewed By: cfeck
      Subscribers: cfeck, plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D21828
  24. 12 Jun, 2019 1 commit
  25. 20 May, 2019 1 commit
  26. 18 May, 2019 1 commit