PC3.Combobox: Don't hardcode popup styling

Filip Filarequested to merge
filipf/libplasma:fix-pc3-combobox-styling into master

Currently the PlasmaComponents3.Combobox uses custom styling for the popup. The issue lies with both of the two visual elements:

  • the popup background is a hardcoded Kirigami.ShadowedRectangle, which even has a slightly inconsistent look with Breeze
  • the hover effect looks like it's falling back to some basic QtQuick styling, looking very different from Breeze styling and doesn't even always follow the accent color

This patch makes them use the Plasma theme's SVG for both elements instead. The popup is made to look the same as PC3.Menu (companion patch to !1546 (merged)) .

SCREENSHOTS

Before (Breeze) After (Breeze)
PC3Combbox-Breeze_before_ PC3Combbox-Breeze_after2_
Before (Breeze Light) Before
PC3Combbox-BreezeLight_before PC3Combbox-BreezeLight_after_

Note: to be consistent with app styling, the Breeze SVG should be updated to have an outline

Before (Oxygen) After (Oxygen)
PC3Combbox-Oxygen_before_ PC3Combbox-Oxygen_after_

BUG: 381065

FIXED-IN: 6.8.0

Edited by Filip Fila

Merge request reports