From 19dc0f02871664b0d1211b0d17b6e4335870b838 Mon Sep 17 00:00:00 2001 From: Ismael Asensio Date: Sun, 29 May 2022 12:05:08 +0200 Subject: [PATCH] ResultDelegate: Fix height binding loop on multiline This binding loop was making krunner freeze when the text expanded more than 3 lines We shouldn't be setting the `height` on an item based on their childrens height. Luckily, the Layout automatically calculates this for us BUG: 454507 FIXED-IN: 5.24.6 --- lib/qml/ResultDelegate.qml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/qml/ResultDelegate.qml b/lib/qml/ResultDelegate.qml index 81e77a8..2fc985b 100644 --- a/lib/qml/ResultDelegate.qml +++ b/lib/qml/ResultDelegate.qml @@ -166,9 +166,11 @@ MouseArea { right: parent.right leftMargin: resultDelegate.categoryWidth } - height: Math.max(typePixmap.height, displayLabel.height, subtextLabel.height) + PlasmaCore.Units.smallSpacing + implicitHeight: labelLayout.implicitHeight RowLayout { + id: labelLayout + anchors { left: parent.left right: actionsRow.left -- GitLab