Skip to content
  • Kai Uwe Broulik's avatar
    Signal player gone in "pagehide" not "beforeunload" · 229a5e2c
    Kai Uwe Broulik authored
    I don't recall if there was a particular reason for using *before* unload but this event is not emitted for iframes.
    Using "pagehide" instead makes an iframe content script notice it's being destroyed (e.g. because of the overlay it was in being removed)
    and correctly signals the player being gone. "unload" supposedly causes the browser trouble caching the page.
    We did noticed a video in an overlay being removed but not when it was inside of an iframe.
    
    Differential Revision: https://phabricator.kde.org/D28926
    229a5e2c