Commit 269da15c authored by Kai Uwe Broulik's avatar Kai Uwe Broulik 🍇

Provide light icon for dark mode via theme_icons

I recall we originally didn't do it when Noah added these icons as browserAction.setIcon
wasn't able to override the icon or something like this?
However, it doesn't appear to be the case anymore in more recent versions.

While the setIcons API doesn't support theme icons, only set the custom icon when the extension fails to start.
So let's not jeopardize the normal user experience by this edge case.

BUG: 414544

Differential Revision:
parent a2f3e96d
......@@ -38,7 +38,24 @@
"browser_action": {
"browser_style": true,
"default_popup": "action_popup.html"
"default_popup": "action_popup.html",
"theme_icons": [{
"light": "icons/plasma-dark-16.png",
"dark": "icons/plasma-16.png",
"size": 16
}, {
"light": "icons/plasma-dark-32.png",
"dark": "icons/plasma-32.png",
"size": 32
}, {
"light": "icons/plasma-dark-48.png",
"dark": "icons/plasma-48.png",
"size": 48
}, {
"light": "icons/plasma-dark-128.png",
"dark": "icons/plasma-128.png",
"size": 128
"content_scripts": [
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment