Commit c3611dc9 authored by Stefan Brüns's avatar Stefan Brüns

Avoid serializing base64 encoded favicon data twice

Summary:
The URL is ignored in case the image data is available. Avoid pushing
it twice via DBus.

Test Plan:
1. start dbus-monitor
2. type some string in krunner

- before: dict entries contain both favIconData and favIconUrl, with
   identical data
- after:  only favIconData is part of the dict

Favicons are still shown in the krunner results

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D19963
parent e49a1eea
......@@ -566,6 +566,7 @@ addCallback("tabsrunner", "getTabs", function (message) {
} else if (favIconUrl.match(/^data:image/)) {
// Already a data URL
filteredTabs[currentIndex].favIconData = favIconUrl;
filteredTabs[currentIndex].favIconUrl = "";
sendTabsIfComplete();
} else {
// Send a request to fill the cache (=no timeout)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment