Commit 2536848f authored by Nate Graham's avatar Nate Graham
Browse files

[kcms/notifications] Remove option to hide critical notifications in fullscreen apps

I cannot think of a conceivable use case for this option; it seems to
only exist to let users shoot themselves in the foot, because critical
notifications are critical for a reason and you really should see them
even if you're watching a video or presenting. The most common one is
"low battery" and you really really really do want to see this in those
use cases. So Let's remove this option for safety and sanity.

This commit removes only the UI; the backend code is removed in
plasma-workspace!832 so
that anyone who for some reason turned this off in the past doesn't lose
the ability to turn it back on and get permanently stuck with missed
critical notifications while they're watching YouTube videos.
parent 7d3371f1
......@@ -121,18 +121,6 @@ KCM.SimpleKCM {
QtControls.CheckBox {
Kirigami.FormData.label: i18n("Critical notifications:")
text: i18n("Show over full screen windows")
checked: kcm.notificationSettings.criticalAlwaysOnTop
onClicked: kcm.notificationSettings.criticalAlwaysOnTop = checked
KCM.SettingStateBinding {
configObject: kcm.notificationSettings
settingName: "CriticalAlwaysOnTop"
extraEnabledConditions: root.notificationsAvailable
QtControls.CheckBox {
text: i18n("Show in Do Not Disturb mode")
checked: kcm.notificationSettings.criticalInDndMode
onClicked: kcm.notificationSettings.criticalInDndMode = checked
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment