Commit 34659555 authored by Nate Graham's avatar Nate Graham
Browse files

[kcms/landingpage] Give up on vertical centering and let it scroll

In the past, we made the content view of this KCM center vertically.
However that caused binding loops and made resizing slow. Then later we
made it non-scrollable so that it could be vertically centered, but that
broke scrollability for users with very short screens.

This commit simplifies the situation to stop doing anything fancy at all
and just uses a boring old SimpleKCM. This lets it be scrollable but
does not have vertical centering for the content. However no other KCM
vertically centers its content like this anyway, so arguably there is a
consistency win as well.

BUG: 438171
FIXED-IN: 5.21.2


(cherry picked from commit c561706f)
parent 8406a3e1
......@@ -24,20 +24,13 @@ import QtQuick.Window 2.2
import org.kde.kirigami 2.5 as Kirigami
import org.kde.kcm 1.4 as KCM
KCM.AbstractKCM {
KCM.SimpleKCM {
id: root
ColumnLayout {
anchors.fill: parent
QQC2.ButtonGroup { id: themeGroup }
// Spacer for vertical centering
Item {
Layout.fillWidth: true
Layout.fillHeight: true
}
RowLayout {
Layout.alignment: Qt.AlignCenter
spacing: Kirigami.Units.gridUnit * 2
......@@ -253,11 +246,5 @@ KCM.AbstractKCM {
Layout.fillWidth: true
}
}
// Spacer for vertical centering
Item {
Layout.fillHeight: true
Layout.fillWidth: true
}
}
}
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment