Commit 3bd34bae authored by David Edmundson's avatar David Edmundson Committed by Nate Graham
Browse files

[applets/kicker] Explicitly set visible property when opacity is 0

The Dashboard representation contains 3 views stacked on top of each
other with one visible at a time with an opacity animation.

Enabled was used (presumably) to ensure that only the active
representation gets input events.

Unfortunately this has a side effect. When switching views the icons on
the inactive view all get enabledChanged events. This triggers a redraw
with a greyed out effect on all icons. This is a very slow path,
especially for something not even visible!

Setting visible also stops input events, without the side effect.


(cherry picked from commit 7881fdf5)
parent bf5c08ed
...@@ -569,7 +569,7 @@ Kicker.DashboardWindow { ...@@ -569,7 +569,7 @@ Kicker.DashboardWindow {
anchors.fill: parent anchors.fill: parent
z: (opacity == 1.0) ? 1 : 0 z: (opacity == 1.0) ? 1 : 0
enabled: (opacity == 1.0) ? 1 : 0 visible: opacity != 0.0
property int headerHeight: mainColumnLabel.height + mainColumnLabelUnderline.height + PlasmaCore.Units.largeSpacing property int headerHeight: mainColumnLabel.height + mainColumnLabelUnderline.height + PlasmaCore.Units.largeSpacing
...@@ -690,7 +690,7 @@ Kicker.DashboardWindow { ...@@ -690,7 +690,7 @@ Kicker.DashboardWindow {
width: parent.width width: parent.width
height: systemFavoritesGrid.y + systemFavoritesGrid.height height: systemFavoritesGrid.y + systemFavoritesGrid.height
enabled: (opacity == 1.0) ? 1 : 0 visible: opacity != 0.0
opacity: filterList.allApps ? 1.0 : 0.0 opacity: filterList.allApps ? 1.0 : 0.0
...@@ -731,7 +731,7 @@ Kicker.DashboardWindow { ...@@ -731,7 +731,7 @@ Kicker.DashboardWindow {
width: parent.width width: parent.width
height: Math.min(implicitHeight, systemFavoritesGrid.y + systemFavoritesGrid.height) height: Math.min(implicitHeight, systemFavoritesGrid.y + systemFavoritesGrid.height)
enabled: (opacity == 1.0) ? 1 : 0 visible: opacity != 0.0
model: runnerModel model: runnerModel
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment