Commit 49113700 authored by Nate Graham's avatar Nate Graham
Browse files

[Widget Explorer] always show the search field

Most Plasma widgets and apps that have search fields show them by default. Two exceptions are Kickoff and Widget Explorer (for background, see D15011#315779).

Kickoff is being addressed in D15011. That would leave Widget Explorer as the only case in Plasma (that I could find) where a search field invisibly has keyboard focus and appears when you start typing, but is not actually visible until then. This patch changes that by making the search field always visible, matching everything else in Plasma.

Thanks to @sharvey for doing most of the work already to move the Search Field to its own row in the layout. This patch simply makes it always visible and removes the {nav Search} button that shows and hides it.

Test Plan: {F6218550}

Reviewers: sharvey, #vdg, abetts, #plasma, davidedmundson

Reviewed By: sharvey, #vdg, abetts, #plasma, davidedmundson

Subscribers: abetts, sharvey, plasma-devel

Tags: #plasma

Differential Revision:
parent 89ff12d2
......@@ -208,7 +208,6 @@ Item {
Item {
id: header
property bool showingSearch: false
Layout.fillWidth: true
Layout.alignment: Qt.AlignVCenter
PlasmaExtras.Title {
......@@ -219,24 +218,6 @@ Item {
elide: Text.ElideRight
PlasmaComponents.ToolButton {
id: searchButton
iconSource: "edit-find"
checkable: true
onClicked: header.showingSearch = !header.showingSearch
checked: header.showingSearch
onCheckedChanged: {
if (!checked) {
searchInput.text = "";
newSearchRow.height = 0;
widgetExplorer.widgetsModel.searchTerm = "";
} else {
newSearchRow.height = parent.height;
PlasmaComponents.ToolButton {
id: categoryButton
......@@ -254,7 +235,7 @@ Item {
onClicked: main.closed()
RowLayout {
id: newSearchRow topBar.bottom
......@@ -263,7 +244,6 @@ Item {
PlasmaComponents.TextField {
id: searchInput
visible: header.showingSearch
Layout.fillWidth: true
clearButtonShown: true
placeholderText: i18nd("plasma_shell_org.kde.plasma.desktop", "Search...")
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment