[lookandfeel kcm] Do not declare plugin in lookandfeeltool code version

Summary:
Also improves race condition on creating the JSON file and running
automoc over the cpp file which refers to it, given there is no
dependency chain defined at all for the lookandfeeltool target and
that kcm_lookandfeel.json, which was prone to make highly parallel
builds fail

Reviewers: #freebsd, tcberner, bshah, mart, davidedmundson

Reviewed By: davidedmundson

Subscribers: davidedmundson, rikmills, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D10485
parent 31bcd0ac
......@@ -71,6 +71,8 @@ set(lookandfeeltool_SRCS
qt5_add_dbus_interface(lookandfeeltool_SRCS ${klauncher_xml} klauncher_iface)
add_executable(lookandfeeltool ${lookandfeeltool_SRCS})
# TODO: load kcm plugin instead of using code copy
target_compile_definitions(lookandfeeltool PRIVATE -DDEFINE_NO_PLUGIN)
target_link_libraries(lookandfeeltool
KF5::KIOWidgets
......
......@@ -57,7 +57,9 @@
# include <X11/extensions/Xfixes.h>
#endif
#ifndef DEFINE_NO_PLUGIN
K_PLUGIN_FACTORY_WITH_JSON(KCMLookandFeelFactory, "kcm_lookandfeel.json", registerPlugin<KCMLookandFeel>();)
#endif
KCMLookandFeel::KCMLookandFeel(QObject* parent, const QVariantList& args)
: KQuickAddons::ConfigModule(parent, args)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment