Commit 60c89575 authored by Mathias Tillman's avatar Mathias Tillman
Browse files

fontinst quits after KJob is done

As the summary says, when installing/removing multiple fonts to system the expected behaviour would be for fontinst to keep running after the first font has been installed or removed, instead it quits which causes a bunch of issues. fontinst uses KJob to authorize and internally KJob uses a QEventLoopLocker which causes the main event loop to quit when it's done.
I'm not entirely sure why the event loop locker is enabled by default for KJob, but the patch I have attached works around this by completely disabling that functionality for fontinst. There's a timer that runs in the background which checks for any connected clients, so it will quit after a little while regardless.

BUG: 379524
BUG: 379324
BUG: 349673
BUG: 361960
BUG: 392267

Test Plan: Make sure fonts are still installed and removed properly.

Reviewers: #plasma, dfaure, aacid, gateau

Reviewed By: dfaure

Subscribers: wbauer, ngraham, plasma-devel

Tags: #plasma

Differential Revision:
parent b0c9b776
......@@ -27,6 +27,10 @@
int main(int argc, char *argv[])
// KJob uses a QEventLoopLocker which causes kfontinst to quit
// after the job is done, prevent this by disabling quit lock.
QCoreApplication *app=new QCoreApplication(argc, argv);
KFI::FontInst fi;
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment