Commit 9d3af571 authored by Nate Graham's avatar Nate Graham
Browse files

[desktoppackage/alternatives] Don't overflow with long text

This code was previously making the list item height equal to the icon
height plus some padding, but the text was vertically unbounded so it
would overflow. This commit fixes that by using the implicit height of
the whole content layout which knows about the height of the labels too.

BUG: 439098
FIXED-IN: 5.22.5


(cherry picked from commit 6749d08a)
parent 2f6e5b1f
......@@ -111,7 +111,7 @@ PlasmaCore.Dialog {
highlightResizeDuration: 0
delegate: PlasmaExtras.ListItem {
implicitHeight: PlasmaCore.Units.iconSizes.huge + PlasmaCore.Units.smallSpacing * 2
implicitHeight: contentLayout.implicitHeight + PlasmaCore.Units.smallSpacing * 2
onClicked: mainList.currentIndex = index
......@@ -132,6 +132,7 @@ PlasmaCore.Dialog {
}
contentItem: RowLayout {
id: contentLayout
spacing: PlasmaCore.Units.largeSpacing
PlasmaCore.IconItem {
......@@ -143,6 +144,7 @@ PlasmaCore.Dialog {
ColumnLayout {
Layout.fillHeight: true
Layout.fillWidth: true
spacing: 0 // The labels bring their own bottom margins
PlasmaExtras.Heading {
level: 4
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment