Summary:
The background color should not be used for the foreground text
color, I believe. The background color is set to theme.highlightColor,
so use theme.highlightedTextColor for the foreground. This ensures
the text is readable on a dark color scheme.

Test Plan: unreadable text before, readable now

Reviewers: broulik, hein

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D10697

When moving a horizontal panel around so it becomes vertical, the height of the badge would grow
enormous briefly during re-layouting causing a crash in the font engine.

Differential Revision: https://phabricator.kde.org/D10586

GIT_SILENT

Summary:
We need to use the overriden sortMode, not the model's sort mode.
The == -> === changes are just cosmetic, not related to functionality

Reviewers: hein

Reviewed By: hein

Subscribers: davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D10407

Summary:
When enabled, it matches the pre 5.12 behavior. There is no GUI for it
yet.

Reviewers: #plasma, hein

Reviewed By: #plasma, hein

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D10408

Summary:
Also improves race condition on creating the JSON file and running
automoc over the cpp file which refers to it, given there is no
dependency chain defined at all for the lookandfeeltool target and
that kcm_lookandfeel.json, which was prone to make highly parallel
builds fail

Moving the K_PLUGIN_FACTORY_WITH_JSON into a separate file only added
to the sources of kcm_lookandfeel, instead of hiding with an ifndef for
the build of the lookandfeeltool target as tried before, should avoid
any potential confusion of automoc as reported from some builds
(on KDE neon?).

Reviewers: #freebsd, tcberner, bshah, mart, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D10607

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

This reverts commit 502e8dc1.

It causes error undefined reference to 'vtable for
KCMLookandFeelFactory' while linking, as reported by psifidotos on IRC
channel.

This reverts the D10485

Summary: Now consistent with Kicker and others.

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D10552

Summary:
Using one argument with "KSharedConfig::openConfig(filename)" actually
results in using the default value for the second argument, "FullConfig".
Which results also in "Blend kdeglobals into the config object."
As a result the color scheme file opened in KCMLookandFeel::setColors(...)
this way has the complete global config groups and settings (with the data
as stored on the disc, not in any runtime working copies) mapped into the
profile (incl. e.g. the group "[General]" with the entry "ColorScheme").
So when then all the groups are copied over from the scheme config, actually
also all the stored global config groups and settings are copied over,
overwriting the not yet synced [General]/ColorScheme entry, which was just
set a few lines before, again with the old value from the storage.

Possibly the old code which was doing the sync right after setting the new
scheme value had been there exactly to protect against that
(cmp. change in cf49d415).

Reviewers: broulik, davidedmundson, mart

Reviewed By: broulik

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D10259

Summary: Fixes regression from 31bcd0ac.

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D10550

There's a MouseArea with anchors.fill within an Item, just merge the two. There's no references to the Item.

Differential Revision: https://phabricator.kde.org/D10545

The GridView attached property is only attached to the delegate item not any of its children.

Reviewed-By: Eike Hein

BUG: 390353
FIXED-IN: 5.12.2

It's only used there.

Differential Revision: https://phabricator.kde.org/D10540

Otherwise we would create an instance of this JS file for every delegate.
The only contextual object it uses is i18n, so pass that in for the function call.

Differential Revision: https://phabricator.kde.org/D10507

When the task appears in Task Manager and is already playing audio, show the indicator right away.
There's no distraction from that since the task as a whole appears.
Only when the audio stream appears during the lifetime of a task, it is delayed to avoid distractions by short sound effects.

BUG: 390502
FIXED-IN: 5.13.0

Differential Revision: https://phabricator.kde.org/D10539

Summary: BUGS: 370588

Test Plan:
Without it the touchpad toggle at my laptop just toggles once
now it works fine all the time

Reviewers: davidedmundson, xuetianweng

Reviewed By: xuetianweng

Subscribers: knambiar, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D10498

Summary:
Also improves race condition on creating the JSON file and running
automoc over the cpp file which refers to it, given there is no
dependency chain defined at all for the lookandfeeltool target and
that kcm_lookandfeel.json, which was prone to make highly parallel
builds fail

Reviewers: #freebsd, tcberner, bshah, mart, davidedmundson

Reviewed By: davidedmundson

Subscribers: davidedmundson, rikmills, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D10485

Summary:
The mouse handling code relied on onPositionChanged to do setup work
prior to onPressed. This is never guaranteed, but it's is likely to
happen when using the mouse (since the pointer is usually moved from
a panel icon to a delegate elsewhere on screen). In a touchscreen
scenario, these odds reverse.

The lesson to take away: Never assume onPositionChanged has run
before onPressed.

BUG:366527

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D10513

Summary:
showPin oscillates during startup and the prop being null'd
on destroy() is not sync, so this creates a race condition.

BUG:390428

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D10510

Kickoff uses AppsModel instead of RootModel but since RootModel inherits AppsModel we can just move everything over here.

Differential Revision: https://phabricator.kde.org/D10506

Summary:
This is the preferred way to get a file path in a temporary
directory. It's easy to forget to append '/' when using
QTemporaryDir::path().

Reviewers: #plasma, hein

Reviewed By: #plasma, hein

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D10038

GIT_SILENT