1. 20 Apr, 2020 2 commits
  2. 19 Apr, 2020 1 commit
  3. 13 Apr, 2020 1 commit
    • Nate Graham's avatar
      Make accidental panel and panel widget deletion more difficult · ba66d2ea
      Nate Graham authored
      We make it very easy to delete panels and panel widgets--perhaps a bit too easy. User
      feedback has indicated that we may need to re-work this a bit, and that perhaps D20144 was a
      This patch moves the {nav Remove Panel} button back into the {nav More} menu where it used to
      be, to make it harder to accidentally click on. It also moves the {nav Remove} button for
      panel widgets higher up in the menu so it's not so close to the cursor.
      To adjust to these changes, the layout of buttons on the panel toolbar is changed to
      preserve visual balance, and the {nav More} menu's name is adjusted to reflect the fact that
      removing a panel is not a setting.
      BUG: 419853
      FIXED-IN: 5.18.5
      Test Plan: {F8227561}
      Reviewers: #vdg, #plasma, ndavis
      Reviewed By: #vdg, ndavis
      Subscribers: rikmills, broulik, plasma-devel
      Tags: #plasma
      Maniphest Tasks: T12942
      Differential Revision: https://phabricator.kde.org/D28710
  4. 04 Apr, 2020 1 commit
  5. 02 Apr, 2020 1 commit
    • Cyril Rossi's avatar
      KCM Colors fix apply button always disabled · 443b028a
      Cyril Rossi authored
      BUG: 418604
      This is similar to D27384
      Test Plan:
      In `kdeglobals` configuration file :
      * Edit `ColorScheme` in group `General` to a non existing value
      * Open the KCM, the default color scheme is selected with a warning message,
      * Select a different scheme, the apply button stay disabled forever.
      Reviewers: #plasma, ervin, bport, meven, broulik
      Subscribers: plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D27944
      (cherry picked from commit 4d33b827)
  6. 01 Apr, 2020 1 commit
  7. 31 Mar, 2020 1 commit
  8. 27 Mar, 2020 1 commit
  9. 26 Mar, 2020 3 commits
  10. 25 Mar, 2020 1 commit
  11. 22 Mar, 2020 1 commit
  12. 21 Mar, 2020 1 commit
  13. 20 Mar, 2020 1 commit
  14. 18 Mar, 2020 1 commit
    • Kai Uwe Broulik's avatar
      [Icons KCM] Floor delegate height · c9f545a3
      Kai Uwe Broulik authored
      There's two rows, so if the delegate happens to be at an odd size, both rows would be rounded up,
      pushing the icons too close to the delegate border.
      Since there's already code for unloading the icons that are out of view, nothing should be leaked into the view,
      even if we now end up having 1 or 2 pixels of the delegates normally out of view visible.
      Differential Revision: https://phabricator.kde.org/D28120
  15. 13 Mar, 2020 1 commit
    • Nate Graham's avatar
      Make panel edit mode tooltip not unexpectedly disappear under certain circumstances · 9768200d
      Nate Graham authored
      The panel edit mode tooltip can currently disappear in an irritating manner under two circumstances:
      - You need to mouse the mouse diagonally out of the configuration areat to reach the tooltop, because the timer's duration is very short
      - You move the mouse between the tooltip and the configuration area in preparation for moving it to another applet, because the timer did not stop when moving from the tooltip to the configuration area
      This patch fixes both issues by increasing the timer duration and stopping the timer when entering the configuration area
      BUG: 413736
      FIXED-IN: 5.18.4
      Test Plan:
      Edit the panel
      Hover over an applet and move the mouse diagonally to its tooltip, crossing empty space
      Hover over an applet and move the mouse back to the configuration area, then back to the applet, and back to the configuration area, then to another applet, then to that applet's tooltip
      In both cases, the tooltip remains visible, as expected.
      Reviewers: #plasma, broulik
      Reviewed By: #plasma, broulik
      Subscribers: plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D27877
  16. 10 Mar, 2020 1 commit
  17. 02 Mar, 2020 1 commit
  18. 27 Feb, 2020 2 commits
    • Nate Graham's avatar
      [applets/taskmanager] Show PA-related features even when audio indicators are disabled · 3b2e4dda
      Nate Graham authored
      There is a checkbox in the Task Manager settings with the text "Mark applications that
      play audio". Unchecking it does much more than no longer marking applications that play
      audio though; it disabled all PulseAudio-related features. This not only makes the label
      inaccurate, but it also seems undesirable; a user could quite reasonably wish to disable
      the audio indicators while still using PulseAudio-related functionality through the Task
      Manager (e.g. muting an app from the context menu).
      This patch makes the setting in question really and truly only show and hide the audio
      indicator icon on the Task; other PA-related functionality is always loaded when
      Test Plan:
      Open an app or window that can play audio and start playing audio with it
      Make sure that audio indicators are visible
      Right-click on the task and see that there's {nav Mute} item (provided by PA
      Configure the Task Manager and disable audio indicators
      See that the audio indicator icon is gone from the task
      Right-click on the task and see that the {nav Mute} item is still there
      Configure the Task Manager again and re-enable audio indicators
      See that the audio indicator icon re-appears on the task
      BUG: 418164
      FIXED-IN: 5.18.3
      Reviewers: #plasma
      Subscribers: plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D27684
    • Filip Fila's avatar
      [emojier] Set minimum window height and width · d0247bf5
      Filip Fila authored
      There are two problems right now with the emojier's window:
      - when shrinking the window a scrollbar is drawn *over* the category drawer's icons
      - the whole window can be shrunk to be only 1px wide and only several pixels tall
      To solve both issues this patch sets a minimum height that is equal to the height of the category drawer's content, thereby removing the possibility of a scrollbar appearing. Minimum width is then set to be somewhat bigger than minimum height to account for monitor aspect ratios.
      In practice this amounts to about 465x370 on a 1080p screen.
      BUG: 418195
      FIXED-IN: 5.18.3
      Subscribers: plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D27679
  19. 25 Feb, 2020 1 commit
  20. 24 Feb, 2020 1 commit
    • David Edmundson's avatar
      Calculate needsSave on checkbox toggle not on change · 1dd4668f
      David Edmundson authored
      Otherwise we will trigger it during load, which is wasteful.
      But worse potentially we haven't evaluated the other settings yet, so it
      could trigger that we have changed the settings, and prematurely set
      apply to enabled prematurely which currently breaks things.
      I suspect it will fix the bug below, I couldn't reproduce reliably
      enough to prove it.
      Please reopen if it remains an issue
      BUG: 411584
      Fixed-in: 5.18.2
      Test Plan:
      Opened KCM
      toggling still worked as expected
      Reviewers: #plasma, apol, ngraham
      Reviewed By: apol, ngraham
      Subscribers: apol, plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D27590
  21. 23 Feb, 2020 1 commit
  22. 22 Feb, 2020 2 commits
  23. 21 Feb, 2020 3 commits
  24. 20 Feb, 2020 3 commits
  25. 19 Feb, 2020 4 commits
  26. 18 Feb, 2020 1 commit
  27. 17 Feb, 2020 2 commits
    • David Edmundson's avatar
      [desktoppackage] Fix layout when an applet has no custom config modules · 1123cc4d
      David Edmundson authored
      There was some broken code to hide the sidebar when we only have one
      module. However at some point it seems half was removed, half wasn't.
      This leads to the content overlapping the sidebar frame, but the sidebar
      was invisible and it looks generally broken.
      This patch completes the removal.
      BUG: 410770
      Test Plan:
      Opened touchpad KCM
      Saw the one module (keyboard shortcuts)
      Sidebar was visible, and nothing was overlapping
      Reviewers: ngraham
      Reviewed By: ngraham
      Subscribers: broulik, ngraham, plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D27398
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 6ef03d63
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"