1. 20 Apr, 2020 1 commit
  2. 23 Jan, 2020 1 commit
    • Filip Fila's avatar
      [Kickoff] Theme separators · 33b13889
      Filip Fila authored
      Summary:
      Kickoff's separators were drawn as rectangles which doesn't allow them to be themed.
      
      We have the infrastructure to theme lines though so this patch makes use of it.
      
      The benefit is that themes can now gracefully incorporate separators into their design.
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26866
      33b13889
  3. 25 Nov, 2019 1 commit
  4. 08 Aug, 2019 1 commit
    • Konstantin Lisin's avatar
      Fix incorrect Kickoff tab bar layout for vertical panels · 2054d9be
      Konstantin Lisin authored and Nate Graham's avatar Nate Graham committed
      Summary:
      This fixes the broken layout of the tab bar (tab bar takes the whole view)
      when a panel is changed from horizontal to vertical that persists
      until plasmashell is restarted.
      BUG: 393888
      
      Test Plan:
      Change panel orientation from horizontal to vertical. Open Kickoff.
      Before fix: tab bar fills the whole view making the Kickoff unusable even if you make the panel horizontal again.
      After fix: tab bar has the correct size.
      
      Reviewers: #plasma, hein, ngraham
      
      Reviewed By: ngraham
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T10047
      
      Differential Revision: https://phabricator.kde.org/D22988
      2054d9be
  5. 04 Jul, 2019 1 commit
    • Filip Fila's avatar
      [Kickoff] Redo tab bar separator's geometry · 76045bf2
      Filip Fila authored
      Summary:
      This patch makes Kickoff tab indicators glide (patch D22108) on the tab bar separator in all 4 orientations.
      
      I had to give up on the separator matching the width\height of the tab indicators because it was just never pixel perfect.
      
      Test Plan:
      Screenshots made with patch D22108 applied
      
      {F6939067}
      
      {F6939066}
      
      {F6939065}
      
      {F6939070}
      
      Reviewers: #plasma, #vdg, ndavis, ngraham
      
      Reviewed By: #vdg, ndavis, ngraham
      
      Subscribers: ngraham, ndavis, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D22128
      76045bf2
  6. 22 Jun, 2019 1 commit
  7. 02 May, 2019 1 commit
    • Filip Fila's avatar
      [Kickoff] Use simpler code for separator color · 935f3338
      Filip Fila authored
      Summary: The somewhat complex code for separator color in Kickoff creates issues with transparent themes. Separators can become barely visible, defeating the purpose of adding them. Relying on text color on the other hand is a safe bet to ensure visibility.
      
      Test Plan:
      Before:
      {F6804156}
      
      After:
      {F6804157}
      
      Breeze and Breeze Dark look the same as before:
      {F6804159}
      
      {F6804158}
      
      Reviewers: #vdg, ngraham
      
      Reviewed By: #vdg, ngraham
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D20973
      935f3338
  8. 18 Apr, 2019 1 commit
  9. 09 Mar, 2019 1 commit
  10. 21 Feb, 2019 2 commits
    • Nate Graham's avatar
      [Kickoff] Don't respond to window resizing/tiling shortcuts · 7a33e113
      Nate Graham authored
      Summary:
      This patch does for Kickoff what Kicker already does, and sets the maximum height
      equal to the minimum height. This makes it no longer respond to window tiling and
      maximize keyboard shortcuts.
      
      BUG: 402614
      FIXED-IN: 5.15.2
      
      Test Plan:
      Apply patch, restart plasmashell, open Kickoff, hit {key Meta PgUp}. Kickoff closes
      and the shortcut is passed down to the active app instead.
      
      Reviewers: #plasma, hein
      
      Reviewed By: #plasma, hein
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D19023
      7a33e113
    • Matthieu Gras's avatar
      [Kickoff] remove hint state · 1312ab1c
      Matthieu Gras authored and Nate Graham's avatar Nate Graham committed
      Summary: BUG: 404338
      
      Reviewers: #plasma, hein, ngraham
      
      Reviewed By: #plasma, hein, ngraham
      
      Subscribers: ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D19154
      1312ab1c
  11. 08 Feb, 2019 2 commits
  12. 19 Nov, 2018 1 commit
    • Krešimir Čohar's avatar
      [Kickoff] Make Kickoff separators leaner (less opaque) and narrower (the... · dfce5003
      Krešimir Čohar authored and Nate Graham's avatar Nate Graham committed
      [Kickoff] Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)
      
      Summary: Leaner separators in Kickoff (less opaque/more see-through, narrower/shorter)
      
      Test Plan:
      This patch would spruce up the much-needed separators in Kickoff that were discussed in D15011 and ultimately added in D15206. It would reduce the opacity of the separators by almost half and make the top separator (between the search field and the rest of the Kickoff menu) as long/wide as a highlighted menu item. This variant was actually put forward in D15011.
      
      >>! In D15011#314514, @ngraham wrote:
      > Perhaps the white background and blinking cursor appear too attention-getting in comparison to the rest of Kickoff, which tries very hard to be flat and gray and avoid separators (e.g. between the different sections and the tab bar at the bottom or the header on top). I wonder if we wouldn't feel like the search field was so jarring if there were better differentiation between other elements. For example:
      >
      > {F6212312}
      >
      
      See the difference in the screenshots below:
      
      {F6427577}
      {F6427578}
      
      Reviewers: ngraham, #vdg, romangg
      
      Reviewed By: ngraham, #vdg, romangg
      
      Subscribers: romangg, filipf, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D16937
      dfce5003
  13. 10 Nov, 2018 1 commit
  14. 31 Oct, 2018 1 commit
    • Nate Graham's avatar
      [Kickoff] Add a subtle separator line between the header and the content view · 7b26061f
      Nate Graham authored
      Summary: This is another idea that shook out of D15011: add subtle lines to separate the main content area from both the tab bar and the header, giving Kickoff some much-needed structure while still not overwhelming the user with lines and frames and chrome.
      
      Test Plan:
      Tested with Kickoff on a panel on all four different sides of the screen, and with Breeze light and Breeze dark themes.
      
      Examples with the default panel:
      {F6348699}
      {F6347337}
      
      Example with the panel on the right side: {F6347340}
      
      Reviewers: #plasma, #vdg
      
      Subscribers: abetts, mmustac, hein, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D15206
      7b26061f
  15. 27 Aug, 2018 1 commit
  16. 01 Jun, 2018 1 commit
    • Eike Hein's avatar
      Implement a triangle filter for mouse events on the Kickoff tabbar · 62f92fd8
      Eike Hein authored
      Summary:
      D11848 started out with the aim to remove the delay on Kickoff tab
      switching, but this proved contentious because it can cause user
      frustration over accidental tab switching when moving from the tab
      bar to the list view at angle, grazing another tab.
      
      This patch implements a triangle filter to get the best of both
      worlds. When the mouse motion vector is within the triangle from
      the vector starting coordinate pair to the relevant tab bar
      corners, the original 250ms delay remains in use. When the vector
      is outside the triangle, tabs are switched immediately - improving
      even over the 50ms delay proposed in D11848.
      
      Care is taken so that tab switching is always immediate when the
      tab bar is freshly entered, e.g. moving from the panel to Kickoff.
      
      As a small advantage this removes a MouseArea item from each tab
      button.
      
      BUG:388205
      
      Reviewers: ngraham, davidedmundson, rkflx, cfeck
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D13192
      62f92fd8
  17. 06 Mar, 2018 2 commits
  18. 05 Mar, 2018 1 commit
  19. 15 Feb, 2018 2 commits
  20. 14 Feb, 2018 1 commit
  21. 05 Jan, 2018 1 commit
  22. 13 Dec, 2017 1 commit
  23. 16 Nov, 2017 1 commit
    • Xuetian Weng's avatar
      Resolve the input method issue by always force focus in search field. · 44d8a750
      Xuetian Weng authored
      Summary:
      ActivityManager.qml doesn't have input method issue because the initial
      focus is inside the text field. So here we try to apply the same logic.
      Always force focus into the text field first, and handle the rest of key
      event accordingly. So we don't need to use event.text to append or do
      anything special, because event.text is not a input method compatible
      way to handle input.
      
      Test Plan:
      Manually test arrow key navigation. Also test input method typing is enabled
      when menu is opened.
      
      Reviewers: hein, mart
      
      Reviewed By: hein
      
      Subscribers: ngraham, ihipop, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D8770
      44d8a750
  24. 08 Sep, 2017 1 commit
    • Ivan Čukić's avatar
      Per-activity favorites (Final, again?) · 4ba9b01e
      Ivan Čukić authored
      Summary:
      The favourites are based on KAStats (already released version) **and kactivitymanagerd master (to be released with the next Plasma release)**. It allows favourites to be set to all activities, or the user can choose which activities to show a specific favourite application on.
      
      This change covers applications, files and contacts, other favourites are still based on the old model (now named SimpleFavoritesModel).
      
      {F1028047}
      
      Test Plan:
      Tested in Kicker, Dashboard and Kickoff the following:
      
      Transitioning mechanism:
      
       - load default favorites for the blank user
       - load custom default favorites set in the plasmoidsetupscripts script for Kicker
       - transition old results - when transitioning, merge the favourites from all launchers. The ordering for each launcher is kept separate (newly added items due to the merge go to the end)
      
      Favorite manipulation:
      
       - right-click add favorite to all activities
       - right-click remove favorite from all activities
       - right-click add favorite to specific activity (current)
       - right-click remove favorite from specific activity (current)
       - right-click add favorite to specific activity (not current)
       - right-click remove favorite from specific activity (not current)
       - right-click move from all to specific
       - right-click move from specific to all
       - right-click move from one activity to another
       - dnd reorder items in the model (up)
       - dnd reorder items in the model (down)
       - dnd add to favorites at a specific position
      
      Other:
       - launch the application
       - ordering persists after restart
       - ordering from the previous is kept on the activity that has no ordering
      
      Reviewers: mart, hein
      
      Reviewed By: hein
      
      Subscribers: Zren, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D3805
      4ba9b01e
  25. 30 May, 2017 1 commit
    • Harald Sitter's avatar
      add session and power mgmt runners to kickoff · d7376097
      Harald Sitter authored
      Summary:
      It's a bit weird that kickoff's leave tab has power management actions but
      you cannot actually invoke them via a search.
      
      CHANGELOG: Application Launcher supports searching for power actions
      
      Test Plan: changed, searching for shutdown lists the actual shutdown runnable as result
      
      Reviewers: hein, broulik
      
      Reviewed By: hein
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D6020
      d7376097
  26. 06 May, 2017 1 commit
  27. 06 Feb, 2017 1 commit
    • David Edmundson's avatar
      Fix i18n extraction in Kickoff Buttons · f8a9c373
      David Edmundson authored
      Summary:
      The current code returns a string containing an array of properties.
      This breaks i18n extraction as i18n() inside another string won't work.
      
      This patch returns properties as an object so that i18n translation
      works.
      
      The config is also changed so that extraction works properly.
      
      BUG: 375880
      
      Test Plan:
      Kickoff loads as before
      No i18n is nested in a string
      
      Reviewers: apol, #plasma, broulik
      
      Reviewed By: apol, #plasma, broulik
      
      Subscribers: broulik, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D4465
      f8a9c373
  28. 22 Nov, 2016 1 commit
    • Marco Martin's avatar
      tabbar on proper side when ltr · 460ea235
      Marco Martin authored
      Summary:
      when the layout is mirrored, the anchors are too, we end
      up on the tabbar anchored to the wrong side, swap left and right states
      when the application is mirrored, to keep the tabbar against the panel
      
      BUG:372720
      
      Test Plan:
      tried with plasmashell both normally and with --reverse parameter
      in both cases in vertical panels tabbar is on panel side
      
      Reviewers: #plasma
      
      Subscribers: broulik, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D3433
      460ea235
  29. 06 Oct, 2016 1 commit
    • Eike Hein's avatar
      Add an option to force alphabetic sorting to Kicker/Kickoff. · 5945063f
      Eike Hein authored
      Summary:
      And default to on.
      
      I don't like this, but downstream complains that their users get
      confused when using kmenuedit to edit their menu and newly-
      installed apps are no longer sorted-in alphabetically in the
      presence of the kmenuedit-generated files causing sorting to be
      disabled. And we don't have the resources to fix kmenuedit.
      
      Reviewers: mart
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D2940
      5945063f
  30. 18 Sep, 2016 1 commit
    • David Edmundson's avatar
      Kickoff: Ability to change the order of the menu items and hide them. · ece16109
      David Edmundson authored
      I'm using the Icons-Only Task Manager and it seems to me that the
      Favorites tab in kickoff is somewhat redundant, as I have added
      launchers for all of my favorites in the Icons-Only Task Manager.
      So in this patch I'm introducing an option to hide any menu and also
      according to bug 361210 to reorganize them.
      
      REVIEW: 128402
      ece16109
  31. 05 Sep, 2016 1 commit
  32. 09 May, 2016 1 commit
  33. 02 Dec, 2015 1 commit
  34. 11 Nov, 2015 1 commit
    • Eike Hein's avatar
      Port Kickoff to the Kicker backend. · 5108149f
      Eike Hein authored
      This raises Kickoff up to Kicker's feature level, in particular
      much more fleshed-out context menus and pervasive support for
      favoriting.
      
      Also drops a lot of gunk and cruft in the process.
      5108149f
  35. 28 Apr, 2015 1 commit
  36. 05 Apr, 2015 1 commit