GitLab

Tranter Madi authored Apr 20, 2020 and Nate Graham committed Apr 20, 2020

Summary:
When the root is in the "Search" state, we can safely disable it.

BUG: 401861

Reviewers: #plasma, hein, ngraham, davidedmundson

Reviewed By: #plasma, ngraham, davidedmundson

Subscribers: davidedmundson, ngraham, bugseforuns, dginovker, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28985

Summary:
Kickoff's separators were drawn as rectangles which doesn't allow them to be themed.

We have the infrastructure to theme lines though so this patch makes use of it.

The benefit is that themes can now gracefully incorporate separators into their design.

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D26866

Konstantin Lisin authored Aug 08, 2019 and Nate Graham committed Aug 08, 2019

Summary:
This fixes the broken layout of the tab bar (tab bar takes the whole view)
when a panel is changed from horizontal to vertical that persists
until plasmashell is restarted.
BUG: 393888

Test Plan:
Change panel orientation from horizontal to vertical. Open Kickoff.
Before fix: tab bar fills the whole view making the Kickoff unusable even if you make the panel horizontal again.
After fix: tab bar has the correct size.

Reviewers: #plasma, hein, ngraham

Reviewed By: ngraham

Subscribers: plasma-devel

Tags: #plasma

Maniphest Tasks: T10047

Differential Revision: https://phabricator.kde.org/D22988

Summary:
This patch makes Kickoff tab indicators glide (patch D22108) on the tab bar separator in all 4 orientations.

I had to give up on the separator matching the width\height of the tab indicators because it was just never pixel perfect.

Test Plan:
Screenshots made with patch D22108 applied

{F6939067}

{F6939066}

{F6939065}

{F6939070}

Reviewers: #plasma, #vdg, ndavis, ngraham

Reviewed By: #vdg, ndavis, ngraham

Subscribers: ngraham, ndavis, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D22128

Summary: BUG:401861

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D21988

Summary: The somewhat complex code for separator color in Kickoff creates issues with transparent themes. Separators can become barely visible, defeating the purpose of adding them. Relying on text color on the other hand is a safe bet to ensure visibility.

Test Plan:
Before:
{F6804156}

After:
{F6804157}

Breeze and Breeze Dark look the same as before:
{F6804159}

{F6804158}

Reviewers: #vdg, ngraham

Reviewed By: #vdg, ngraham

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D20973

Summary: This minor patch shortens the tabbar separator so that it is not longer than the width of leftmost and rightmost tab selection line.

Test Plan:
Before:
{F6780782}

After:
{F6780783}

Reviewers: #vdg, ngraham

Reviewed By: #vdg, ngraham

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D20676

Summary:
This patch does for Kickoff what Kicker already does, and sets the maximum height
equal to the minimum height. This makes it no longer respond to window tiling and
maximize keyboard shortcuts.

BUG: 402614
FIXED-IN: 5.15.2

Test Plan:
Apply patch, restart plasmashell, open Kickoff, hit {key Meta PgUp}. Kickoff closes
and the shortcut is passed down to the active app instead.

Reviewers: #plasma, hein

Reviewed By: #plasma, hein

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D19023

Matthieu Gras authored Feb 21, 2019 and Nate Graham committed Feb 21, 2019

Summary: BUG: 404338

Reviewers: #plasma, hein, ngraham

Reviewed By: #plasma, hein, ngraham

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D19154

Summary:
This patch fixes the bug that would make Kickoff retain the contents of the tab that was selected when a search was run from a tab other than
Favorites (but at the same time highlight Favorites in the Tab Bar, when it was in fact, stuck on another tab).

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D18848

Summary:
This patch fixes the bug that would make Kickoff retain the contents of the tab that was selected when a search was run from a tab other than
Favorites (but at the same time highlight Favorites in the Tab Bar, when it was in fact, stuck on another tab).

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D18848

Krešimir Čohar authored Nov 19, 2018 and Nate Graham committed Nov 19, 2018

[Kickoff] Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

Summary: Leaner separators in Kickoff (less opaque/more see-through, narrower/shorter)

Test Plan:
This patch would spruce up the much-needed separators in Kickoff that were discussed in D15011 and ultimately added in D15206. It would reduce the opacity of the separators by almost half and make the top separator (between the search field and the rest of the Kickoff menu) as long/wide as a highlighted menu item. This variant was actually put forward in D15011.

>>! In D15011#314514, @ngraham wrote:
> Perhaps the white background and blinking cursor appear too attention-getting in comparison to the rest of Kickoff, which tries very hard to be flat and gray and avoid separators (e.g. between the different sections and the tab bar at the bottom or the header on top). I wonder if we wouldn't feel like the search field was so jarring if there were better differentiation between other elements. For example:
>
> {F6212312}
>

See the difference in the screenshots below:

{F6427577}
{F6427578}

Reviewers: ngraham, #vdg, romangg

Reviewed By: ngraham, #vdg, romangg

Subscribers: romangg, filipf, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D16937

Summary: This is another idea that shook out of D15011: add subtle lines to separate the main content area from both the tab bar and the header, giving Kickoff some much-needed structure while still not overwhelming the user with lines and frames and chrome.

Test Plan:
Tested with Kickoff on a panel on all four different sides of the screen, and with Breeze light and Breeze dark themes.

Examples with the default panel:
{F6348699}
{F6347337}

Example with the panel on the right side: {F6347340}

Reviewers: #plasma, #vdg

Subscribers: abetts, mmustac, hein, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D15206

Summary:
D11848 started out with the aim to remove the delay on Kickoff tab
switching, but this proved contentious because it can cause user
frustration over accidental tab switching when moving from the tab
bar to the list view at angle, grazing another tab.

This patch implements a triangle filter to get the best of both
worlds. When the mouse motion vector is within the triangle from
the vector starting coordinate pair to the relevant tab bar
corners, the original 250ms delay remains in use. When the vector
is outside the triangle, tabs are switched immediately - improving
even over the 50ms delay proposed in D11848.

Care is taken so that tab switching is always immediate when the
tab bar is freshly entered, e.g. moving from the panel to Kickoff.

As a small advantage this removes a MouseArea item from each tab
button.

BUG:388205

Reviewers: ngraham, davidedmundson, rkflx, cfeck

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D13192

Summary:
Qt documentation recomends to bind to opacity instead of visible as visible
cascades down. The tabbar used to trigger its height behavior anim when the
popup got hidden, binding to opacity (even if opacity isn't animated) is a
more correct behavior.
Plus with visible it triggers the Qt bug https://bugreports.qt.io/browse/QTBUG-66907
which in turn triggers https://bugs.kde.org/show_bug.cgi?id=391432

BUG:391432

Test Plan: kickoff never opens the last tab anymore

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D11098

Summary:
Qt documentation recomends to bind to opacity instead of visible as visible
cascades down. The tabbar used to trigger its height behavior anim when the
popup got hidden, binding to opacity (even if opacity isn't animated) is a
more correct behavior.
Plus with visible it triggers the Qt bug https://bugreports.qt.io/browse/QTBUG-66907
which in turn triggers https://bugs.kde.org/show_bug.cgi?id=391432

BUG:391432

Test Plan: kickoff never opens the last tab anymore

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D11098

Sergei Lopatin authored Mar 05, 2018 and Eike Hein committed Mar 05, 2018

Summary: This is follow up fix for [[ https://phabricator.kde.org/D8816 | D8816 ]]. It enables showing root items in kicker and kickoff menus but not in dash.

Reviewers: hein

Reviewed By: hein

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D10938

It's only used there.

Differential Revision: https://phabricator.kde.org/D10540

Kickoff uses AppsModel instead of RootModel but since RootModel inherits AppsModel we can just move everything over here.

Differential Revision: https://phabricator.kde.org/D10506

In Kickoff you can re-arrange and hide individual tab buttons.
If you remove all but one the tab bar becomes pointless.

BUG: 388521
FIXED-IN: 5.12.0

Differential Revision: https://phabricator.kde.org/D9655

It is only accessed from items within it (KickoffItem), there's no need to create it initially.

Differential Revision: https://phabricator.kde.org/D9314

Summary:
ActivityManager.qml doesn't have input method issue because the initial
focus is inside the text field. So here we try to apply the same logic.
Always force focus into the text field first, and handle the rest of key
event accordingly. So we don't need to use event.text to append or do
anything special, because event.text is not a input method compatible
way to handle input.

Test Plan:
Manually test arrow key navigation. Also test input method typing is enabled
when menu is opened.

Reviewers: hein, mart

Reviewed By: hein

Subscribers: ngraham, ihipop, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D8770

Summary:
The favourites are based on KAStats (already released version) **and kactivitymanagerd master (to be released with the next Plasma release)**. It allows favourites to be set to all activities, or the user can choose which activities to show a specific favourite application on.

This change covers applications, files and contacts, other favourites are still based on the old model (now named SimpleFavoritesModel).

{F1028047}

Test Plan:
Tested in Kicker, Dashboard and Kickoff the following:

Transitioning mechanism:

 - load default favorites for the blank user
 - load custom default favorites set in the plasmoidsetupscripts script for Kicker
 - transition old results - when transitioning, merge the favourites from all launchers. The ordering for each launcher is kept separate (newly added items due to the merge go to the end)

Favorite manipulation:

 - right-click add favorite to all activities
 - right-click remove favorite from all activities
 - right-click add favorite to specific activity (current)
 - right-click remove favorite from specific activity (current)
 - right-click add favorite to specific activity (not current)
 - right-click remove favorite from specific activity (not current)
 - right-click move from all to specific
 - right-click move from specific to all
 - right-click move from one activity to another
 - dnd reorder items in the model (up)
 - dnd reorder items in the model (down)
 - dnd add to favorites at a specific position

Other:
 - launch the application
 - ordering persists after restart
 - ordering from the previous is kept on the activity that has no ordering

Reviewers: mart, hein

Reviewed By: hein

Subscribers: Zren, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D3805

Summary:
It's a bit weird that kickoff's leave tab has power management actions but
you cannot actually invoke them via a search.

CHANGELOG: Application Launcher supports searching for power actions

Test Plan: changed, searching for shutdown lists the actual shutdown runnable as result

Reviewers: hein, broulik

Reviewed By: hein

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D6020

Summary: Created a new tab to show most used documents/applications, disabled by default.

Reviewers: hein, mart, sebas

Reviewed By: hein

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D5620

Summary:
The current code returns a string containing an array of properties.
This breaks i18n extraction as i18n() inside another string won't work.

This patch returns properties as an object so that i18n translation
works.

The config is also changed so that extraction works properly.

BUG: 375880

Test Plan:
Kickoff loads as before
No i18n is nested in a string

Reviewers: apol, #plasma, broulik

Reviewed By: apol, #plasma, broulik

Subscribers: broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D4465

Summary:
when the layout is mirrored, the anchors are too, we end
up on the tabbar anchored to the wrong side, swap left and right states
when the application is mirrored, to keep the tabbar against the panel

BUG:372720

Test Plan:
tried with plasmashell both normally and with --reverse parameter
in both cases in vertical panels tabbar is on panel side

Reviewers: #plasma

Subscribers: broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D3433

Summary:
And default to on.

I don't like this, but downstream complains that their users get
confused when using kmenuedit to edit their menu and newly-
installed apps are no longer sorted-in alphabetically in the
presence of the kmenuedit-generated files causing sorting to be
disabled. And we don't have the resources to fix kmenuedit.

Reviewers: mart

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D2940

I'm using the Icons-Only Task Manager and it seems to me that the
Favorites tab in kickoff is somewhat redundant, as I have added
launchers for all of my favorites in the Icons-Only Task Manager.
So in this patch I'm introducing an option to hide any menu and also
according to bug 361210 to reorganize them.

REVIEW: 128402

Neither the apps model nor favorites model is needed initially.
Move them to the fullRepresentation so they're only loaded as needed.

Differential Revision: https://phabricator.kde.org/D2656

The pad property was not used and the debug thing just for some commented Rectangles

This raises Kickoff up to Kicker's feature level, in particular
much more fleshed-out context menus and pervasive support for
favoriting.

Also drops a lot of gunk and cruft in the process.

REVIEW: 123530
CHANGELOG: User icon and search field are now clickable in the menu

BUG: 345865