GitLab

Summary: Jonathan uses en_GB.dict that diverges slightly from en.dict. They both should be taken into account properly.

Test Plan: Used Jon's env var

Reviewers: #plasma, jriddell

Reviewed By: #plasma, jriddell

Subscribers: jriddell, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D25823

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Nowadays we place avatars inside a circle with an always visible border.

The default avatar has not been adjusted for this and has both its own dimensions and positioning.

This patch has it fill the avatar circle and shifts it upwards a bit because otherwise the avatar overflows the circle when scaling is increased.

Anchors.bottomMargin is used instead of anchors.margins because the latter results in a blurry SVG, while the former doesn't and looks just fine.

BUG: 414687

It was done because the drawer was doing weird things with it, but we
are not showing the full global drawer anymore.

It blends better on the UX, works just as well.

editingFinished would get triggered when the window changes and would
feel unpredictable.

Removes weird margin on the right side and the delegates look purposely
placed.

Summary:
Crop the square user avatar into a circle with an outline, like in SDDM and
the lock screen.

BUG:  386656
FIXED-IN: 5.18.0

Test Plan:
- Use Kickoff
- Change/set avatar in User Manager
- See pretty circle-cropped avatar

{F7777572, size=full}

Reviewers: sharvey, #vdg, #plasma, mart

Reviewed By: #vdg, #plasma, mart

Subscribers: filipf, sefaeyeoglu, hein, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D13415

Test Plan: Builds

Reviewers: hein, apol

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24238

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Steffen Hartleib authored Nov 15, 2019 and Nate Graham committed Nov 15, 2019

Summary:
- enabled touch scrolling in Kickoff
- open the correct category in the application tab
- open the context menu with touch (tapandhold gesture similar to Windows 10)
- start drag action with touch similar to Windows 10

BUG: 406359
BUG: 406361
FIXED-IN: 5.18

Reviewers: #plasma, hein, ngraham

Reviewed By: ngraham

Subscribers: niccolove, khuoman, mart, sbergeron, davidedmundson, ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D21829

Currently, if there is only one button from input method, it is
sometimes impossible to hide any button, because the menu popup may
cause lost of focus and button changes as soon as you right click the
menu. The original logic is to prevent hide all the buttons, but since
we now have placeholder, we can just simply hide any button.

Summary:
ibus installs with the file en_GB.dict same with an underscore as a
separator for all regional variants.

The bcp47 name uses a hyphen.

Test Plan: I see emoticons

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D25156

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
The task manager shows an indicator on tasks playing audio (when
enabled in the settings). This patch adds the ability to mute/unmute
an application playing audio by clicking on the audio indicator in
the task manager.

Test Plan:
* Check "Mark applications that play audio" in the Task Manager Settings
* Open an application that plays audio
* Click on the audio indicator and it should toggle the mute state
{F7324364}

Reviewers: #plasma, #vdg, ngraham, filipf, hein, faridb

Reviewed By: #plasma, #vdg, ngraham, hein

Subscribers: GB_2, mart, hein, filipf, mvourlakos, ngraham, broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D19822

Summary:
No need to replace the current engine if we already have an acceptable one set.

Otherwise it confuses Qt and it asserts in Qt.

```
 7  0x00007f517fcdf8e6 in qt_assert (assertion=assertion@entry=0x7f5179fee560 "engine_name == desc.engine_name", file=file@entry=0x7f5179fee318 "/home/apol/devel/frameworks/qt5/qtbase/src/plugins/platforminputcontexts/ibus/qibusplatforminputcontext.cpp",
    line=line@entry=583) at ../../include/QtCore/../../../../../devel/frameworks/qt5/qtbase/src/corelib/global/qlogging.h:90
 8  0x00007f5179fdb6f4 in QIBusPlatformInputContext::globalEngineChanged (this=0x55831b2c7ff0, engine_name=...) at ../../../../include/QtCore/../../../../../devel/frameworks/qt5/qtbase/src/corelib/tools/qarraydata.h:236
 9  0x00007f5179fe7f6d in QIBusPlatformInputContext::qt_static_metacall (_o=<optimized out>, _c=<optimized out>, _id=<optimized out>, _a=<optimized out>) at .moc/moc_qibusplatforminputcontext.cpp:147
```

Test Plan:
Now I can start the plasmoid without it crashing.
I'm guessing users so far were running against a release build of Qt without asserts.
Starting ibus with the session now works as well, in contrast to having to start it explicitly

Reviewers: hein

Reviewed By: hein

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D25045

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Done by clazy

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"