1. 10 Dec, 2019 1 commit
  2. 31 Oct, 2019 1 commit
    • Aleix Pol Gonzalez's avatar
      kimpanel: don't crash when ibus is already loaded · 299f298d
      Aleix Pol Gonzalez authored
      Summary:
      No need to replace the current engine if we already have an acceptable one set.
      
      Otherwise it confuses Qt and it asserts in Qt.
      
      ```
       7  0x00007f517fcdf8e6 in qt_assert (assertion=assertion@entry=0x7f5179fee560 "engine_name == desc.engine_name", file=file@entry=0x7f5179fee318 "/home/apol/devel/frameworks/qt5/qtbase/src/plugins/platforminputcontexts/ibus/qibusplatforminputcontext.cpp",
          line=line@entry=583) at ../../include/QtCore/../../../../../devel/frameworks/qt5/qtbase/src/corelib/global/qlogging.h:90
       8  0x00007f5179fdb6f4 in QIBusPlatformInputContext::globalEngineChanged (this=0x55831b2c7ff0, engine_name=...) at ../../../../include/QtCore/../../../../../devel/frameworks/qt5/qtbase/src/corelib/tools/qarraydata.h:236
       9  0x00007f5179fe7f6d in QIBusPlatformInputContext::qt_static_metacall (_o=<optimized out>, _c=<optimized out>, _id=<optimized out>, _a=<optimized out>) at .moc/moc_qibusplatforminputcontext.cpp:147
      ```
      
      Test Plan:
      Now I can start the plasmoid without it crashing.
      I'm guessing users so far were running against a release build of Qt without asserts.
      Starting ibus with the session now works as well, in contrast to having to start it explicitly
      
      Reviewers: hein
      
      Reviewed By: hein
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D25045
      299f298d
  3. 03 Jan, 2019 1 commit
  4. 16 Nov, 2018 1 commit
  5. 07 Mar, 2018 1 commit
  6. 17 Jul, 2017 1 commit
  7. 05 Apr, 2017 1 commit
  8. 08 Jan, 2016 1 commit