1. 22 Apr, 2020 1 commit
    • Cyril Rossi's avatar
      KCM LookAndFeel check widgetStyle availability before applying it · 17ef374a
      Cyril Rossi authored
      Summary:
      BUG: 419552
      * Some Global Theme may refer to breeze widget style with a lower case b, apply the proper name `Breeze`
      
      BUG: 418698
      * Some Global Theme use widget style that may not be installed, then don't apply it.
      
      Test Plan:
      * Open KCM LookAndFeel, open GHNS and install Qogir-light theme, then apply it. Open Application Style KCM, if kvantum is not installed, Breeze is highlighted.
      * Open KCM LookAndFeel, open GHNS and install Aritim-Light, then apply it. Open Application Style KCM, Breeze is highlighted.
      
      Reviewers: #plasma, ervin, bport, meven, ngraham
      
      Reviewed By: ervin, ngraham
      
      Subscribers: ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D28662
      17ef374a
  2. 21 Feb, 2020 1 commit
    • Cyril Rossi's avatar
      KCM look and feel : set proper default values for kwin kdecoration when applying global style · 56fd9833
      Cyril Rossi authored
      Summary: BUG: 397595
      
      Test Plan:
      KCM Look and feel, apply Breeze or Breeze Dark global style, then go to KCM KWin Decoration (Window Decoration), no decoration is highlighted in the grid.
      In kwinrc, the group `[org.kde.kdecoration2]` has a `theme=` with no value.
      
      With this patch, applying Breeze or Breeze Dark global theme will write the proper value in kwinrc and the KCM KWin Decoration will show the correct decoration highlighted.
      
      Reviewers: ervin, bport, meven, davidedmundson, #plasma, ngraham
      
      Reviewed By: ngraham
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D27483
      
      (cherry picked from commit 6d3d3ffa)
      56fd9833
  3. 02 Jan, 2020 1 commit
    • Johan Ouwerkerk's avatar
      Make the lookandfeel KCM build without XCursor support · 1c43e1b4
      Johan Ouwerkerk authored
      Summary:
      With this change the lookandfeel KCM can be built without X11 cursor development headers.
      In the case the KCM is built without XCursor support, it will not be able to reload the cursor dynamically at runtime but it will still be able to configure cursor themes.
      
      This is an alternative to: D26344 (https://phabricator.kde.org/D26344)
      
      Test Plan: plasma-desktop builds using kdesrc-build with and without X11 cursor development headers present.
      
      Reviewers: davidedmundson, #plasma
      
      Reviewed By: davidedmundson, #plasma
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26367
      1c43e1b4
  4. 25 Nov, 2019 1 commit
  5. 30 Oct, 2019 1 commit
    • Dan Leinir Turthra Jensen's avatar
      Require and use the new NewStuffQuick Button component · c21a8bd8
      Dan Leinir Turthra Jensen authored
      Summary:
      This removes the need for the custom hack for spawning a dialog,
      and is intended to function as a sample for how to implement this
      in other KCMs.
      
      Also use the big, pretty Preview mode (because super-visual content)
      
      This could be done wholesale for the entire bunch of KCMs, but i post
      this on its own in an attempt to gain feedback on a self contained
      example of how to do this porting step.
      
      Without this patch:
      {F7668236}
      
      With this patch:
      {F7668234}
      
      Depends on D25041
      
      Reviewers: #plasma, #knewstuff, #vdg, broulik, ngraham
      
      Reviewed By: #vdg, ngraham
      
      Subscribers: ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D24942
      c21a8bd8
  6. 22 Oct, 2019 2 commits
  7. 15 Aug, 2019 1 commit
  8. 09 Aug, 2019 1 commit
    • Nate Graham's avatar
      Rename "Look and Feel" KCM to "Global Theme" · 5809c038
      Nate Graham authored
      Summary:
      This implements one of the changes decided upon in T11314. The rationale is as follows:
      
      The old text ("Look and Feel") is a generic term and could be referring to any of the
      other appearance settings. The new text "Global Theme" is more descriptive and accurate
      and makes this KCM's relationship to everything else clear, especially once it's the only
      KCM that uses the word "Theme" (see D22880).
      
      Test Plan: {F7142701}
      
      Reviewers: #vdg, #plasma, GB_2, mart
      
      Reviewed By: #vdg, #plasma, GB_2, mart
      
      Subscribers: mart, GB_2, plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T11314
      
      Differential Revision: https://phabricator.kde.org/D22879
      5809c038
  9. 20 May, 2019 1 commit
  10. 13 Feb, 2019 1 commit
    • Filip Fila's avatar
      Make Appearance KCMs' labels consistent · 089612d2
      Filip Fila authored and Krešimir Čohar's avatar Krešimir Čohar committed
      Summary:
      With the purpose of making KCMs more consistent and following the HIG, this patch does the following:
      
      - Converts all .desktop file "Comment" values into action(verb)-style labels
      - Drops the use of articles in "Comment" values
      - Changes the KAboutData i18n strings so that they match the respective KCM's name
      
      Reviewers: GB_2, #vdg, ngraham, #plasma
      
      Reviewed By: GB_2, #vdg, ngraham
      
      Subscribers: davidedmundson, broulik, plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T10273
      
      Differential Revision: https://phabricator.kde.org/D18903
      089612d2
  11. 07 Feb, 2019 1 commit
  12. 05 Feb, 2019 1 commit
    • Kai Uwe Broulik's avatar
      [Look and Feel KCM] Write schemeName last · bbf848a9
      Kai Uwe Broulik authored
      We copy the .colors file's contents into kdeglobals and I have seen many of them containing bogus
      
      [General]
      ColorScheme=Some Other Scheme
      which makes no sense. Ensure the ColorScheme that ends up in kdeglobals is the scheme defined by the look and feel package.
      
      BUG: 403774
      FIXED-IN: 5.15.0
      
      Differential Revision: https://phabricator.kde.org/D18754
      bbf848a9
  13. 13 Jan, 2019 1 commit
    • Björn Feber's avatar
      Improve the Look and Feel KCM · beca304a
      Björn Feber authored
      Summary:
      The LnF KCM has some inconsistencies and doesn't always apply the KDE HIG, so this fixes it and makes some other improvements.
      {F6546516}
      
      Test Plan: Open the LnF KCM
      
      Reviewers: #plasma, #vdg, ngraham
      
      Reviewed By: #vdg, ngraham
      
      Subscribers: ngraham, rooty, rizzitello, abetts, filipf, #vdg, plasma-devel, #plasma
      
      Tags: #plasma
      
      Maniphest Tasks: T10273
      
      Differential Revision: https://phabricator.kde.org/D18206
      beca304a
  14. 26 Jul, 2018 1 commit
  15. 25 May, 2018 1 commit
  16. 16 Apr, 2018 1 commit
    • Marco Martin's avatar
      port the look and feel kcm to new design · 0b91f62e
      Marco Martin authored
      Summary:
      use the new design for the look and feel kcm, together with
      a massive code simplification
      
      Test Plan: pply does work, as preview of themes
      
      Reviewers: #plasma, #vdg, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: davidedmundson, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D12090
      0b91f62e
  17. 06 Apr, 2018 1 commit
    • Marco Martin's avatar
      support for standalone ksplash themes · 465e86ee
      Marco Martin authored
      Summary:
      support the new standalone splashscreens of D11918
      also add a GHNS button for the new splashscreen store category
      
      FEATURE: 358839
      
      Test Plan:
      splashscreens are correctly listed, installed and removed
      both ones in lnf packages and standalone are listed.
      
      Reviewers: #plasma, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: davidedmundson, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D11919
      465e86ee
  18. 18 Feb, 2018 1 commit
    • Friedrich W. H. Kossebau's avatar
      [lookandfeel kcm] Do not declare plugin in lookandfeeltool code version, v2 · f7fd7125
      Friedrich W. H. Kossebau authored
      Summary:
      Also improves race condition on creating the JSON file and running
      automoc over the cpp file which refers to it, given there is no
      dependency chain defined at all for the lookandfeeltool target and
      that kcm_lookandfeel.json, which was prone to make highly parallel
      builds fail
      
      Moving the K_PLUGIN_FACTORY_WITH_JSON into a separate file only added
      to the sources of kcm_lookandfeel, instead of hiding with an ifndef for
      the build of the lookandfeeltool target as tried before, should avoid
      any potential confusion of automoc as reported from some builds
      (on KDE neon?).
      
      Reviewers: #freebsd, tcberner, bshah, mart, davidedmundson
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D10607
      f7fd7125
  19. 17 Feb, 2018 1 commit
  20. 16 Feb, 2018 1 commit
    • Friedrich W. H. Kossebau's avatar
      [Look and feel KCM] Fix copying color scheme data · 6ab44dcb
      Friedrich W. H. Kossebau authored
      Summary:
      Using one argument with "KSharedConfig::openConfig(filename)" actually
      results in using the default value for the second argument, "FullConfig".
      Which results also in "Blend kdeglobals into the config object."
      As a result the color scheme file opened in KCMLookandFeel::setColors(...)
      this way has the complete global config groups and settings (with the data
      as stored on the disc, not in any runtime working copies) mapped into the
      profile (incl. e.g. the group "[General]" with the entry "ColorScheme").
      So when then all the groups are copied over from the scheme config, actually
      also all the stored global config groups and settings are copied over,
      overwriting the not yet synced [General]/ColorScheme entry, which was just
      set a few lines before, again with the old value from the storage.
      
      Possibly the old code which was doing the sync right after setting the new
      scheme value had been there exactly to protect against that
      (cmp. change in cf49d415).
      
      Reviewers: broulik, davidedmundson, mart
      
      Reviewed By: broulik
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D10259
      6ab44dcb
  21. 15 Feb, 2018 1 commit
  22. 14 Feb, 2018 1 commit
  23. 02 Feb, 2018 1 commit
  24. 31 Jan, 2018 1 commit
  25. 26 Jan, 2018 2 commits
  26. 25 Jan, 2018 1 commit
  27. 19 Dec, 2017 1 commit
    • Marco Martin's avatar
      Add a commandline tool to switch lnf package · 46fcd51d
      Marco Martin authored
      Summary:
      using the kcm c++ itself to do the switch, have a tool
      that can be used to switch lnf package from the command line
      
      Test Plan: running the tool has the same effect of chosing a lnf trough the kcm
      
      Reviewers: #plasma, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: davidedmundson, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D9411
      46fcd51d
  28. 13 Dec, 2017 1 commit
    • Marco Martin's avatar
      support for defining autostart apps in lnf packages · 49ae81f2
      Marco Martin authored
      Summary:
      meant to support layouts that want external apps such as lattedock
      or conky, it adds services (in the defaults file they're saved as
      the filename of the desktop file) in autostart and starts immediately
      the app as well.
      before applying a lnf, it removes from autostart anything the old
      package had and attempts to stop the apps
      
      Test Plan:
      tried to start/stop lattedock with the mechanism
      some fallback may be needed for non kde apps
      
      Reviewers: #plasma, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: ngraham, mvourlakos, apol, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D9288
      49ae81f2
  29. 23 Jan, 2017 1 commit
  30. 10 Jan, 2017 1 commit
    • Marco Martin's avatar
      heuristically find the color scheme · fcfd900a
      Marco Martin authored
      Summary:
      why this loop trough all the scheme files?
      the scheme theme name is an heuristic, there is no plugin metadata whatsoever.
      is based on the file name stripped from weird characters or the
      eventual id- prefix store.kde.org puts, so we can just find a
      theme that ends as the specified name
      
      Test Plan:
      now themes downloaded from store.kde.org are correctly applied
      such as "Kshell" use case
      
      Reviewers: #plasma, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D4066
      fcfd900a
  31. 04 Jan, 2017 1 commit
    • Marco Martin's avatar
      import kwin deco and button order in l&f · 81be6962
      Marco Martin authored
      Summary:
      support both button order and decoration theme
      of kwin when applying for a lnf theme. The deco
      theme is composed by library and theme entries.
      c++ themes will only use library, aurorae themes will use
      theme as well.
      
      BUG:370511
      
      Test Plan: created some lnf packages that customize this and applied
      
      Reviewers: #plasma, graesslin
      
      Reviewed By: #plasma, graesslin
      
      Subscribers: Lucas, graesslin, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D3832
      81be6962
  32. 28 Nov, 2016 1 commit
    • Marco Martin's avatar
      Select correct index without timer · ee2ec66a
      Marco Martin authored
      Summary:
          remove the timer that selects the index at startup
          that caused flickering and things moving around since
          index 0 got selected, then moved to the correct one only after a while.
      
          unfortunately there is not a place (a signal) that says
          "the view has been correctly instanced from the model" that
          would be where selecting the current index at startup would be the safest.
          a place that seems working correctly is on listview onCountChanged
      
          this has to introduce KCMLookandFeel::selectedPluginIndex
          that isn't very pretty, but the flickering seems to be gone and
          the kcm loads from the correct place of the view from the first
          frame is displayed
      
      Test Plan: he flickering seems to be gone and the kcm loads from the correct place of the view from the first frame is displayed. Once this is in the final form, some other config dialogs need the same treatment: plasma theme and wallpapers
      
      Reviewers: #plasma, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: davidedmundson, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D3528
      ee2ec66a
  33. 23 Aug, 2016 1 commit
    • Marco Martin's avatar
      add a preview button and a fullscreen preview · 19368a43
      Marco Martin authored
      Summary:
      preview button for themes, launches a fullscreen preview for the theme
      the preview image is shown as big as possible, either 1:1 or
      scaled down to screen size.
      
      clicking anywhere (or in the top right close button) dismissed the
      fullscreen dialog
      
      the thumbnail uses a plasma toolbutton, but in that particular point is fine
      to use a plasma control, because it's on top of an image, it's
      a custom graphics zone, where on the other hand a system style
      toolbutton wouldn't work well.
      
      Reviewers: #plasma, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: davidedmundson, plasma-devel
      
      Tags: #plasma, #vdg
      
      Differential Revision: https://phabricator.kde.org/D2550
      19368a43
  34. 19 Aug, 2016 1 commit
  35. 28 Jun, 2016 1 commit
  36. 11 Mar, 2016 1 commit
  37. 01 Mar, 2016 1 commit
  38. 01 Nov, 2015 1 commit