1. 28 Oct, 2019 1 commit
    • Gabriel Craciunescu's avatar
      Fix force font DPI UI logic · e37f9dba
      Gabriel Craciunescu authored and Nate Graham's avatar Nate Graham committed
      The kcm UI has right now a step size of 24 with a max size of 1000 and a minimum of 1.
      Max size need to divide to step size and the lowest possible value should be the step size
      because  0 means disabled.
      Reviewers: davidedmundson, #plasma
      Reviewed By: davidedmundson, #plasma
      Subscribers: plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D25004
  2. 21 Oct, 2019 1 commit
    • Nate Graham's avatar
      [KCMs] Make spinboxes editable · 4f90a137
      Nate Graham authored
      Otherwise they're annoying to use because you can only interact with them using a scroll
      or by clicking on the tiny arrows.
      Test Plan: You can now enter text in the spinboxes
      Reviewers: #vdg, #plasma
      Subscribers: plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D24814
  3. 16 Oct, 2019 1 commit
  4. 26 Jul, 2019 1 commit
  5. 11 Jul, 2019 1 commit
  6. 27 May, 2019 1 commit
    • Julian Wolff's avatar
      Parse global config files. Remove 'Vendor default' option. Fix changes not recognized. · 39c6facc
      Julian Wolff authored and Bhushan Shah's avatar Bhushan Shah committed
      The fonts kcm did only parse a local config file. Global and default settings were not recognized.
      With this patch, all global config files are parsed before the local file is parsed.
      This allows us to drop the "Vendor default" option.
      This patch also fixes some changes not recognized (apply button disabled).
      CCBUG: 386566
      Test Plan:
      Delete `~/.config/fontconfig/fonts.conf` and `~/.config/kcmfonts` .
      Run `kcmshell5 fonts`. The default/global settings should be displayed.
      Change some settings. The apply button should be enabled.
      Save. A new config file should be created.
      Follow up of the D12925
  7. 10 Feb, 2019 1 commit
    • Björn Feber's avatar
      Improve the look of the Fonts KCM UI · 9dac09af
      Björn Feber authored
      Makes some improvements to the Fonts KCM UI, like applying the KDE HIG, adding icons and tooltips to buttons and improving the buttons, updating strings and more.
      Test Plan: Open the Fonts KCM.
      Reviewers: #plasma, #vdg, ngraham, rooty, davidedmundson
      Reviewed By: #plasma, #vdg, ngraham, rooty, davidedmundson
      Subscribers: davidedmundson, ndavis, ngraham, rooty, plasma-devel, #vdg, #plasma
      Tags: #plasma
      Maniphest Tasks: T10273
      Differential Revision: https://phabricator.kde.org/D18861
  8. 01 Jan, 2019 1 commit
  9. 21 Dec, 2018 1 commit
  10. 11 Dec, 2018 1 commit
    • David Edmundson's avatar
      [kcms/fonts] Don't set minimium DPI value · 61b6e098
      David Edmundson authored
      The QML port added a minimum value for the font DPI, the old widgets
      code goes went 1 to 1000.
      A slight bodge is needed to make sure we start at 96 when a user first
      toggles force font DPI, which used to implicitly work as a minimum was
      BUG: 395575
      Test Plan:
      Set different value, looked at xrdb -q | grep -i dpi
      set another value
      Reviewers: #plasma, ngraham
      Reviewed By: ngraham
      Subscribers: ngraham, plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D17412
  11. 28 Sep, 2018 1 commit
    • Nate Graham's avatar
      [Fonts KCM] remove filler words from anti-aliasing settings' labels · 5960f6cc
      Nate Graham authored
      This is a new version of D13593 with only the non-controversial changes (plus one new change, because I just can't resist stirring the pot :) ):
      - "Use Anti-aliasing" -> "Anti-aliasing": The verb is not needed and in fact becomes awkward with the combobox's options
      - "Sub-pixel rendering type" -> "Sub-pixel rendering"; "type" is just useless filler that lengthens the string and doesn't add any information
      - "Hinting style" -> "Hinting" -> same thing; "style" is just filler
      Also added context to help translators come up with the best translations for the now shorter strings.
      Test Plan: {F6283477}
      Reviewers: #vdg, #plasma, mart
      Reviewed By: #vdg, #plasma, mart
      Subscribers: abetts, svenmauch, plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D15738
  12. 19 Jun, 2018 1 commit
  13. 08 Jun, 2018 1 commit
    • __ __'s avatar
      Fonts KCM: Fix text readability regression · 540edfdd
      __ __ authored
      Porting the Fonts KCM to QML in 24b960f9 set the state of the font
      preview labels to `disabled`, resulting in a light gray text with too
      little contrast to enable a usable preview of the chosen font.
      In the `QWidgets` based KCM the following code was used:
        QLabel::setFrameStyle(QFrame::StyledPanel | QFrame::Sunken)
      As that property is not available from QML, we use an alternative
      approach by setting the state to `readOnly`. To also indicate
      visually  that nothing can be typed into the textedit, we add
      `Kirigami.Theme.inherit: true` which results in changing the
      background from white to grey.
      Test Plan:
      Font previews for each category in `kcmshell5 kcm_fonts` should be
      readable again.
      Before: {F5894425}
      After: {F5896658}
      How it looked like in Plasma 5.12: {F5894423}
      Reviewers: mart
      Reviewed By: mart
      Subscribers: mart, broulik, Zren, plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D13390
  14. 23 May, 2018 2 commits
    • David Edmundson's avatar
      Fix Font KCM force font DPI checkbox · b2694cfc
      David Edmundson authored
      Fixes numerous issues:
      1) the default behaviour had changed. It should disable force font DPI,
      not set it to 96
      2) disabling didn't work, we'd set the value to 0, which would update
      the spinbox, which has a minimum which sets the value to 96 (we were
      warned of this with a binding loop error)
      3) toggling the checkbox didn't enable the apply button
      New code fixes that and is more declarative too.
      BUG: 394180
      Test Plan: Toggled, reset to defaults, restarted
      Reviewers: #plasma, progwolff, broulik
      Reviewed By: #plasma, progwolff, broulik
      Subscribers: broulik, plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D13051
    • David Edmundson's avatar
      Allow typing in font DPI spinbox · 2ba367d5
      David Edmundson authored
      Otherwise keyboard use is hard, this fixes a regression that we could no
      longer select DPIs that weren't intervals of 24
      Test Plan: Ran, typed
      Reviewers: #plasma, broulik
      Reviewed By: #plasma, broulik
      Subscribers: plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D13050
  15. 22 Apr, 2018 1 commit
    • Julian Wolff's avatar
      add preview images to fonts kcm · 1793b51e
      Julian Wolff authored and David Edmundson's avatar David Edmundson committed
      The fonts kcm offers different font rendering settings. Currently, one needs to apply the settings and
      reopen the application to see the changes.
      This patch adds a way to render fonts at different settings (mostly based on existing code in kfontinst) and
      adds preview images to the sub-pixel and hinting comboboxes.
      This is part of a planned redesign of the fonts kcm. See the discussion in https://phabricator.kde.org/T7927
      Test Plan:
      Open the fonts kcm, click on the sub-pixel combobox. The preview images should look different.
      Reviewers: #plasma, harmathy, mart, davidedmundson, ngraham
      Reviewed By: #plasma, harmathy, mart, ngraham
      Subscribers: ngraham, davidedmundson, abetts, broulik, plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D11064
  16. 06 Mar, 2018 1 commit
  17. 23 Jan, 2018 1 commit
    • Marco Martin's avatar
      QML port of fonts kcm · 24b960f9
      Marco Martin authored
      port the fonts kcm to QML, reviving an old branch.
      UI based upon M112/411
      make use of the new Kirigami FormLayout
      depends from D8641
      Fixes T7244
      Test Plan: tried all the options
      Reviewers: #plasma, #vdg
      Subscribers: hein, ngraham, plasma-devel
      Tags: #plasma
      Maniphest Tasks: T7244
      Differential Revision: https://phabricator.kde.org/D8916