1. 13 Nov, 2019 1 commit
  2. 12 Nov, 2019 3 commits
  3. 08 Nov, 2019 2 commits
  4. 06 Nov, 2019 1 commit
    • Weng Xuetian's avatar
      [kimpanel] Add place holder button if everything is hide. · 7411258c
      Weng Xuetian authored
      Currently, if there is only one button from input method, it is
      sometimes impossible to hide any button, because the menu popup may
      cause lost of focus and button changes as soon as you right click the
      menu. The original logic is to prevent hide all the buttons, but since
      we now have placeholder, we can just simply hide any button.
      7411258c
  5. 05 Nov, 2019 4 commits
    • Nate Graham's avatar
      [Folder View] Use an inactive highlight effect when something else has focus · 596f979d
      Nate Graham authored
      Summary:
      The theme SVG doesn't have a concept of "inactive selection highlight", so we need to
      manufacture our own by reducing the opacity of the selection highlight.
      
      Thanks to @broulik for suggesting the necessary code changes in the bug report.
      
      FEATURE: 375501
      FIXED-IN: 5.18.0
      
      Test Plan: {F7743147}
      
      Reviewers: #plasma, #vdg, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: broulik, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D25160
      596f979d
    • Konrad Materka's avatar
      [Touchpad applet] Close query dialog on focus loss · 76d9233b
      Konrad Materka authored
      Summary:
      Popup asking whether touchpad should be disabled stays open and can be covered by others, for example volume slider.
      It is inconsistent since other elements of tray close themselves after switching away.
      
      Depends on: D24825
      
      BUG: 401016
      
      Test Plan:
      1. Disconnect all mouses
      2. Click the touchpad icon
      3. Try to dismiss it like every other tray plasmoid, for example by clicking on some other window.
      4. Popup should consider itself dismissed
      
      Reviewers: #plasma_workspaces, #plasma, davidedmundson
      
      Reviewed By: #plasma_workspaces, #plasma, davidedmundson
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D25158
      76d9233b
    • David Edmundson's avatar
      [emojier] Load locale file correctly · f2d8a2f5
      David Edmundson authored
      Summary:
      ibus installs with the file en_GB.dict same with an underscore as a
      separator for all regional variants.
      
      The bcp47 name uses a hyphen.
      
      Test Plan: I see emoticons
      
      Reviewers: #plasma
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D25156
      f2d8a2f5
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 6569912f
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      6569912f
  6. 04 Nov, 2019 3 commits
    • David Edmundson's avatar
      Add KDEClangFormat cmake support · d943a160
      David Edmundson authored
      Summary:
      This allows devs to run: "make clang-format" and format all files easily
      using the preset KDE clang format style
      
      This patch adds support so devs can easily test the intended formatting
      now, it doesn't change the code yet.
      
      Doing an initial run to commit everything will happen later.
      
      Test Plan:
      Ran script
      git diff was full of amazingly cleaned code
      
      See D25134
      d943a160
    • Bhushan Shah's avatar
      kcm/fonts: Do not load image preview before loading settings · 0b8ef770
      Bhushan Shah authored
      Summary:
      The way image preview works is it tries to actually "set" and then
      "reset" the original value to render the text.
      
      However if we don't have default or user set settings loaded, it will
      reset it back to "NotSet" in end instead of user set value and this is
      not what we want.
      
      Test Plan:
      this alone is not enough to make kcm save subpixel properly
      but this is part of patch series
      
      Reviewers: davidedmundson
      
      Reviewed By: davidedmundson
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D25090
      0b8ef770
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 92b4eacc
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      92b4eacc
  7. 03 Nov, 2019 2 commits
  8. 02 Nov, 2019 2 commits
  9. 31 Oct, 2019 13 commits
    • Björn Feber's avatar
      [Task Manager] Toggle mute when the audio indicator is clicked · da268696
      Björn Feber authored
      Summary:
      The task manager shows an indicator on tasks playing audio (when
      enabled in the settings). This patch adds the ability to mute/unmute
      an application playing audio by clicking on the audio indicator in
      the task manager.
      
      Test Plan:
      * Check "Mark applications that play audio" in the Task Manager Settings
      * Open an application that plays audio
      * Click on the audio indicator and it should toggle the mute state
      {F7324364}
      
      Reviewers: #plasma, #vdg, ngraham, filipf, hein, faridb
      
      Reviewed By: #plasma, #vdg, ngraham, hein
      
      Subscribers: GB_2, mart, hein, filipf, mvourlakos, ngraham, broulik, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D19822
      da268696
    • Kevin Ottens's avatar
      Fix reset to defaults in the fonts KCM · 7b0149c7
      Kevin Ottens authored
      Summary:
      Turns out one of the properties was utterly broken emitting the wrong
      signal, and the defaults() method was missing a piece of state to reset.
      
      Since it was making my eyes bleed I also removed the "const int &"
      parameters in the process. :-)
      
      Reviewers: #plasma, bport, davidedmundson, mart
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D25094
      7b0149c7
    • Nate Graham's avatar
      [containments/desktop] Delete the "Tweaks" page and its options · 69d649e5
      Nate Graham authored
      Summary:
      With the new global edit mode, both of the options on the Tweaks page become unnecessary:
      - The option to hide the toolbox becomes dangerous because it breaks global edit mode
      - The option to toggle press-and-hold is unnecessary with the far superior global edit mode
      
      Test Plan:
      - Right-click desktop > Configure Desktop > No "Tweaks" page at the bottom of the list: {F7687032}
      - Widget moving, resizing, and editing behaviors in side and out of edit mode are unchanged
      - You can no longer turn off the toolbox and break edit mode
      - You can no longer toggle the press-and-hold checkbox to show widget handles by hovering over widgets for a few seconds
      
      Reviewers: mart, GB_2, #plasma, hein
      
      Reviewed By: mart, #plasma
      
      Subscribers: fabianr, broulik, plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T10402
      
      Differential Revision: https://phabricator.kde.org/D25055
      69d649e5
    • Mikhail Zolotukhin's avatar
      Notify about change after cursor config is saved · cf7254a7
      Mikhail Zolotukhin authored and Nate Graham's avatar Nate Graham committed
      Summary:
      Before that patch the cursor change signal was only transmitted after
      a configuration was applied on a fly. Because the cursor change is
      not applied on a fly on Wayland session yet, the signal is not emitted and
      therefore users of that signal are not notified about cursor change.
      
      Now the signal is emitted after the configuration save, so its users are
      notified.
      
      Reviewers: #plasma, broulik
      
      Reviewed By: #plasma, broulik
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D24701
      cf7254a7
    • Aleix Pol Gonzalez's avatar
      kimpanel: don't crash when ibus is already loaded · 299f298d
      Aleix Pol Gonzalez authored
      Summary:
      No need to replace the current engine if we already have an acceptable one set.
      
      Otherwise it confuses Qt and it asserts in Qt.
      
      ```
       7  0x00007f517fcdf8e6 in qt_assert (assertion=assertion@entry=0x7f5179fee560 "engine_name == desc.engine_name", file=file@entry=0x7f5179fee318 "/home/apol/devel/frameworks/qt5/qtbase/src/plugins/platforminputcontexts/ibus/qibusplatforminputcontext.cpp",
          line=line@entry=583) at ../../include/QtCore/../../../../../devel/frameworks/qt5/qtbase/src/corelib/global/qlogging.h:90
       8  0x00007f5179fdb6f4 in QIBusPlatformInputContext::globalEngineChanged (this=0x55831b2c7ff0, engine_name=...) at ../../../../include/QtCore/../../../../../devel/frameworks/qt5/qtbase/src/corelib/tools/qarraydata.h:236
       9  0x00007f5179fe7f6d in QIBusPlatformInputContext::qt_static_metacall (_o=<optimized out>, _c=<optimized out>, _id=<optimized out>, _a=<optimized out>) at .moc/moc_qibusplatforminputcontext.cpp:147
      ```
      
      Test Plan:
      Now I can start the plasmoid without it crashing.
      I'm guessing users so far were running against a release build of Qt without asserts.
      Starting ibus with the session now works as well, in contrast to having to start it explicitly
      
      Reviewers: hein
      
      Reviewed By: hein
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D25045
      299f298d
    • David Edmundson's avatar
      [kcms/krdb] Fix krdb executable · 3a6dc8c0
      David Edmundson authored
      Summary:
      krdb is mostly a library used by some KCMs.
      
      It also exists as an executable script that works by invoking kcminit
      style which in turn runs the krdb code.
      
      This broke after a port that involved a rename.
      
      Test Plan:
      krdb on a distro that doesn't have old files
      It ran instead of giving a warning
      
      Reviewers: #plasma, apol
      
      Reviewed By: apol
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D25081
      3a6dc8c0
    • Benjamin Port's avatar
      fix kcm fonts "typo" on connect · 08a8914d
      Benjamin Port authored
      Summary: connect was not done correctly
      
      Reviewers: #plasma, mart, ervin, broulik
      
      Reviewed By: #plasma, ervin, broulik
      
      Subscribers: broulik, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D24848
      08a8914d
    • Cyril Rossi's avatar
      KCM KSplash port to ManagedConfigModule · 33222600
      Cyril Rossi authored
      Reviewers: #plasma, ervin, mart, bport
      
      Subscribers: davidedmundson, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D24925
      33222600
    • Cyril Rossi's avatar
      KCM Style port to KConfigXT · fbed4b3e
      Cyril Rossi authored
      Reviewers: ervin, mart, bport, #plasma
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D24917
      fbed4b3e
    • Vlad Zahorodnii's avatar
      Merge branch 'Plasma/5.17' · 45439589
      Vlad Zahorodnii authored
      45439589
    • Vlad Zahorodnii's avatar
      [Night Color KCM] Reset seconds and milliseconds in provided timings · 59e30039
      Vlad Zahorodnii authored
      Summary:
      When a user tries to set operation mode to "Times", the Apply button
      remains enabled after it's been clicked. The reason for that is timings
      provided by the kcm include seconds and milliseconds, while timings
      sent by KWin don't.
      
      Because seconds and milliseconds are different, CompositorAdapter::
      checkStaged() will return false even though hours and minutes haven't
      been modified by the user.
      
      In order to address this problem, my patch adjusts the TimeField
      component so it provides Date objects with seconds and milliseconds set
      to 0. There is another way to fix this issue though. We could check in
      CompositorAdaptor::checkStaged() method whether only hours and
      minutes have been modified.
      
      Test Plan:
      - Set operation mode to "Times"
      - Click the Apply button
      - Check that the Apply button is disabled
      
      Reviewers: #plasma, broulik
      
      Reviewed By: #plasma, broulik
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D25047
      59e30039
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · f0502407
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      f0502407
    • Script Kiddy's avatar
      GIT_SILENT made messages (after extraction) · baad1dff
      Script Kiddy authored
      baad1dff
  10. 30 Oct, 2019 4 commits
    • Björn Feber's avatar
      Rename "Close Edit Mode" tooltip to "Finish Customizing Layout" · a74c3657
      Björn Feber authored
      Summary: We don't call it the "edit mode" anywhere else in the UI. It now also matches the menu entry.
      
      Test Plan: Hover over the desktop toolbox close button.
      
      Reviewers: #plasma, #vdg, ngraham, mart
      
      Reviewed By: #plasma, #vdg, ngraham, mart
      
      Subscribers: mart, ngraham, #vdg, plasma-devel, #plasma
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D24855
      a74c3657
    • Kevin Ottens's avatar
      Force reevaluating state on pending deletion changes · 35c84cb5
      Kevin Ottens authored
      Summary:
      This was missing and thus the apply button wouldn't get enabled in case
      of a pending deletion. This is due to this mechanism being outside of
      the KConfigXT realm.
      
      Reviewers: #plasma, bport, mart, davidedmundson
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D25076
      35c84cb5
    • Kevin Ottens's avatar
      Adjust QtQuickSettings KCM to use KConfigXT in full · 61cd3d4b
      Kevin Ottens authored
      Summary:
      This removes quite a lot of uneeded code and fixes the automatic default
      handling from KConfigXT point of view (this was the wrong integration
      scheme with combo boxes).
      
      It also gives me a nice testing ground for a widget based KCM usable
      with kcmshell. :-)
      
      Reviewers: #plasma, mart, davidedmundson
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D25068
      61cd3d4b
    • Dan Leinir Turthra Jensen's avatar
      Require and use the new NewStuffQuick Button component · c21a8bd8
      Dan Leinir Turthra Jensen authored
      Summary:
      This removes the need for the custom hack for spawning a dialog,
      and is intended to function as a sample for how to implement this
      in other KCMs.
      
      Also use the big, pretty Preview mode (because super-visual content)
      
      This could be done wholesale for the entire bunch of KCMs, but i post
      this on its own in an attempt to gain feedback on a self contained
      example of how to do this porting step.
      
      Without this patch:
      {F7668236}
      
      With this patch:
      {F7668234}
      
      Depends on D25041
      
      Reviewers: #plasma, #knewstuff, #vdg, broulik, ngraham
      
      Reviewed By: #vdg, ngraham
      
      Subscribers: ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D24942
      c21a8bd8
  11. 29 Oct, 2019 5 commits