1. 03 Dec, 2019 1 commit
  2. 02 Dec, 2019 1 commit
    • Nate Graham's avatar
      [Workspace KCM] Expose setting to choose what left-clicking in the scrollbar track does · 759cec46
      Nate Graham authored
      Summary:
      This patch exposes a UI for choosing what happens when you left-click in the scrollbar
      track  in a Qt or KDE app. The default behavior is unchanged (left-click to page up/page
      down) but now you can choose to warp the scroll handle straight to the clicked position.
      
      Having this setting in the Workspace KCM opens the door to later making it also change
      the behavior for GTK apps as well, allowing us to remove one more setting from the GTK
      KCM and bringing us one step closer to finishing {T10611}.
      
      BUG: 379498
      FIXED-IN: 5.18.0
      
      Depends on D25360
      
      Test Plan:
      {F7769005}
      
      - Apply D25360
      - Click on "Scrolls to the clicked location" in the KCM
      - Click in the scrollbar track in a Qt/KDE app
      - See that the scroll handle position jumps right there
      - Click on  "Scrolls one page up or down" in the KCM
      - Click in the scrollbar track in a Qt/KDE app
      - See that the scroll handle moves up or down by one page height
      
      Reviewers: #plasma, #vdg, ndavis
      
      Reviewed By: #vdg, ndavis
      
      Subscribers: GB_2, davidedmundson, ndavis, gikari, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D25361
      759cec46
  3. 29 Nov, 2019 18 commits
  4. 28 Nov, 2019 1 commit
  5. 26 Nov, 2019 1 commit
  6. 25 Nov, 2019 8 commits
  7. 24 Nov, 2019 2 commits
  8. 23 Nov, 2019 3 commits
  9. 21 Nov, 2019 4 commits
  10. 20 Nov, 2019 1 commit
    • Bhushan Shah's avatar
      kcm/fonts: set initial settings correctly · 243d0b6d
      Bhushan Shah authored
      Summary:
      During initial load we check if certain settings are set or not, and if
      they are not set, we set it to rgb/slight (recommended settings by
      Plasma team).
      
      however state management of this is broken, previous flow was,
      
      - try to get configuration
      - if configuration is not available, set state to desired settings
      - set original state to current state value(!)
      - write configuration to the file once complete state is written (all
        other settings)
      
      This is fine, when setting is changing from something other then none or
      not-set. But if it is not-set, both original state and current state
      ended up being desired settings, which write function would happily
      ignore since it thinks config never changed.
      
      So, if we encounter not-set configuration, preserve that as a original
      setting to get configs written correctly.
      
      This patch on it's own have no visible effect, kcm is still broken due
      to lack of kcminit which writes correct configuration at startup, but
      this is one of obvious bugfix for follow-up patch series.
      
      Test Plan: with upcoming patch to add kcminit, it correctly applies rgb/slight
      
      Reviewers: #plasma, fvogt, davidedmundson
      
      Reviewed By: fvogt
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D25140
      243d0b6d