1. 14 Jan, 2019 2 commits
    • Björn Feber's avatar
      Improve Desktop/Plasma Theme KCM · 2015bad9
      Björn Feber authored
      Summary:
      Similar to D18206.
      The Desktop/Plasma Theme KCM has some inconsistencies and doesn't always apply the KDE HIG, so this fixes it, makes some other improvements and renames the KCM to "Plasma Theme".
      
      Test Plan: Open the Desktop/Plasma Theme KCM
      
      Reviewers: #plasma, #vdg, ngraham
      
      Reviewed By: #vdg, ngraham
      
      Subscribers: ngraham, davidedmundson, #vdg, plasma-devel, #plasma
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D18247
      2015bad9
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · e7ec5388
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      e7ec5388
  2. 13 Jan, 2019 1 commit
    • Björn Feber's avatar
      Improve the Look and Feel KCM · beca304a
      Björn Feber authored
      Summary:
      The LnF KCM has some inconsistencies and doesn't always apply the KDE HIG, so this fixes it and makes some other improvements.
      {F6546516}
      
      Test Plan: Open the LnF KCM
      
      Reviewers: #plasma, #vdg, ngraham
      
      Reviewed By: #vdg, ngraham
      
      Subscribers: ngraham, rooty, rizzitello, abetts, filipf, #vdg, plasma-devel, #plasma
      
      Tags: #plasma
      
      Maniphest Tasks: T10273
      
      Differential Revision: https://phabricator.kde.org/D18206
      beca304a
  3. 11 Jan, 2019 1 commit
  4. 10 Jan, 2019 4 commits
  5. 06 Jan, 2019 7 commits
  6. 04 Jan, 2019 2 commits
  7. 03 Jan, 2019 2 commits
    • Xuetian Weng's avatar
      kimpanel: check engine_desc before use · 3862d853
      Xuetian Weng authored
      3862d853
    • David Edmundson's avatar
      Fix model updates in RunnerMatchesModel · 9371a7c9
      David Edmundson authored
      Summary:
      RunnerMatchesModel is backed by a list. When this list changes
      RunnerManagerModel add/removes the new number of rows then called
      dataChanged on everything that remained.
      
      It's a common pattern, but not a great one. Especially with QtQuick
      where moving a delegate is faster than updating all the properties of an
      existing one - unfortunately I can't find a nice solution to do this
      properly in linear time.
      
      The problem with the current code is we update the entire list in the
      insert/remove rows. This is a violation of the model rules as we're
      updating rows outside the rows listed inside begin/remove rows.
      
      It works, but Qt's model test fails.
      
      We also have a lot of duplicates of a crash in QtQuick after runner
      model changes, bug 369430. I think it could be related, but can't
      prove anything.
      
      This patch updates the rows that exist in both the before and after
      models before adding/removing the remaining rows.
      
      BUG: 402439
      
      Test Plan:
      Added Qt model tester in https://phabricator.kde.org/P283
      It now passes.
      
      Reviewers: #plasma, hein
      
      Reviewed By: #plasma, hein
      
      Subscribers: hein, apol, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D17725
      9371a7c9
  8. 02 Jan, 2019 3 commits
  9. 01 Jan, 2019 2 commits
  10. 31 Dec, 2018 1 commit
  11. 30 Dec, 2018 1 commit
  12. 28 Dec, 2018 1 commit
  13. 24 Dec, 2018 2 commits
  14. 21 Dec, 2018 2 commits
  15. 20 Dec, 2018 2 commits
  16. 19 Dec, 2018 1 commit
    • David Edmundson's avatar
      remove binding loop in KickoffItem · be189b0c
      David Edmundson authored
      Summary:
      For non-wrapped text, implicitHeight will be the height of the
      paintedText. The key difference is it won't re-evaluate except on text
      changing which removes the binding loop.
      
      BUG: 402252
      
      Test Plan:
      Opened kickoff
      Looked identical
      No more warnings
      
      Reviewers: #plasma, broulik
      
      Reviewed By: #plasma, broulik
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D17642
      be189b0c
  17. 18 Dec, 2018 2 commits
  18. 16 Dec, 2018 1 commit
  19. 15 Dec, 2018 3 commits