1. 15 Jan, 2020 4 commits
    • Mikhail Zolotukhin's avatar
      [Application Style] Add GTK Application Style Page · 268c5ced
      Mikhail Zolotukhin authored
      The GTK KCM is now moved to Application Style KCM as a sub page. The
      functionality is identical to the one, found in GTK KCM, as well for the
      bugs :)
      The page is only accessible, if the `gtkconfig` kded module is loaded,
      because only with the module the configuration can be changed.
      Depends on D26261
      Test Plan:
      # Apply D26261
      # **Restart kded5**
      # Open System Settings, go to Application Style KCM
      # The button for GTK Configuration should be present
      # Go to Startup and Shutdown > Background Services, disable `Plasma GTKd` {F7877157}
      # Return to the App Style KCM, the button should disappear
      # Return to the Kded KCM and enable `Plasma GTKd` back
      # Return to the App Style KCM - button is present now
      # Go to subpage
      # Happy (I hope) testing!
      Reviewers: #vdg, broulik, #plasma, ngraham, mart
      Reviewed By: #vdg, #plasma, ngraham, mart
      Subscribers: davidedmundson, ngraham, plasma-devel
      Tags: #plasma
      Maniphest Tasks: T10611
      Differential Revision: https://phabricator.kde.org/D26583
    • Cyril Rossi's avatar
      KCM Notifications : fix applications behavior not properly updated in KCM · e236b520
      Cyril Rossi authored
      Reviewers: #plasma, ervin, bport, meven, broulik
      Subscribers: plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D26683
    • Kai Uwe Broulik's avatar
      [Notifications KCM] Force re-evaluation of position radio buttons · db95a53c
      Kai Uwe Broulik authored
      The Settings object is kind of a write-only state and doesn't signal property changes unless "live" (where it would listen to other
      settings changing which we don't want inside the KCM) or only upon save().
      This is arguably a questionable design decision on my side :-) but usually it's not a problem as the KCM controls will have
      whatever state the user will put them in but it falls apart in case we switch to another page and back without saving.
      BUG: 414098
      FIXED-IN: 5.18.0
      Differential Revision: https://phabricator.kde.org/D26162
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · ae4467ef
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
  2. 14 Jan, 2020 3 commits
  3. 13 Jan, 2020 3 commits
  4. 12 Jan, 2020 2 commits
  5. 10 Jan, 2020 5 commits
  6. 09 Jan, 2020 1 commit
  7. 08 Jan, 2020 5 commits
    • Kevin Ottens's avatar
      DesktopPaths KCM: Remove the moving directory logic · db1ebdc9
      Kevin Ottens authored
      This simplifies greatly this otherwise mundane KCM. It introduced a lot
      of complexity while gettings things wrong anyway: it would miss if a
      directory is included in another one except in the "autostart inside
      desktop" case, it would also leave you stranded in case of an
      uncompleted move.
      So now the KCM has a clear purpose: edit the settings. Moving data
      around is still up to the user using a proper filemanager.
      Long term it would probably be better for the filemanager to edit the
      settings automatically when the user move on of those folders around,
      then the KCM could be decommissioned.
      Reviewers: #plasma, crossi, bport, meven, mart, davidedmundson
      Subscribers: plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D26391
    • Kevin Ottens's avatar
      DesktopPaths KCM: Move the view logic in a ui file · f9fb1115
      Kevin Ottens authored
      Summary: Now the revert/apply/defaults buttons work as expected.
      Reviewers: #plasma, crossi, bport, meven, mart, davidedmundson
      Subscribers: plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D26390
    • Kevin Ottens's avatar
      DesktopPaths KCM: Move the settings logic to a KCoreConfigSkeleton class · ea8009b3
      Kevin Ottens authored
      Our KCoreConfigSkeleton subclass is interestingly hand written since
      it's too remote from what we usually do (the resulting file needs to be
      sourceable and we don't want the usual behavior of removing keys when
      they're set to defaults).
      The only one which was "more standard" was the autostart path, but
      really with the URL conversion on top and for just a single entry, I
      shoved it in the hand written class as well.
      Doesn't reduce the code much, but at least it separates that logic from
      the KCM and it opens the door to properly working defaults button.
      Reviewers: #plasma, crossi, bport, meven, mart, davidedmundson
      Subscribers: plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D26389
    • Kevin Ottens's avatar
      Get rid of KGlobalSettings · 29c01adc
      Kevin Ottens authored
      After grepping in all our repositories, it looks like the SETTINGS_PATHS
      category is completely unused (at least I couldn't find anyone doing
      anything paths related on the slot end).
      Reviewers: #plasma, mart, davidedmundson
      Subscribers: plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D26388
    • Méven Car's avatar
      KCM/Component remove traces of Kdelibs4 migration · bde038c0
      Méven Car authored
      Test Plan: Compiles
      Reviewers: ervin, #plasma
      Reviewed By: ervin
      Subscribers: plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D26515
  8. 07 Jan, 2020 2 commits
  9. 06 Jan, 2020 6 commits
  10. 05 Jan, 2020 3 commits
  11. 03 Jan, 2020 1 commit
  12. 02 Jan, 2020 3 commits
  13. 31 Dec, 2019 2 commits