1. 27 Nov, 2018 1 commit
    • Nate Graham's avatar
      [Componentchooser KCM] Make default browser app choice work even when combobox is not used · 26fb5ec2
      Nate Graham authored
      Summary:
      BUG: 350663
      FIXED-IN: 5.12.8
      
      When choosing a default browser app using the app list combobox, the choice was only being saved after the combobox was used, because its signal was connected to an inline function that saved the choice, while the radio button that enabled the combobox was not. As a result, if you clicked on that radio button and didn't need to use the combobox because it was already showing your preferred browser, that action was not actually getting saved.
      
      This patch fixes the situation my moving the inline function into a real explicit slot function and connecting the radio button to it as well.
      
      Test Plan:
      - Go to the component chooser KCM's default browser module
      - Reset to defaults, then leave the KCM and open it again
      - Click the {nav in the following application} radio button
      - Do NOT touch the combobox
      - Click {nav Apply}
      - Leave the KCM and come back
      
      With this patch, the radio button's state is preserved and the correct browser is selected in the combobox.
      
      Reviewers: #plasma, cfeck, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: davidedmundson, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D17181
      26fb5ec2
  2. 21 Nov, 2018 1 commit
  3. 19 Nov, 2018 2 commits
    • Eike Hein's avatar
      Revert unintended line · 45434737
      Eike Hein authored
      45434737
    • Eike Hein's avatar
      Compress calls to `updateSize` · ab26ebb1
      Eike Hein authored
      Summary:
      Repeater+Flow has no reliable way to transactionize/batch insertion,
      e.g. `Flow.positionCompleted` is useless in a function that can change
      the Flow's size, and transition events like populated and similar
      aren't available. Refactoring this to be a ListView isn't appealing
      because it would mean the code loses the property of being reused for
      both the bar and the popup, and therefore is well-tested already.
      
      This brings down the number of `updateSize` calls when opening the
      dialog for a group of five from five to one.
      
      BUG:400364
      
      Reviewers: #plasma, davidedmundson
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D17006
      ab26ebb1
  4. 18 Nov, 2018 1 commit
  5. 14 Nov, 2018 1 commit
  6. 02 Nov, 2018 1 commit
  7. 01 Nov, 2018 1 commit
  8. 29 Oct, 2018 1 commit
  9. 25 Oct, 2018 1 commit
  10. 23 Oct, 2018 2 commits
    • Eike Hein's avatar
      Remove. · 0e1aa9e0
      Eike Hein authored
      0e1aa9e0
    • Eike Hein's avatar
      Focus handling fixes · 03b17ac5
      Eike Hein authored
      Summary:
      * Fix keyboard nav on the desktop again.
      BUG:399566
      * Fix initial focus properly.
      * Make sure when using arrows after starting Plasma or after clicking
        into empty space, the first selected item is always 0, not 1 or
        some random item based on previous activity.
      * Make sure the view is always scrolled up when (re)opening the popup.
      
      Reviewers: broulik
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D16106
      03b17ac5
  11. 22 Oct, 2018 2 commits
  12. 21 Oct, 2018 1 commit
  13. 07 Oct, 2018 1 commit
  14. 04 Oct, 2018 3 commits
  15. 25 Sep, 2018 1 commit
  16. 24 Sep, 2018 1 commit
  17. 16 Sep, 2018 1 commit
  18. 08 Sep, 2018 1 commit
  19. 06 Sep, 2018 1 commit
    • Eike Hein's avatar
      Improve arrow key navigation of Kicker search results · 1692ae24
      Eike Hein authored
      Summary:
      Kicker already makes sure the first search result is highlighted
      and actionable while searching. This patch makes arrow-down after
      typing move to the second search result instead of merely moving
      focus from the search field to the list, so the user doesn't have
      to press arrow-down twice anymore.
      
      It also allows using arrow-left/right to jump to the other result
      columns, when the cursor is at the start or end of the text field,
      respectively.
      
      BUG:397779
      
      Reviewers: ngraham
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D15286
      1692ae24
  20. 04 Sep, 2018 1 commit
  21. 27 Aug, 2018 1 commit
  22. 26 Aug, 2018 1 commit
  23. 20 Aug, 2018 1 commit
  24. 15 Aug, 2018 1 commit
  25. 11 Aug, 2018 1 commit
  26. 02 Aug, 2018 1 commit
    • Mathias Tillman's avatar
      fontinst quits after KJob is done · 690570a4
      Mathias Tillman authored
      Summary:
      As the summary says, when installing/removing multiple fonts to system the expected behaviour would be for fontinst to keep running after the first font has been installed or removed, instead it quits which causes a bunch of issues. fontinst uses KJob to authorize and internally KJob uses a QEventLoopLocker which causes the main event loop to quit when it's done.
      I'm not entirely sure why the event loop locker is enabled by default for KJob, but the patch I have attached works around this by completely disabling that functionality for fontinst. There's a timer that runs in the background which checks for any connected clients, so it will quit after a little while regardless.
      
      BUG: 379524
      BUG: 379324
      BUG: 349673
      BUG: 361960
      BUG: 392267
      
      Test Plan: Make sure fonts are still installed and removed properly.
      
      Reviewers: #plasma, dfaure, aacid, gateau
      
      Reviewed By: dfaure
      
      Subscribers: wbauer, ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D14493
      
      (cherry picked from commit 60c89575)
      690570a4
  27. 01 Aug, 2018 2 commits
    • Kai Uwe Broulik's avatar
      [Desktop Toolbox] Emit contextualActionsAboutToShow before opening · 3485b7d3
      Kai Uwe Broulik authored
      The toolbox shows containment-specific actions, just like the desktop contextmenu does.
      The containment may update or creates its actions on-demand leading to outdated actions showing up in the toolbox.
      
      BUG: 384862
      FIXED-IN: 5.12.7
      
      Differential Revision: https://phabricator.kde.org/D14535
      3485b7d3
    • Eike Hein's avatar
      Fix bad model hygiene in Positioner::move() · 1cb71a2c
      Eike Hein authored
      Summary:
      Don't change the proxy maps prior to insert/remove transactions so
      rowCount() at transaction start time matches the count passed into
      the method. The old code hits an ASSERT in Qt 5.11 otherwise.
      
      Care is taken not to emit dataChanged() in the middle of another
      transaction.
      
      Also cleaned up vestiges of caching lastRow(): This cache was
      evicted all over the places but never actually filled anymore, so
      maybe we don't need it.
      
      BUG:396666
      
      Reviewers: davidedmundson
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D14243
      1cb71a2c
  28. 30 Jul, 2018 1 commit
  29. 22 Jul, 2018 1 commit
  30. 21 Jul, 2018 1 commit
  31. 20 Jul, 2018 1 commit
    • Kai Uwe Broulik's avatar
      [Folder View] Improve file name text rendering · 5fca2b32
      Kai Uwe Broulik authored
      GridView pads out its delegate to ensure a uniform grid. This, however, causes items to be placed on fractional pixels,
      leading to blurry rendering and uneven hinting.
      Instead of adjusting padding calculation to return whole pixels, which will again cause a gap at the right side of the screen,
      since there's 20 icons in a row, slightly shift the delegate contents to move them back to whole pixels.
      Moreover, DropShadow renders the entire item with a drop shadow, so keeping the Label visible results in two labels ontop of
      each other leading to bolder text.
      
      Differential Revision: https://phabricator.kde.org/D14234
      5fca2b32
  32. 18 Jul, 2018 1 commit
    • Nate Graham's avatar
      Give file and folder names a bit more room in Folder View · 02dadc40
      Nate Graham authored
      Summary:
      Slightly decrease the side margins within Folder View delegates, to give titles a tiny bit more room. This very slightly improves things for people who have desktop files with multi-line titles.
      
      CCBUG: 379432
      
      Test Plan:
      Before, normal-sized icons:
      {F5755097}
      
      After, normal-sized icons:
      {F5755128}
      
      Before: small icons:
      {F5755102}
      
      After, small icons:
      {F5755127}
      
      Reviewers: hein, #plasma
      
      Reviewed By: hein, #plasma
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D11358
      02dadc40
  33. 17 Jul, 2018 1 commit
  34. 11 Jul, 2018 1 commit