GitLab

There is no need to check if the model of the current item is not empty, since the current item may be not only a category.

BUG: 444101

Eugene Popov authored Oct 21, 2021 and Nate Graham committed Oct 21, 2021

Check if the applet is pinned before closing it.

BUG: 443589

Fushan Wen authored Oct 21, 2021 and Nate Graham committed Oct 21, 2021

The binding of "model" property of DelegateModel in ToolTipDelegate.qml
will trigger useless component creation/destruction when "rootIndex" is
changed but is not undefined. Make the ternary operator depend on
"hasRootIndex" bool property to avoid that.

In Task.qml, only assign different values to "parentTask" and "rootIndex"
to avoid unnecessary component creation/destruction for the second time
hovering on the same task.

CCBUG: 433907
CCBUG: 444001


(cherry picked from commit 12373d31)

Conditionally setting mprisSourceName to either AppPid or pidParent
made no sense, because:
1. AppPid was not defined in this file so it didn't work
2. parentPid was set to the value of AppPid anyway, rendering the two
   branches of the conditional identical even if it did work

Just set it to pidParent directly. This fixes a console error.


(cherry picked from commit d22927e6)

There's no point in setting an implicit size that's the same as the
minimum size so let's reduce the minimum size to be smaller than the
minimum size so that the window can be made smaller by the user, or by
the system in case a small screen is being used. Also reduce the default
height a tiny bit.

BUG: 443712
FIXED-IN: 5.24
(cherry picked from commit 4e13d08c)

Arjen Hiemstra authored Oct 19, 2021 and Nate Graham committed Oct 19, 2021

This ensures that searching happens while the text is being entered from
a virtual keyboard.

BUG: 439914


(cherry picked from commit 2c28dd79)

Fabio Bas authored Oct 18, 2021 and Nate Graham committed Oct 19, 2021

MR552 introduced RemoveAction but broke functionality of the "delete" action
when both the "trash" and "delete" actions are shown in the menu by requiring
the "shift" key being pressed for the action to work.

BUG: 442765


(cherry picked from commit b893a37f)

Derek Christ authored Oct 18, 2021 and Nate Graham committed Oct 19, 2021

The create folder shortcut worked as long as the user did not right-
click into an empty space on the desktop to invoke the context menu.

The problem was that the create-folder-action was set to not visible
so that it is not shown in the context menu. But as soon as the context
menu is opened, the action is set to not visible in the plasmoid
contextual action list. The reason it works before opening the menu is
because the action for the plasmoid is created without setting it to
not visible.

This commit fixes the bug by using an already existing workaround class
that uses an event filter to respond to the
KStandardShortcut::createFolder key sequence.

BUG: 443512


(cherry picked from commit 12350fb1)

GIT_SILENT

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

It wasn't saving the cleared config entry to the config file, so any
changes to the view (i.e. to make all the emojis disappear) would be
un-done when you closed the window and then re-opened it.

BUG: 443974
FIXED-IN: 5.23.1


(cherry picked from commit 58f29efd)

Originally, I thought it wasn't possible to use Qt Quick Drag here, but
then I found out I could use Item::grabToImage()'s function callback
parameter to set Drag.imageSource.

BUG: 443708


(cherry picked from commit d754291b)

Fushan Wen authored Oct 07, 2021 and Nate Graham committed Oct 18, 2021

If a media player is pinned to Task Manager, after opening the media
player and switching to another virtual desktop, the media controller
will be still visible in the tooltip but cannot be interacted with.

Move hasPlayer property to ToolTipDelegate.qml, and add
mainItem.hasPlayer to interactive property of ToolTipArea to fix the bug.

BUG: 443425


(cherry picked from commit d3bb796a)

Fushan Wen authored Oct 16, 2021 and Nate Graham committed Oct 18, 2021

The slot function explicitly connected to showAllPlaces should be
disconnected manually on destruction.

BUG: 443820


(cherry picked from commit 760f305c)

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

The functionality was extracted from the services  runner to a separate plugin.

BUG: 443776


(cherry picked from commit 4eaa61cf)

Right-clicking on multiple things is a real use case which got broken
in !591
while fixing the bug of un-clicked-on items remaining selected after
clicking one of them.

This commit fixes that.

BUG: 443743
FIXED-IN: 5.23.1


(cherry picked from commit 2b828c60)

David Edmundson authored Oct 14, 2021 and Nate Graham committed Oct 14, 2021

The Dashboard representation contains 3 views stacked on top of each
other with one visible at a time with an opacity animation.

Enabled was used (presumably) to ensure that only the active
representation gets input events.

Unfortunately this has a side effect. When switching views the icons on
the inactive view all get enabledChanged events. This triggers a redraw
with a greyed out effect on all icons. This is a very slow path,
especially for something not even visible!

Setting visible also stops input events, without the side effect.


(cherry picked from commit 7881fdf5)

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

GIT_SILENT

GIT_SILENT

Deletion of intermediate inputWindow is touchy, it interferes with the
switching probably because of focusing stuff.

BUG: 443323


(cherry picked from commit dbcc2e5c)

(cherry picked from commit 2e8b630e)

Fushan Wen authored Oct 01, 2021 and Noah Davis committed Oct 07, 2021

The scrollbar should have its own space instead of overlapping
the thumbnail or the media controller.

BUG: 443173
CCBUG: 439522
(cherry picked from commit 578a5db6)

(cherry picked from commit c499c36f)

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

BUG: 440308
(cherry picked from commit fd49cc02)

(cherry picked from commit e6e80d52)

It's a bit cleaner this way since the 2 related things are together.

(cherry picked from commit 0826af52)

(cherry picked from commit 683df961)

BUG: 443076
(cherry picked from commit 9d48efbb)

(cherry picked from commit 960eb8ba)

(cherry picked from commit 1bfc0351)

Bharadwaj Raju authored Oct 05, 2021 and Nate Graham committed Oct 06, 2021

This is handled in onReleased so as to distinguish between a drag and
click.

BUG: 424152


(cherry picked from commit 915aa97a)

Méven Car authored Oct 05, 2021 and Nate Graham committed Oct 05, 2021

Was missing the translation domain


(cherry picked from commit 6ad9dfe7)

Arjen Hiemstra authored Sep 15, 2021 and Nate Graham committed Oct 05, 2021

This uses the same style as radio buttons and grid KCM delegates to
indicate when one of the thumbnails has focus.


(cherry picked from commit d83e15ce)

Fushan Wen authored Oct 04, 2021 and Nate Graham committed Oct 04, 2021

Removes the warning: TypeError: Cannot read property 'applet' of null

BUG: 443287


(cherry picked from commit f2b940e5)

Méven Car authored Oct 04, 2021 and Nate Graham committed Oct 04, 2021

For the right click section, show it only if one its two options is available.

For the middle-click section, show it if at least one of its option is visible.

CCBUG: 408338


(cherry picked from commit c2b797ff)

David Redondo authored Oct 04, 2021 and Nate Graham committed Oct 04, 2021

QMenu::popup() takes a global position but we still want, the
new file position in local coordinates.
Tested both that the menu opens correctly and new files are created
at the correct position which triggered the introduction of setMenuPos.
BUG:443278


(cherry picked from commit 96067c0f)