GitLab

Summary:
When closing several apps from the task manager with the mouse
middle button, it is convenient that the remaining tasks are not
resized so that you don't need to move your mouse to target the
next app you intend to close. The tasks will be resized when the
mouse is moved out of the task manager.
This mimics the behavior of tabs in Firefox or Chrome.

Test Plan:
With the task manager configured without grouping, open several
applications so that the tasks displayed in the task manager get
smaller to fit in the available space. Now close the last three
for example: you should be able to do so without having to move
your mouse.

Reviewers: #plasma, #vdg, hein

Reviewed By: #plasma, hein

Subscribers: hein, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D18438

Summary: BUG:404706

Reviewers: #plasma, mart

Reviewed By: #plasma, mart

Subscribers: apol, Fuchs, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D19257

Summary:
Depends on D13745.

This code is largely untested and subject to change.

Reviewers: mart, davidedmundson

Reviewed By: davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Maniphest Tasks: T4457

Differential Revision: https://phabricator.kde.org/D13746

Summary:
Users have reported a number of bugs against TM tooltips, e.g. initially
coming up with crazy sizes, or showing window duplicates. This all comes
down to a race conditions causing stale data and ugly code that's using
visible props to swap between two alternate UI implementations instead
of doing clean conditional loading.

With this cleanup patch the problems should be gone, as well as various
ReferenceErrors spewed onto the tty.

BUG:382571
BUG:385947
BUG:389469
BUG:388749

Reviewers: broulik, davidedmundson, romangg

Reviewed By: davidedmundson

Subscribers: rikmills, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D13602

This reverts commit 24803dc9.

Even though this commit is perfectly sensible it seems to introduce a
crash on startup for Qt 5.10.

Will revert for now, we can revisit later

CCBUG: 382571
CCBUG: 385947
CCBUG: 389469
CCBUG: 388749

Summary:
Users have reported a number of bugs against TM tooltips, e.g. initially
coming up with crazy sizes, or showing window duplicates. This all comes
down to a race conditions causing stale data and ugly code that's using
visible props to swap between two alternate UI implementations instead
of doing clean conditional loading.

With this cleanup patch the problems should be gone, as well as various
ReferenceErrors spewed onto the tty.

BUG:382571
BUG:385947
BUG:389469
BUG:388749

Reviewers: broulik, davidedmundson, romangg

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D13602

Summary:
As there are quite a bit QML files in the respective /ui subdir, having the
JS file in another separate subdir named /code as befire provides
good overview

Test Plan: Applets UI & Config still work as before

Reviewers: #plasma, mart, broulik, hein

Reviewed By: #plasma, mart

Subscribers: apol, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D11148

When the task appears in Task Manager and is already playing audio, show the indicator right away.
There's no distraction from that since the task as a whole appears.
Only when the audio stream appears during the lifetime of a task, it is delayed to avoid distractions by short sound effects.

BUG: 390502
FIXED-IN: 5.13.0

Differential Revision: https://phabricator.kde.org/D10539

This allows to change tracks by clicking the respective task manager entry with the mouse browser back and forward keys.
Makes it consistent with media controller applet but the target is a lot easier to hit.

Differential Revision: https://phabricator.kde.org/D9797

When your panel is too narrow the badge icon cannot be shown, so show it in the tooltip as well.

Differential Revision: https://phabricator.kde.org/D9825

Summary:
Also delays the dialog resize until after the move transition ends
if there's going to be one, for a less jarring experience.

BUG:382638

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D7035

Summary:
This brings us to a common baseline on the three active branches
and addresses regressions on the 5.8 branch.

5.9's code added a scrollbar and improved keyboard nav.

BUG:378042

Reviewers: #plasma, mart

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D5287

This makes it easier to see what item the menu or popup is for.
In fact, the item should have stayed highlighted when the context menu is open but this was broken.
Also, for consistency, use the hover effect also for the group dialog (it used to be the "active" task).

Differential Revision: https://phabricator.kde.org/D5260

Otherwise QML Text elides much too early for some reason.

This adds an option for what to do on middle click which will toggle grouping
of window of a specific application.

This can already be done in the context menu by (un)checking "Allow this program
to be grouped" in "Advanced" but this adds a nice shortcut for this.

In contrast to said context menu entry the option in the ComboBox is shown regardless
of the grouping mode as otherwise it might unintentionally change your setting to
a (seemingly) non-deterministic value if you disable grouping.

BUG: 323567
FIXED-IN: 5.10.0

Differential Revision: https://phabricator.kde.org/D5065

Summary:
Grepped code for repaintNeeded on prefixes and adjusted as appropriately to match
D4827

Test Plan: Booted, looks the same.

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D4830

Summary:
When activateTask is called from root Item, it will fail to resolve the
reference of toolTipArea. This change make toolTipArea a property of Task
and make activateTask() access it via this property.

Test Plan: Manually test via Meta+number on group item.

Reviewers: hein, #plasma, mart

Reviewed By: mart

Subscribers: mart, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D4996

Summary: This improves the rendering when the task manager is oriented vertically. Before this change the taskbar had to be made too wide so that the task buttons show both icon and text. With the present change, the preferred icon size can be chosen via task bar configuration dialog so that text is shown also in narrower vertical task bars.

Test Plan:
1. Place the task bar vertically
2. Adjust the task bar width e.g. so that the tray icons appear in rows of three
3. Open some windows a Dolphin window so that there is at least one task open in the task bar

Before: The task buttons show only icons that stretch through the most of the button width. There is no text in the task button

After:
1. Task Manager contect menu > Task Manager Settings... >
    Lower the icon size to Small Medium
    Hit OK
2. The task buttons are showing a bit smaller icons and there is some text shown there too.

Reviewers: davidedmundson, hein, broulik

Reviewed By: hein

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D4550

This is desired by a downstream who always wants a single line of
text.

This should go into the 5.9 branch to allow them to ship 5.9.

This is desired by a downstream distro which doesn't want hover
effects in Task Manager.

This also adds back a small tweak to support themes that don't
ship a "hover" prefix in tasks.svgz that seems to have gotten
lost along the way.

It should go into the 5.9 branch to allow them to ship 5.9.

Summary:
This fixes a regression from aeec4ae8 which unsets the taskManagerItem
prop when the group dialog is shown to intentionally break window
highlighting while the dialog is open.

This patch instead fixes highlighting from the group dialog properly
by including it in the highlight list.

Also adds some extra crash guards.

CCMAIL:bvbfan@abv.bg
BUG:376205
BUG:376234

Reviewers: #plasma, anthonyfieroni

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D4525

Since we cannot have dynamic jump list actions but this is an often requested feature and common
among other desktop environments, at least add the "Places" to entries belonging to a file manager.

To avoid the menu becoming too long, the number of places shown is limited to 5* when the
application is running and the menu would also have window controls. For when it's a launcher,
all places are shown as there the menu is less likely to become massive.

This is added to services that contain the "FileManager" category, such as Dolphin.

*) It actually truncates it to 5 entries only if there's more than 7 places.
There's nothing more frustrating than having a "reveal more" button that ends up adding just one
or two items once clicked.

Differential Revision: https://phabricator.kde.org/D3815

Summary:
This fixes a regression from aeec4ae8 which unsets the taskManagerItem
prop when the group dialog is shown to intentionally break window
highlighting while the dialog is open.

This patch instead fixes highlighting from the group dialog properly
by including it in the highlight list.

Also adds some extra crash guards.

CCMAIL:bvbfan@abv.bg
BUG:376205
BUG:376234

Reviewers: #plasma, anthonyfieroni

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D4525

Summary:
This fixes a regression from aeec4ae8 which unsets the taskManagerItem
prop when the group dialog is shown to intentionally break window
highlighting while the dialog is open.

This patch instead fixes highlighting from the group dialog properly
by including it in the highlight list.

Also adds some extra crash guards.

CCMAIL:bvbfan@abv.bg
BUG:376205
BUG:376234

Reviewers: #plasma, anthonyfieroni

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D4525

Summary:
A set of UI improvements to the group popup dialog:
* The dialog was height-limited but not scrollable. It now shows
  a vertical scrollbar if needed.
* The existing keyboard handling is extended to scroll any item
  navigated to by keyboard into view.
* At opening time (before the dialog causes a change in window
  focus) the currently-active task (if any) is collected, and
  then made the active item, scrolling it into view if needed.
  Keyboard nav will then start there. This improves initial
  focus handling.
* The normal wheel-handling is short-circuited in favor of
  scrolling when the dialog overflows.

BUG:375196

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D4229

In 4c94d234ca09c22ebf1a19e6d12b3f9ef056e3dc I accidentally verticalCenter'd
the app icon, not the audio indicator.

When there are two instances of the same application running, one playing audio
and the other one not, it will errneously show an indicator on both applications:
for the playing one it will find a PID but for the other one it won't and then
try appName matching which will then result in the same stream.

Differential Revision: https://phabricator.kde.org/D4038

Magic number chosen by fair dice ro... feedback.

BUG:373544

Differential Revision: https://phabricator.kde.org/D4037

This is similar to what most web browsers do nowadays, indicating when audio is being played
with an option to mute it.

When an application has an audio stream and it is actually playing something ("not corked"),
after a delay of 2 seconds (to avoid flashing briefly) an audio icon is displayed which disappears
again once audio stops playing. The context menu always offers the "Mute" option whenever
there's an audio stream provided by the application, so you can still unmute even after playback
has stopped. Also, the "muted" icon will be shown whilst the application is muted, regardless
of whether sound is actually being played.

An application is marked as "Muted" when all associated streams are muted, and toggling mute
will (un)mute all of them. Since PulseAudio doesn't know windows, when an application has multiple
windows, all of them will be flagged as playing audio; the same issue we already have with
Unity Launcher API.

Differential Revision: https://phabricator.kde.org/D3302

Reworks the design of the task manager tooltips and adds new features.

Summary:
* New tooltip design:
** Less screen space occupied by tooltips
** Tooltips have always the same size
** Better structured informations about a task: Appname, window title, desktop,
   activity if useful
** Close button better looking and more visible
* Group tooltips show per group task all individual informations
* Group tooltips provide context menu per task and its group
* Group tooltips in vertical bar are lined up as column
* If supported by media player, controls are available for each instance
  separately
* Fixed: In any case secondary media players instances are always also shown in
  group tooltip
* Fixed: Flickable area when exceeding available display space
* Fixed: Many warning and error messages

Technical overview:
* For groups instead of relying on the window list provided by X, we now use a
  proper submodel of the grouped tasks
* Window titles are processed by reg exp to only show the relevant part of them
* Media player instances are distinguished by their process ids

Reviewers: #plasma, #vdg, hein

Subscribers: plasma-devel

Tags: #plasma, #vdg

Differential Revision: https://phabricator.kde.org/D3738

So that the tooltip doesn't unnecessarily cover activated window.

Also under high load it can happen that after clicking on task and
then quickly moving mouse out of the taskmanager, the tooltip is shown
for a split second.

Differential Revision: https://phabricator.kde.org/D3916

[taskmanager] Limit GroupDialog size, stop highlightwindow effect when it shown, increase items readability

REVIEW: 128038
Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>

This adds a method activateTaskAtIndex that is called by plasmashell in response to a Meta+Number shortcut

CHANGELOG: Items in task manager can now be activated using Meta+number shortcuts

Differential Revision: https://phabricator.kde.org/D3582

Summary:
Publishes delegate geometry for new windows directly added to an
existing task group.

BUG:372699

Depends on D3482.

Reviewers: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D3483