1. 17 Mar, 2019 1 commit
    • Thomas Surrel's avatar
      [Task Manager] When closing apps, resize only when mouse is out. · 2861ae7c
      Thomas Surrel authored
      Summary:
      When closing several apps from the task manager with the mouse
      middle button, it is convenient that the remaining tasks are not
      resized so that you don't need to move your mouse to target the
      next app you intend to close. The tasks will be resized when the
      mouse is moved out of the task manager.
      This mimics the behavior of tabs in Firefox or Chrome.
      
      Test Plan:
      With the task manager configured without grouping, open several
      applications so that the tasks displayed in the task manager get
      smaller to fit in the available space. Now close the last three
      for example: you should be able to do so without having to move
      your mouse.
      
      Reviewers: #plasma, #vdg, hein
      
      Reviewed By: #plasma, hein
      
      Subscribers: hein, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D18438
      2861ae7c
  2. 11 Mar, 2019 1 commit
  3. 09 Mar, 2019 1 commit
  4. 18 Dec, 2018 1 commit
  5. 22 Jun, 2018 1 commit
    • Eike Hein's avatar
      Fix tooltip woes · 1e218b40
      Eike Hein authored
      Summary:
      Users have reported a number of bugs against TM tooltips, e.g. initially
      coming up with crazy sizes, or showing window duplicates. This all comes
      down to a race conditions causing stale data and ugly code that's using
      visible props to swap between two alternate UI implementations instead
      of doing clean conditional loading.
      
      With this cleanup patch the problems should be gone, as well as various
      ReferenceErrors spewed onto the tty.
      
      BUG:382571
      BUG:385947
      BUG:389469
      BUG:388749
      
      Reviewers: broulik, davidedmundson, romangg
      
      Reviewed By: davidedmundson
      
      Subscribers: rikmills, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D13602
      1e218b40
  6. 20 Jun, 2018 1 commit
    • David Edmundson's avatar
      Revert "Fix tooltip woes" · 1ab6ae9a
      David Edmundson authored
      This reverts commit 24803dc9.
      
      Even though this commit is perfectly sensible it seems to introduce a
      crash on startup for Qt 5.10.
      
      Will revert for now, we can revisit later
      
      CCBUG: 382571
      CCBUG: 385947
      CCBUG: 389469
      CCBUG: 388749
      1ab6ae9a
  7. 19 Jun, 2018 1 commit
    • Eike Hein's avatar
      Fix tooltip woes · 24803dc9
      Eike Hein authored
      Summary:
      Users have reported a number of bugs against TM tooltips, e.g. initially
      coming up with crazy sizes, or showing window duplicates. This all comes
      down to a race conditions causing stale data and ugly code that's using
      visible props to swap between two alternate UI implementations instead
      of doing clean conditional loading.
      
      With this cleanup patch the problems should be gone, as well as various
      ReferenceErrors spewed onto the tty.
      
      BUG:382571
      BUG:385947
      BUG:389469
      BUG:388749
      
      Reviewers: broulik, davidedmundson, romangg
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D13602
      24803dc9
  8. 08 Mar, 2018 1 commit
  9. 15 Feb, 2018 1 commit
  10. 15 Jan, 2018 2 commits
  11. 01 Aug, 2017 1 commit
  12. 08 Jun, 2017 1 commit
  13. 03 Apr, 2017 1 commit
  14. 31 Mar, 2017 1 commit
  15. 27 Mar, 2017 1 commit
  16. 20 Mar, 2017 2 commits
    • Kai Uwe Broulik's avatar
      [Task Manager] Add option to toggle grouping on middle click · 2fcd8547
      Kai Uwe Broulik authored
      This adds an option for what to do on middle click which will toggle grouping
      of window of a specific application.
      
      This can already be done in the context menu by (un)checking "Allow this program
      to be grouped" in "Advanced" but this adds a nice shortcut for this.
      
      In contrast to said context menu entry the option in the ComboBox is shown regardless
      of the grouping mode as otherwise it might unintentionally change your setting to
      a (seemingly) non-deterministic value if you disable grouping.
      
      BUG: 323567
      FIXED-IN: 5.10.0
      
      Differential Revision: https://phabricator.kde.org/D5065
      2fcd8547
    • David Edmundson's avatar
      Adjust plasma-desktop to the new fallback prefixes · a521ac8f
      David Edmundson authored
      Summary:
      Grepped code for repaintNeeded on prefixes and adjusted as appropriately to match
      D4827
      
      Test Plan: Booted, looks the same.
      
      Reviewers: #plasma, broulik
      
      Reviewed By: #plasma, broulik
      
      Subscribers: broulik, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D4830
      a521ac8f
  17. 15 Mar, 2017 1 commit
    • Xuetian Weng's avatar
      Fix invalid reference of toolTipArea. · 2f5dbfbc
      Xuetian Weng authored
      Summary:
      When activateTask is called from root Item, it will fail to resolve the
      reference of toolTipArea. This change make toolTipArea a property of Task
      and make activateTask() access it via this property.
      
      Test Plan: Manually test via Meta+number on group item.
      
      Reviewers: hein, #plasma, mart
      
      Reviewed By: mart
      
      Subscribers: mart, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D4996
      2f5dbfbc
  18. 28 Feb, 2017 1 commit
    • Peter Palaga's avatar
      Task Manager: Make the icon size configurable for task buttons in a vertical task manager · 26b92df4
      Peter Palaga authored
      Summary: This improves the rendering when the task manager is oriented vertically. Before this change the taskbar had to be made too wide so that the task buttons show both icon and text. With the present change, the preferred icon size can be chosen via task bar configuration dialog so that text is shown also in narrower vertical task bars.
      
      Test Plan:
      1. Place the task bar vertically
      2. Adjust the task bar width e.g. so that the tray icons appear in rows of three
      3. Open some windows a Dolphin window so that there is at least one task open in the task bar
      
      Before: The task buttons show only icons that stretch through the most of the button width. There is no text in the task button
      
      After:
      1. Task Manager contect menu > Task Manager Settings... >
          Lower the icon size to Small Medium
          Hit OK
      2. The task buttons are showing a bit smaller icons and there is some text shown there too.
      
      Reviewers: davidedmundson, hein, broulik
      
      Reviewed By: hein
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D4550
      26b92df4
  19. 27 Feb, 2017 2 commits
    • Eike Hein's avatar
      Add an option to limit the number of text lines in task buttons. · 0a83f161
      Eike Hein authored
      This is desired by a downstream who always wants a single line of
      text.
      
      This should go into the 5.9 branch to allow them to ship 5.9.
      0a83f161
    • Eike Hein's avatar
      Make the hover state optional. · d1463b3f
      Eike Hein authored
      This is desired by a downstream distro which doesn't want hover
      effects in Task Manager.
      
      This also adds back a small tweak to support themes that don't
      ship a "hover" prefix in tasks.svgz that seems to have gotten
      lost along the way.
      
      It should go into the 5.9 branch to allow them to ship 5.9.
      d1463b3f
  20. 16 Feb, 2017 1 commit
    • Eike Hein's avatar
      Fix crash when invoking Present Windows with the group dialog open. · a261ff25
      Eike Hein authored
      Summary:
      This fixes a regression from aeec4ae8 which unsets the taskManagerItem
      prop when the group dialog is shown to intentionally break window
      highlighting while the dialog is open.
      
      This patch instead fixes highlighting from the group dialog properly
      by including it in the highlight list.
      
      Also adds some extra crash guards.
      
      CCMAIL:bvbfan@abv.bg
      BUG:376205
      BUG:376234
      
      Reviewers: #plasma, anthonyfieroni
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D4525
      a261ff25
  21. 14 Feb, 2017 1 commit
    • Kai Uwe Broulik's avatar
      [Task Manager] Add "Places" for entries belonging to a file manager · ad78eed5
      Kai Uwe Broulik authored
      Since we cannot have dynamic jump list actions but this is an often requested feature and common
      among other desktop environments, at least add the "Places" to entries belonging to a file manager.
      
      To avoid the menu becoming too long, the number of places shown is limited to 5* when the
      application is running and the menu would also have window controls. For when it's a launcher,
      all places are shown as there the menu is less likely to become massive.
      
      This is added to services that contain the "FileManager" category, such as Dolphin.
      
      *) It actually truncates it to 5 entries only if there's more than 7 places.
      There's nothing more frustrating than having a "reveal more" button that ends up adding just one
      or two items once clicked.
      
      Differential Revision: https://phabricator.kde.org/D3815
      ad78eed5
  22. 13 Feb, 2017 2 commits
    • Eike Hein's avatar
      Fix crash when invoking Present Windows with the group dialog open. · 61489110
      Eike Hein authored
      Summary:
      This fixes a regression from aeec4ae8 which unsets the taskManagerItem
      prop when the group dialog is shown to intentionally break window
      highlighting while the dialog is open.
      
      This patch instead fixes highlighting from the group dialog properly
      by including it in the highlight list.
      
      Also adds some extra crash guards.
      
      CCMAIL:bvbfan@abv.bg
      BUG:376205
      BUG:376234
      
      Reviewers: #plasma, anthonyfieroni
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D4525
      61489110
    • Eike Hein's avatar
      Fix crash when invoking Present Windows with the group dialog open. · dc17f78e
      Eike Hein authored
      Summary:
      This fixes a regression from aeec4ae8 which unsets the taskManagerItem
      prop when the group dialog is shown to intentionally break window
      highlighting while the dialog is open.
      
      This patch instead fixes highlighting from the group dialog properly
      by including it in the highlight list.
      
      Also adds some extra crash guards.
      
      CCMAIL:bvbfan@abv.bg
      BUG:376205
      BUG:376234
      
      Reviewers: #plasma, anthonyfieroni
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D4525
      dc17f78e
  23. 25 Jan, 2017 2 commits
    • Eike Hein's avatar
      More like systray. · 3e7e1c07
      Eike Hein authored
      3e7e1c07
    • Eike Hein's avatar
      Overhaul group popup dialog · f6b30cb0
      Eike Hein authored
      Summary:
      A set of UI improvements to the group popup dialog:
      * The dialog was height-limited but not scrollable. It now shows
        a vertical scrollbar if needed.
      * The existing keyboard handling is extended to scroll any item
        navigated to by keyboard into view.
      * At opening time (before the dialog causes a change in window
        focus) the currently-active task (if any) is collected, and
        then made the active item, scrolling it into view if needed.
        Keyboard nav will then start there. This improves initial
        focus handling.
      * The normal wheel-handling is short-circuited in favor of
        scrolling when the dialog overflows.
      
      BUG:375196
      
      Reviewers: #plasma
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D4229
      f6b30cb0
  24. 23 Jan, 2017 1 commit
  25. 16 Jan, 2017 1 commit
  26. 12 Jan, 2017 1 commit
  27. 11 Jan, 2017 2 commits
  28. 09 Jan, 2017 2 commits
    • Kai Uwe Broulik's avatar
    • Kai Uwe Broulik's avatar
      [Task Manager] Indicate applications playing audio · 89e61df4
      Kai Uwe Broulik authored
      This is similar to what most web browsers do nowadays, indicating when audio is being played
      with an option to mute it.
      
      When an application has an audio stream and it is actually playing something ("not corked"),
      after a delay of 2 seconds (to avoid flashing briefly) an audio icon is displayed which disappears
      again once audio stops playing. The context menu always offers the "Mute" option whenever
      there's an audio stream provided by the application, so you can still unmute even after playback
      has stopped. Also, the "muted" icon will be shown whilst the application is muted, regardless
      of whether sound is actually being played.
      
      An application is marked as "Muted" when all associated streams are muted, and toggling mute
      will (un)mute all of them. Since PulseAudio doesn't know windows, when an application has multiple
      windows, all of them will be flagged as playing audio; the same issue we already have with
      Unity Launcher API.
      
      Differential Revision: https://phabricator.kde.org/D3302
      89e61df4
  29. 06 Jan, 2017 1 commit
    • Roman Gilg's avatar
      [Task Manager] Tooltips redesign · 4f9198fc
      Roman Gilg authored
      Reworks the design of the task manager tooltips and adds new features.
      
      Summary:
      * New tooltip design:
      ** Less screen space occupied by tooltips
      ** Tooltips have always the same size
      ** Better structured informations about a task: Appname, window title, desktop,
         activity if useful
      ** Close button better looking and more visible
      * Group tooltips show per group task all individual informations
      * Group tooltips provide context menu per task and its group
      * Group tooltips in vertical bar are lined up as column
      * If supported by media player, controls are available for each instance
        separately
      * Fixed: In any case secondary media players instances are always also shown in
        group tooltip
      * Fixed: Flickable area when exceeding available display space
      * Fixed: Many warning and error messages
      
      Technical overview:
      * For groups instead of relying on the window list provided by X, we now use a
        proper submodel of the grouped tasks
      * Window titles are processed by reg exp to only show the relevant part of them
      * Media player instances are distinguished by their process ids
      
      Reviewers: #plasma, #vdg, hein
      
      Subscribers: plasma-devel
      
      Tags: #plasma, #vdg
      
      Differential Revision: https://phabricator.kde.org/D3738
      4f9198fc
  30. 03 Jan, 2017 1 commit
  31. 16 Dec, 2016 1 commit
  32. 12 Dec, 2016 1 commit
  33. 25 Nov, 2016 1 commit