Skip to content

GitLab

Plasma Desktop
Plasma Desktop
Switch branch/tag
  1. 23 Mar, 2020 2 commits
  3. 22 Mar, 2020 2 commits
    • Alexander Lohnau's avatar
      Launch plugin with argument, change signals · 04e60d7e
      Alexander Lohnau authored 
      Summary:
The kcms/runners plugin is now able to launch a specific plugin using the --arg parameter of kcmshell5 and the deprecated signals have been changed.
And the QLatin1String has been replaced by the QStringLiteral Macro, because the open config method does not have an overload with the QLatin1String class.

Test Plan: You can just type "kcmshell5 plasmasearch --args Dictionary" and additionally to the KRunner configs it should open the plugin config

Reviewers: broulik, mart

Reviewed By: mart

Subscribers: apol, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D26738
      04e60d7e
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 9f57c39b
      Script Kiddy authored 
      In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      9f57c39b
  5. 21 Mar, 2020 1 commit
  7. 20 Mar, 2020 1 commit
  9. 19 Mar, 2020 4 commits
  11. 18 Mar, 2020 1 commit
    • Kai Uwe Broulik's avatar
      [Icons KCM] Floor delegate height · c9f545a3
      Kai Uwe Broulik authored 
      There's two rows, so if the delegate happens to be at an odd size, both rows would be rounded up,
pushing the icons too close to the delegate border.
Since there's already code for unloading the icons that are out of view, nothing should be leaked into the view,
even if we now end up having 1 or 2 pixels of the delegates normally out of view visible.

Differential Revision: https://phabricator.kde.org/D28120
      c9f545a3
  13. 17 Mar, 2020 1 commit
    • Alexandre Pereira's avatar
      Make the animation slider more granular · 06abda3d
      Alexandre Pereira authored 
      Summary:
Between default animation speed and slower/faster, there is a huge change.
Making the slider change from 0.5 instead of one,
makes the speed of animation change in much smaller changes

Reviewers: #plasma, #vdg, ngraham, davidedmundson, broulik

Reviewed By: #plasma, #vdg, ngraham, davidedmundson, broulik

Subscribers: broulik, ngraham, davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28053
      06abda3d
  15. 16 Mar, 2020 1 commit
    • Mikhail Zolotukhin's avatar
      [Various KCMs] Notify about changes in GTK related settings · eede3025
      Mikhail Zolotukhin authored 
      Summary:
Also save colors before saving colorScheme name, so that we can
correctly use heuristic in GTK Config, after the moment we know, that
color scheme has changed.

Test Plan: Check if the order of saving colors and saving color scheme name does not break anything.

Reviewers: #plasma, ngraham, ervin, bport, meven

Reviewed By: ngraham

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27956
      eede3025
  17. 15 Mar, 2020 1 commit
  19. 11 Mar, 2020 1 commit
    • Stefan Brüns's avatar
      [Baloo] Fix firstRun and config change logic · 550cf9ca
      Stefan Brüns authored 
      Summary:
FirstRun should only be set if baloo was *never ever* run before, and
this case is already handled by baloo internally.

Do no try to do a baloo config refresh if it has just been quit.

Also avoid triggering a config update immediately after starting baloo,
it will do another walk of the directory tree.

Reviewers: #baloo, ngraham, #plasma

Reviewed By: #baloo, ngraham

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27917
      550cf9ca
  21. 09 Mar, 2020 2 commits
  23. 02 Mar, 2020 2 commits
  25. 25 Feb, 2020 2 commits
    • Stefan Brüns's avatar
      Remove redundant match for mountpoints · 0acbfba3
      Stefan Brüns authored 
      Summary:
m_excludeList is populated from m_settings->excludeFolders(), so one of
the checks is redundant.

Remove the first and not the second one, as the first does not use
normalized pathes and may miss some matches.

Reviewers: #baloo, ngraham, davidedmundson

Reviewed By: #baloo, ngraham

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27636
      0acbfba3
    • Méven Car's avatar
      KCM/Component email: simplify code · 3d2dfabe
      Méven Car authored 
      Summary:
Clean up adding entries for Added Associations section of mimeapplist
Just find the application set if it is not found by the normal query.
Also add a constant and reuse one.

Reviewers: #plasma, ervin, bport, crossi

Reviewed By: ervin, bport

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27116
      3d2dfabe
  27. 24 Feb, 2020 5 commits
    • Stefan Brüns's avatar
      Remove bogus mount points check when starting baloo on save · 9dc634bd
      Stefan Brüns authored 
      Summary:
The check stops baloo if non of the included pathes is *currently*
mounted, i.e. if a device is mounted later baloo is not running and
can not pick up the device.

Depends on D27612

Reviewers: #baloo, ngraham

Reviewed By: #baloo, ngraham

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27613
      9dc634bd
    • Stefan Brüns's avatar
      Remove unused functions · cd522998
      Stefan Brüns authored 
      Summary:
showMessage() is only declared, but never defined.

includeFolders() and fetchMountPoint(url) are not used.

Depends on D27611

Reviewers: #baloo, ngraham, davidedmundson

Reviewed By: #baloo, ngraham, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27612
      cd522998
    • Stefan Brüns's avatar
      Invert logic of shouldShowMountPoint -> ignoredMountPoint · 31e823b6
      Stefan Brüns authored 
      Summary:
Instead of negating the logic values in several places, just invert
the logic. Also move it out of class, as it does not access any
class members.

Reviewers: #baloo, ngraham

Reviewed By: #baloo, ngraham

Subscribers: usta, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27611
      31e823b6
    • Méven Car's avatar
      KCM/ComponentChooser Treat cases when there is no app for a usage · 8f1043c6
      Méven Car authored 
      Summary: BUG: 417276

Test Plan:
Have no email client installed.
In kcm componentchooser
 - select another browser
 - Save

Before:
 - Crash
After:
 - No crash

Reviewers: bport, ervin, crossi, davidedmundson, #plasma

Reviewed By: bport, ervin, crossi

Subscribers: anthonyfieroni, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27395
      8f1043c6
    • David Edmundson's avatar
      Calculate needsSave on checkbox toggle not on change · 1dd4668f
      David Edmundson authored 
      Summary:
Otherwise we will trigger it during load, which is wasteful.

But worse potentially we haven't evaluated the other settings yet, so it
could trigger that we have changed the settings, and prematurely set
apply to enabled prematurely which currently breaks things.

I suspect it will fix the bug below, I couldn't reproduce reliably
enough to prove it.

Please reopen if it remains an issue

BUG: 411584
Fixed-in: 5.18.2

Test Plan:
Opened KCM
toggling still worked as expected

Reviewers: #plasma, apol, ngraham

Reviewed By: apol, ngraham

Subscribers: apol, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27590
      1dd4668f
  29. 23 Feb, 2020 2 commits
  31. 22 Feb, 2020 3 commits
  33. 21 Feb, 2020 5 commits
  35. 19 Feb, 2020 1 commit
  37. 17 Feb, 2020 2 commits
  39. 15 Feb, 2020 1 commit