GitLab

David Edmundson authored Oct 14, 2021 and Nate Graham committed Oct 14, 2021

The Dashboard representation contains 3 views stacked on top of each
other with one visible at a time with an opacity animation.

Enabled was used (presumably) to ensure that only the active
representation gets input events.

Unfortunately this has a side effect. When switching views the icons on
the inactive view all get enabledChanged events. This triggers a redraw
with a greyed out effect on all icons. This is a very slow path,
especially for something not even visible!

Setting visible also stops input events, without the side effect.


(cherry picked from commit 7881fdf5)

Felipe Kinoshita authored May 25, 2021 and Nate Graham committed May 25, 2021

A real ellipsis character is better for accessibility, as screen readers
will describe it appropriately.

We ported units to use the PlasmaCore.Units singleton earlier; now it's
time to do the same thing for PlasmaCore.Theme.

There are no UI changes or regressions detected.

Konrad Materka authored Nov 14, 2020 and Nate Graham committed Nov 16, 2020

Qt 5.14 introduced new restoreMode mandatory property. Fix warnings like this one:
QML Binding: Not restoring previous value because restoreMode has not been set.

Qt 5.15 introduced new syntax for defining Connections. Fix warnings like this one:
QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }

This commit ports away from units.* to PlasmaCore.Units.*

Summary: Fixes warnings from qmllint about unqualified property access. It also makes the code more readable since it's clear which are the signal's arguments

Test Plan: Did kicker/dashboard things

Reviewers: #plasma, hein

Reviewed By: #plasma, hein

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D26409

Summary: Those will break in Qt 6. Port a few trivial ones suggested by qmllint

Test Plan: Did kicker and dashboard things

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D26224

Summary: "Type to search." is changed to "Type to search..." because there is a user input action that needs to be performed.

Reviewers: ngraham, #plasma, #vdg

Reviewed By: ngraham, #vdg

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D20073

Summary: BUG:405076

Reviewers: #plasma, mart

Reviewed By: #plasma, mart

Subscribers: broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D19518

Summary:
Or on category headers.

BUG:400720

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D17005

Summary:
As there are quite a bit QML files in the respective /ui subdir, having the
JS file in another separate subdir named /code as befire provides
good overview

Test Plan: Applets UI & Config still work as before

Reviewers: #plasma, mart, broulik, hein

Reviewed By: #plasma, mart

Subscribers: apol, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D11148

In 0d6792c4 I turned the JS into a singleton but overlooked that it also accesses plasmoid context property.
Instead of randomly calling outside objects from this library function,
signal what the caller should do.
The function already returned undefined for doing nothing,and true for requesting a close.
Changed all call sites of this function to explicitly check for true

Differential Revision: https://phabricator.kde.org/D10915

Otherwise we would create an instance of this JS file for every delegate.
The only contextual object it uses is i18n, so pass that in for the function call.

Differential Revision: https://phabricator.kde.org/D10507

Summary:
I'd like this in the 5.12 branch as it also fixes a shell freeze.

BUG:387316

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D10456

Summary:
As of Qt 5.9, QQuickWindow synthesizes a hover event once per frame.
This interferes with keyboard navigation when having the mouse
pointer above any item, because after navigating away with the arrow
keys, the next synthesized hover event will cause the item below the
pointer to become the current item again. This patch addresses this
by rejecting onPositionChanged with identical coordinates from the
last event.

It also optimizes the delegate by turning its root item from
MouseArea to Item and turning the per-delegate context menu instance
into a per-view one.

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D9817

Reviewed-by: Marco Martin <notmart@gmail.com>

This code has gotten  messy, should be cleaned up and perhaps
replaced with states.

Summary:
Bug 364778: (DashboardRepresentation.qml)
I add LayoutMirroring.

Bug 372717:
The kicker (Application menu) had special configuration - when the panel is on the right edge the layout is mirrored, because else the sidebar blocking the sub menus.
In RTL direction system this fix cause the search bar to overlap the sidebar.
So I Fix that and I add the same configuration for RTL direction system with left edge panel.

Test Plan:
I compiled from source and use it
For the Application menu I check In RTL and LTR directions and check on all the edge and try to search something
All work fine.

Reviewers: #plasma_workspaces, mart

Reviewed By: mart

Subscribers: hein, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D3553

Also fix a logic bug introduced in 90d9a519.

Summary:
This is one of the tasks on the Plasma 5.9 release todo, as
agreed at the kick-off meeting. Dashboard is about enabling
an alternative fullscreen workflow for people who want one,
and this extends the coverage to widget management. It's also
a widget management workflow many people are used to from
their phone.

This is quite early code, but already works fairly nicely.
There's even polish like pre-loading the widget explorer model
as soon as the tab is hovered to speed up the tab switch, and
keyboard nav is working, too.

I would like to get it reviewed now and merged once egregious
technical founds are identified and eliminated. Please don't
be too picky on the visual or even workflow details - one
reason I want it merged early is so that I can get it into
the VDG's hands via Neon for advice, and also because I want
people to spend some time using it in general. It's early
enough in the 5.9 cycle to iterate more.

In addition to the attached screenshot, here is a video demo:
https://www.youtube.com/watch?v=ajIzfU0eJtI

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D3200

Unfortunately it doesn't work properly in the Kicker sidebar because of
a bug in IconItem::setUsesPlasmaTheme.

BUG:369437

Summary: Matches Kicker menu version.

Reviewers: #plasma, mart

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D2764

BUG:354283

BUG:352416
BUG:354754
BUG:356269

CHANGELOG: Application Dashboard now closes when opening its settings not to conceal them

REVIEW: 125817

REVIEW: 125012