Summary:
Breeze has

if (!(widget->testAttribute(Qt::WA_WState_Created) ||
widget->internalWinId()))
   KWindowSystem::blur(widget->winId(), ...)

which makes sense as the style should not be creating surfaces in polish
and I don't want to remove it.

This is problematic with QMenu::polish which has a subtle behavioural
change compared to QMenu::exec in that it calls ensurePolish before
creating the surface.

Plasma::ContainmentInterface accidentally has this workaround already
for parent window setting.

BUG: 395262

Test Plan:
Right clicked on desktop icon
Looked amazing

Reviewers: #plasma, hein

Reviewed By: #plasma, hein

Subscribers: hein, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14174

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary: If there is only one visible window on the virtual desktop show the title directly instead of "1 Window" + one-entry list.

Test Plan:
Before:
{F6069186}

After:
{F6069189}

Reviewers: hein, broulik, ngraham

Reviewed By: hein, ngraham

Subscribers: mart, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14026

Summary: Like D14116, but for the remaining uses of inappropriate close icons for buttons that will remove widgets or panels. We change those to trash icons to make it clear what will happen.

Test Plan:
{F6108237}

{F6108236}

Reviewers: broulik, #plasma

Reviewed By: broulik, #plasma

Subscribers: gregormi, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14138

Summary:
I often find myself clicking the widget handle's {nav Remove} button and accidentally removing the widget itself when I'm just trying to hide the handle, because the button's current icon communicates "close this thing" better than "delete this thing". By switching it to a trash icon, we communicate its true meaning better and it becomes clear that the button will remove the widget.

This also brings that icon into consistency with the icon used in the context menu's {nav Remove this [widget]} entry.

Test Plan: {F6104676}

Reviewers: #plasma, #vdg, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: gregormi, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14116

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Check for one already running before spawning a new one.
Also move the check for the isDirCache in one place.

Differential Revision: https://phabricator.kde.org/D14077

Creating a TextArea is surprisingly costly.

Differential Revision: https://phabricator.kde.org/D14079

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

It is not used and hasn't been touched since the original kde-workspace split

Differential Revision: https://phabricator.kde.org/D14055

Differential Revision: https://phabricator.kde.org/D14041

Fixes timeline and search URLs in "Computer" tab

BUG: 363337
FIXED-IN: 5.12.7

Differential Revision: https://phabricator.kde.org/D14029

This groups entries in Places under the same categories (Places, Recently Saved,
Remote, Devices, etc) as in all other places where Places are shown

Differential Revision: https://phabricator.kde.org/D14030

It is only used in one place and cached, so no need for a global static that is created
as soon as the plugin is loaded.

Differential Revision: https://phabricator.kde.org/D13999

GIT_SILENT

Avoids the other icons being visible in the highlight frame

No need to load 18 preview pixmaps of which 12 can only be seen during the animation.
Furthermore, cache the pixmaps as ListView deletes and recreates delegates as you scroll,
leading to us recreating the icon pixmaps as you scroll up and down with many
themes installed

Differential Revision: https://phabricator.kde.org/D13793

This entire thing is built on X technology and just crashes when opening it.
Don't show it in settings until it was rewritten to support Wayland.

BUG: 364746
FIXED-IN: 5.13.3

Differential Revision: https://phabricator.kde.org/D13920

It uses Xft unconditionally and crashes the entire module when run on Wayland.

BUG: 396214
FIXED-IN: 5.13.3

Differential Revision: https://phabricator.kde.org/D13919

Test Plan: none

Reviewers: lueck

Reviewed By: lueck

Subscribers: plasma-devel, kde-doc-english

Tags: #plasma, #documentation

Differential Revision: https://phabricator.kde.org/D13903

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
* Resolve inherent layout hint conflicts between full and compact
  representations by setting them seperately.
  This fixes a recent regression causing tiny popups.
BUG:395477
* Correctly respect the panel icon size hint when scaling the
  compact representation, with the code and behavior now matching
  the Icon applet.
* Only expand into the full representation in place on vertical
  panels. This is not a bugfix, and optional. But I think the
  expansion is useless on horizontal panels, and this means fewer
  users have to care about changing the panel icon size hint if
  they're using a really tall horizontal panel or Latte with
  parabolic zooming.

Reviewers: mart, broulik, mvourlakos

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D13870

In JavaScript undefined does not convert to empty string, so undefined != "" is always true.
The role isn't added to the QStandardItemModel for "None", so it is undefined (null QVariant) as far as QML is concerned.

Differential Revision: https://phabricator.kde.org/D13864

The InvalidAppsFilterProxy and GroupSortProxy models were creating
circular parent-child relationships by setting themselves as parents
of their parent objects.

Reviewers: davidedmundson, mart

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D13856

There's no point in loading the entire module when automounting is disabled.
It does Solid device queries which can be quite expensive, albeit it delays initialization.

The AutomounterSettings::shouldAutomountDevice function allows force-mounting even if automounting as a whole is disabled
whereas the KCM UI does not. Not sure what the reason for that is.

Differential Revision: https://phabricator.kde.org/D13852

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"