1. 31 Aug, 2015 2 commits
  2. 30 Aug, 2015 1 commit
  3. 27 Aug, 2015 1 commit
  4. 25 Aug, 2015 1 commit
  5. 24 Aug, 2015 1 commit
    • David Edmundson's avatar
      Fix widget explorer sometimes opening on the wrong side of the screen. · 544e98da
      David Edmundson authored
      Work around a Qt bug.
      
      If there is no setGeometry call on QWindow the XCB backend will not pass
      our requested position to kwin
      as our window position tends to be 0, setX,setY no-ops and means we
      never set a position as far as QWindow is concerned
      by setting it to something silly and setting it back before we show the
      window we avoid that bug.
      
      Qt patch also filed (https://codereview.qt-project.org/123989)
      so hopefully this can be removed in future if that gets merged.
      
      BUG: 332702
      REVIEW: 124869
      544e98da
  6. 23 Aug, 2015 1 commit
    • Albert Astals Cid's avatar
      Fix issues in translation control module · adb75ec5
      Albert Astals Cid authored
      Fixes two problems:
       * Variants not being shown up, i.e. ca ca@valencia showing up both as "català"
       * pt showing up as "português do Brasil"
      
      For the first one i've went the easy route of adding the languageCode if there's an @ in it
      For pt i had to hardcode it since i found no other way to make Qt understand that for "pt" we mean portuguese from portugal
      
      REVIEW: 124885
      BUGS: 345761
      BUGS: 347956
      adb75ec5
  7. 21 Aug, 2015 2 commits
  8. 20 Aug, 2015 3 commits
    • Ragnar Thomsen's avatar
      Fix loading/saving in kded kcm · 15253a74
      Ragnar Thomsen authored
      Fix loading/saving of the autoload status of kded startup services in
      the kcm.
      
      Loading was broken due to a KPluginMetaData::pluginId() being passed to
      autoloadEnabled(), instead of a KPluginMetaData.
      
      Saving was broken due to comparing KPluginMetaData::fileName() to
      treeitem->data(LibraryRole). This didn't work due to
      KPluginMetaData::fileName() sometimes containing (part of) the path in
      addition to the plugin/library name. This was solved by using
      KPluginMetaData::pluginId() instead of KPluginMetaData::fileName().
      
      BUG: 346848
      BUG: 347429
      REVIEW: 124840
      15253a74
    • David Edmundson's avatar
      Fix autostart scripts on startup · 2bbda1e2
      David Edmundson authored
      BUG: 350135
      REVIEW: 124837
      2bbda1e2
    • Jonathan Riddell's avatar
      Update version number for 5.4.0 · d0c0ea91
      Jonathan Riddell authored
      GIT_SILENT
      d0c0ea91
  9. 19 Aug, 2015 2 commits
  10. 17 Aug, 2015 1 commit
  11. 16 Aug, 2015 1 commit
  12. 15 Aug, 2015 1 commit
  13. 12 Aug, 2015 1 commit
  14. 10 Aug, 2015 1 commit
  15. 08 Aug, 2015 1 commit
    • Maxim Mikityanskiy's avatar
      Fix segfaults in kcm_keyboard · a20e1e5c
      Maxim Mikityanskiy authored and David Edmundson's avatar David Edmundson committed
      There are two scenarios that lead to segfault in kcm_keyboard.
      
      1. Run kcmshell5 keyboard; switch to the second tab; in layouts table
      double-click on item in third column so that combo box appears; click on
      empty space in layouts table; [Preview] button does not get deactivated;
      click on that button and see kcm_keyboard crashing.
      2. Run kcmshell5 keyboard; switch to the second tab; modify something so
      that [Reset] button becomes active; select any row in layouts table;
      click on [Reset]; row becomes deselected, but [Preview] button is still
      active; click on that button and see kcm_keyboard crashing.
      
      [Preview] button should become inactive when no rows are selected, but
      in these two scenarios it doesn't.
      KCMKeyboardWidget::layoutSelectionChanged slot does not get called in
      these two cases. What happens in described cases:
      
      1. layoutsTableModel emits dataChanged signal.
      KCMKeyboardWidget::uiChanged slot gets called.
      LayoutsTableModel::refresh is called, then in
      QAbstractItemModel::endResetModel modelReset signal is emitted,
      QAbstractItemView::reset slot gets called, and it calls
      QItemSelectionModel::reset. QItemSelectionModel::reset disables signals
      and calls QItemSelectionModel::clear that calls
      QItemSelectionModel::clearSelection, but signals are disabled, so
      itemSelectionChanged is not emitted, and
      KCMKeyboardWidget::layoutSelectionChanged is not called.
      2. KCMKeyboard::load calls KCMKeyboardWidget::updateUI that calls
      LayoutsTableModel::refresh. All following calls are in the same order as
      in case 1.
      
      I propose to call KCMKeyboardWidget::layoutSelectionChanged manually
      after problematic refreshes to update buttons state. It's not the best
      fix, there still may be places where manual call of
      layoutSelectionChanged is needed, but at least it fixes two segfaults.
      
      REVIEW: 124659
      BUG: 124659
      a20e1e5c
  16. 06 Aug, 2015 1 commit
  17. 03 Aug, 2015 1 commit
  18. 02 Aug, 2015 2 commits
  19. 31 Jul, 2015 4 commits
  20. 30 Jul, 2015 5 commits
  21. 29 Jul, 2015 7 commits