1. 12 Feb, 2018 2 commits
  2. 11 Feb, 2018 1 commit
  3. 10 Feb, 2018 2 commits
  4. 07 Feb, 2018 1 commit
  5. 06 Feb, 2018 1 commit
  6. 05 Feb, 2018 1 commit
    • Eike Hein's avatar
      Improve preview thumbnail quality · db42961a
      Eike Hein authored
      Summary:
      This patch does two things:
      
      * Instead of giving the KAbstractViewAdapter the actual icon size,
        we overprovision by giving it the size times two. This is because
        while we're deriving the grid view cell size from the icon size
        setting, it's not the actual size the thumbnails will be displayed
        at. Our IconItem is sized to almost fill the cell, and for image
        sources with non-square aspect ratios IconItem doesn't scale to
        the next icon size.
      
      * We set IconItem to do smooth scaling.
      
      While this results in lovely visual fidelity, I the performance
      impact is a concern. We're requesting twice as large thumbnails
      now, and we're doing more scaling work. However, thumbnail
      generation is async and doesn't slow down listing. There's also
      the possibility IconItem::smooth could have general performance
      impact unless things are smart enough not to scale when not
      necessary, which is hopefully the case.
      
      BUG:376848
      
      Reviewers: #plasma
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D10223
      db42961a
  7. 04 Feb, 2018 1 commit
  8. 03 Feb, 2018 5 commits
  9. 02 Feb, 2018 1 commit
  10. 01 Feb, 2018 2 commits
  11. 30 Jan, 2018 1 commit
    • Marco Martin's avatar
      Fix iterator · 016eea1d
      Marco Martin authored
      Summary:
      removing favorites crashed, next() has to be called
      before accessing the item
      
      Test Plan: crash--
      
      Reviewers: #plasma, hein, ivan
      
      Reviewed By: #plasma, ivan
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D10177
      016eea1d
  12. 29 Jan, 2018 1 commit
  13. 28 Jan, 2018 1 commit
  14. 26 Jan, 2018 4 commits
  15. 25 Jan, 2018 1 commit
  16. 23 Jan, 2018 3 commits
  17. 22 Jan, 2018 3 commits
    • Eike Hein's avatar
      Make sure the search result that Return will run is highlighted · 19796bc5
      Eike Hein authored
      Summary:
      Otherwise there's no visual feedback that you can just hit
      Return.
      
      This requires refactoring the item list code slightly not to
      implicitly focus the list when the current index changes (so
      focus isn't moved away from the search field). Instead it's
      now done on mouse over and manually by external callers after
      they set an index.
      
      Reviewers: #plasma, mart
      
      Reviewed By: #plasma, mart
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D9962
      19796bc5
    • Eike Hein's avatar
      Don't close plasmoid when closing a subdialog · fc155e94
      Eike Hein authored
      Summary:
      This patch redoes the fencing mechanism around
      plasmoid.hideOnWindowDeactivate for window focus
      handovers to be more reliable and generic. It's now
      always disabled when a dialog is about to be
      destroyed, and renabled on focus-in or when exiting
      the root list. The dialog code is also fixed not
      to close the plasmoid when it knows it's window
      deactivation is part of its own destruction.
      
      WindowSystem::monitorWindowFocus is also changed
      to work in a single-shot sort of way, removing
      the event filter again once it caught an event.
      
      Fixes a refactoring regression from 84f1cb1c.
      
      BUG:388669
      
      Reviewers: #plasma
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D9945
      fc155e94
    • Eike Hein's avatar
      Fix missing action arguments. · c9d7c9dd
      Eike Hein authored
      Fixes regression from core refactoring in 1062a6a2.
      
      BUG:389234
      c9d7c9dd
  18. 19 Jan, 2018 2 commits
  19. 17 Jan, 2018 1 commit
  20. 16 Jan, 2018 2 commits
    • Kai Uwe Broulik's avatar
      [Folder View] Don't trash local files · 5551d9be
      Kai Uwe Broulik authored
      Send the actual URL (e.g. desktop:/foo) to KIO and let it figure it out. Otherwise KDirNotify emits a change for the
      backing file:///home/foo/Desktop URL and KDirLister cannot relate the two and doesn't notice a deletion immediately.
      Since we don't offer "Move to Trash" for non-local files anyway, this should be safe.
      
      While at it, check for whether files can be moved before offering Trash and whether files can be deleted before
      offering Delete (Dolphin does that). I can split that into a separate commit, if you prefer.
      
      CHANGELOG: Fixed long delay when deleting (moving to trash) files on the desktop
      
      Differential Revision: https://phabricator.kde.org/D9914
      5551d9be
    • Kai Uwe Broulik's avatar
      [Style KCM] Sync KConfig before announcing change · 6ae42771
      Kai Uwe Broulik authored
      Otherwise by the time applications receive the DBus signal, the config change has not been written to disk yet.
      
      Differential Revision: https://phabricator.kde.org/D9891
      6ae42771
  21. 15 Jan, 2018 4 commits