1. 10 Sep, 2020 1 commit
  2. 09 Sep, 2020 1 commit
  3. 14 Aug, 2020 1 commit
  4. 23 May, 2020 1 commit
    • Aleix Pol Gonzalez's avatar
      --warnings · b1c3af20
      Aleix Pol Gonzalez authored
      Port away from some deprecated Qt constructions.
      Mark arguments as unused, remove unused variables.
      Properly sort constructors
      b1c3af20
  5. 04 Feb, 2020 1 commit
  6. 20 Dec, 2019 1 commit
  7. 13 Nov, 2019 1 commit
  8. 24 Oct, 2019 1 commit
  9. 04 Sep, 2019 1 commit
  10. 27 Aug, 2019 1 commit
  11. 31 Jul, 2019 1 commit
    • Aleix Pol Gonzalez's avatar
      Remove some uses on QDesktopWidget · a8efa865
      Aleix Pol Gonzalez authored
      Summary: Adds an unnecessary dependency to QtWidgets and forces some round-trips to the X server that we don't need.
      
      Test Plan: Been using it for some days
      
      Reviewers: #plasma, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: hein, davidedmundson, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D22738
      a8efa865
  12. 05 May, 2019 1 commit
  13. 02 Apr, 2019 1 commit
    • Oleg Solovyov's avatar
      foldermodel: store information about screen used · dcb4c158
      Oleg Solovyov authored
      Summary:
      BUG: 401464
      
      According to FolderModel::filterAcceptsRow code, it is possible that folderview is used by containment but not associated with a screen.
      In case of m_screen == -1 there was no information about which items we should filter out.
      
      Instead, we do not change m_screen to -1 and we can filter out items that does not belong to our screen.
      m_screenUsed shows whether folderview is associated with a screen or not
      
      Reviewers: broulik, hein, #plasma
      
      Reviewed By: hein, #plasma
      
      Subscribers: cfeck, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D18979
      dcb4c158
  14. 12 Mar, 2019 1 commit
  15. 11 Feb, 2019 1 commit
  16. 01 Feb, 2019 1 commit
    • Eike Hein's avatar
      Fix new file creation leading to dupe items on a fresh view · 4a3fbf91
      Eike Hein authored
      Summary:
      This was a regression caused by the code attempting to insert new items
      at drop position, if available. `setSortMode` was being called in a slot
      connected to the dir model's rowsInserted, but the Positioner has to be
      initialized earlier as a proxy needs to handle
      `sourceRowsAboutToBeInserted` as well.
      
      Thanks to an investigation and patch by Oleg Solovyov in D17689 for
      helping to get to the bottom of this.
      
      This is aimed at 5.12+.
      
      BUG:401023
      
      Reviewers: #plasma, McPain, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: ngraham, davidedmundson, fvogt, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D18182
      4a3fbf91
  17. 15 Dec, 2018 1 commit
  18. 21 Nov, 2018 1 commit
  19. 19 Nov, 2018 1 commit
  20. 07 Nov, 2018 1 commit
    • David Edmundson's avatar
      Avoid needless config parse · 7b1b27fa
      David Edmundson authored
      Summary:
      There's practically no reason to ever open kdeglobals. The way the kde
      cascading configuration system works is that we'll have those settings
      included in our plasmashellrc which we've already loaded.
      
      Not only is it faster but we also honour any kdeglobals setting
      overrides from /etc/ .
      
      Test Plan:
      Changed setting in kdeglobals
      Setting still applied
      
      Reviewers: #plasma, hein, apol
      
      Reviewed By: apol
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D16384
      7b1b27fa
  21. 24 Oct, 2018 1 commit
  22. 04 Oct, 2018 2 commits
  23. 12 Sep, 2018 1 commit
    • Alex Nemeth's avatar
      Add translucent background attribute to desktop icon popup menu · cc47b950
      Alex Nemeth authored
      Summary:
      This fixes the issue when menu transparency is enabled in the Breeze widget settings the context menu of desktop icons have no transparency.
      Multiple users (including me) have reported that D14174 did not solve the problem.
      
      BUG: 395262
      
      Test Plan:
      Before:
      {F6253280}
      
      After:
      {F6253279}
      
      Reviewers: hein, davidedmundson, #plasma
      
      Reviewed By: davidedmundson, #plasma
      
      Subscribers: ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D15435
      cc47b950
  24. 06 Sep, 2018 2 commits
  25. 05 Sep, 2018 1 commit
  26. 23 Aug, 2018 1 commit
  27. 18 Jul, 2018 1 commit
    • Robert Hoffmann's avatar
      Fix drop between shared views · cab9078e
      Robert Hoffmann authored
      Summary:
      Remove trailing slash from folderUrl, too, when comparing to
      the file's url (minus file name minus trailing slash). FolderUrls
      like file:///home/user/Desktop/ may appear and fail comparing.
      
      Fixes regression introduced in 07001277
      (see https://phabricator.kde.org/D10729) which fixes urls like
      file:///home/user/foo (if using a different folder than Desktop)
      but breaks moving files from one screen to another using normal
      Desktop folder.
      
      Test Plan:
      1. Use folder view, Desktop folder, more than one screen.
      Create files and folders in Desktop folder and move them from one
      screen to another. The Copy/Move/Link menu must not appear
      and files/folders must be dropped onto the other screen.
      
      2. Use a different folder than Desktop (the same on both screens).
      Moving files/folders to another screen must work like in 1.
      
      Reviewers: mart
      
      Reviewed By: mart
      
      Subscribers: amantia, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D13612
      cab9078e
  28. 17 Jul, 2018 1 commit
    • David Edmundson's avatar
      Fix blur behind folderview context menus · 42a74c9a
      David Edmundson authored
      Summary:
      Breeze has
      
      if (!(widget->testAttribute(Qt::WA_WState_Created) ||
      widget->internalWinId()))
         KWindowSystem::blur(widget->winId(), ...)
      
      which makes sense as the style should not be creating surfaces in polish
      and I don't want to remove it.
      
      This is problematic with QMenu::polish which has a subtle behavioural
      change compared to QMenu::exec in that it calls ensurePolish before
      creating the surface.
      
      Plasma::ContainmentInterface accidentally has this workaround already
      for parent window setting.
      
      BUG: 395262
      
      Test Plan:
      Right clicked on desktop icon
      Looked amazing
      
      Reviewers: #plasma, hein
      
      Reviewed By: #plasma, hein
      
      Subscribers: hein, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D14174
      42a74c9a
  29. 12 Jul, 2018 1 commit
  30. 13 Jun, 2018 1 commit
  31. 03 Jun, 2018 1 commit
    • Eike Hein's avatar
      Make drags from the Task Manager less prone to disaster · c801276a
      Eike Hein authored
      Summary:
      The Task Manager applet previously set a task's launcher URL as
      generic URL MIME data of drags initiated from it. This made
      everything that's willing to handle an URL drop a drop target
      for drags from the Task Manager, which resulted e.g. in users
      accidentally dropping .desktop files into chat apps that would
      immediately send them as a message.
      
      In truth, the utility of drags initiated from the Task Manager
      is mostly confined to the shell: Adding apps to the desktop, to
      the panel, to launcher menus (we don't have this currently but
      should add it), and so on. It's therefore appropriate to use a
      special internal MIME type for this payload instead of one as
      generic as text/url. We already use special internal MIME types
      to shuttle around window ids (for drops onto pagers, to assign
      tasks to different virtual desktops or activities) and filter
      out drops onto the Task Manager applet itself.
      
      This patch makes the necessary changes in the Task Manager and
      in the Folder View containment, which needs special care due to
      its complex drop handling. A seperate patch will augment
      ContainmentInterface::processMimeData to take care of the Desktop
      and Panel containments (while compatible with the Folder View
      change).
      
      This is an implementation of an idea by David Edmundson posted
      in D13162.
      
      Reviewers: davidedmundson, Zren
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D13274
      c801276a
  32. 25 Apr, 2018 1 commit
  33. 24 Apr, 2018 1 commit
  34. 05 Apr, 2018 3 commits
  35. 08 Mar, 2018 1 commit
  36. 28 Feb, 2018 1 commit