1. 07 Jun, 2020 3 commits
    • Adriaan de Groot's avatar
      Normalize include-quotes · 59317865
      Adriaan de Groot authored
      - from local directory, use "" (esp. the header file for this .cpp)
      59317865
    • Adriaan de Groot's avatar
      Correct salting array: · bdca8c01
      Adriaan de Groot authored
      - Missing letter "w" and "W" in list of characters meant only 62
        letters, so less than 6 bits of randomness per salt char.
      - A char array like this one still has a trailing NUL char which
        affects the sizeof. Since bounded produces a number < its second
        argument, need to discount the NUL so we only index into
        the letters-part of the string.
      
      Add static_assert() to catch this.
      bdca8c01
    • Adriaan de Groot's avatar
      Sanitize saltCharacter() · 6b822924
      Adriaan de Groot authored
       - the array of salt chars should be const, it's read-only
       - the array of salt chars should be static, since it is
         initialized to a constant value anyway and can live beyond
         this one function
       - sizeof(char) is 1 by the standard, so remove the weird
         array-size calculation: here saltCharacters has type
         (const) char[63], and its sizeof() is 63
      6b822924
  2. 27 May, 2020 1 commit
    • Harald Sitter's avatar
      make bounded() unambiguous · 0cfda413
      Harald Sitter authored
      ```
      std::size_t is the unsigned integer type of the result of the sizeof
      operator
      ```
      
      this can make the bounded call ambiguous as it either sports
      an int(int,int) signature or an quint32(quint32,quint32) signature. with
      size_t being unsigned and 0 being int it's not necessarily clear to the
      compiler which overload to use, so make it clear by using usigned
      everywhere.
      this specifically fixes arm32 compatibility on ubuntu 20.04
      0cfda413
  3. 26 May, 2020 1 commit
    • Adriaan de Groot's avatar
      Remove spurious Q_EMIT · 8be74e64
      Adriaan de Groot authored
      This Q_EMIT has wandered in from somewhere else; it's not a
      syntax error because Q_EMIT is defined to empty, but it looks
      weird and misplaced.
      8be74e64
  4. 23 May, 2020 1 commit
    • Aleix Pol Gonzalez's avatar
      --warnings · b1c3af20
      Aleix Pol Gonzalez authored
      Port away from some deprecated Qt constructions.
      Mark arguments as unused, remove unused variables.
      Properly sort constructors
      b1c3af20
  5. 21 May, 2020 1 commit
    • Jan Blackquill's avatar
      Add users KCM · b1c941fc
      Jan Blackquill authored
      
      
      Summary:
      This patch introduces a new users KCM based off of the AccountsService.
      Co-authored-by: Nicolas Fella's avatarNicolas Fella <nicolas.fella@gmx.de>
      
      Closes T7246
      
      Test Plan:
      {F8185451}
      {F8185453}
      {F8185454}
      
      Reviewers: #plasma, #vdg, ngraham
      
      Reviewed By: #vdg, ngraham
      
      Subscribers: ltoscano, mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T7246
      
      Differential Revision: https://phabricator.kde.org/D28154
      b1c941fc