GitLab

Summary:
When a user tries to set operation mode to "Times", the Apply button
remains enabled after it's been clicked. The reason for that is timings
provided by the kcm include seconds and milliseconds, while timings
sent by KWin don't.

Because seconds and milliseconds are different, CompositorAdapter::
checkStaged() will return false even though hours and minutes haven't
been modified by the user.

In order to address this problem, my patch adjusts the TimeField
component so it provides Date objects with seconds and milliseconds set
to 0. There is another way to fix this issue though. We could check in
CompositorAdaptor::checkStaged() method whether only hours and
minutes have been modified.

Test Plan:
- Set operation mode to "Times"
- Click the Apply button
- Check that the Apply button is disabled

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D25047

GIT_SILENT

Gabriel Craciunescu authored Oct 28, 2019 and Nate Graham committed Oct 28, 2019

Summary:
The kcm UI has right now a step size of 24 with a max size of 1000 and a minimum of 1.

Max size need to divide to step size and the lowest possible value should be the step size
because  0 means disabled.

Reviewers: davidedmundson, #plasma

Reviewed By: davidedmundson, #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D25004

GIT_SILENT

Mirai Komachi authored Oct 22, 2019 and Nate Graham committed Oct 22, 2019

Summary:
LIBINPUT_PROP_ACCEL_PROFILE_ENABLED contains two values,
valueWriterPart<bool> function didn't handle it correctly.

BUG: 398713
FIXED-IN: 5.17.1

Reviewers: #plasma, romangg, ngraham

Reviewed By: #plasma, romangg, ngraham

Subscribers: anthonyfieroni, ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24711

BUG: 413227
FIXED-IN: 5.17.1

Differential Revision: https://phabricator.kde.org/D24854

Summary:
Otherwise they're annoying to use because you can only interact with them using a scroll
or by clicking on the tiny arrows.

Test Plan: You can now enter text in the spinboxes

Reviewers: #vdg, #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24814

Summary:
I changed the "forceStripes" checkbox string in D19280, most likey because I thought it wasn't super understandable.

The new string I pushed doesn't, however, match what the option does.

So reverting the change.

BUG: 412801

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24534

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

This was only done for changes to the "effects", not the actual widget style, but:

* plasma-integration updates ShowIconsOnPushButtons and ShowIconsInMenuItems when a change to SETTINGS_STYLE is notified by the KCM
* plasma-integration updates toolbar style when ToolbarStyleChanged is notified by the KCM

Differential Revision: https://phabricator.kde.org/D24260

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

This way we write to the same shared config instance as e.g. krdb and when we sync() it then also reads the current values.

CHANGELOG: Fixed font antialiasing and hinting settings not correctly saving

Differential Revision: https://phabricator.kde.org/D24562

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

GIT_SILENT

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Especially the TypeRole can be quite heavy.

Differential Revision: https://phabricator.kde.org/D23675

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
The button grid was not centered, the content inside the buttons was not centered, the
vertical spacing was too high on top and too low on bottom, and the explanatory text
got cut off.

This patch solves all those problems.

Big thanks to @davidedmundson for his help getting this merge-ready.

BUG: 409957
FIXED-IN: 5.17.0

Test Plan:
Before: {F7247447, size=full}
After: {F7247446, size=full}

Reviewers: #vdg, #plasma, davidedmundson, GB_2, hein

Reviewed By: #vdg, #plasma, davidedmundson, GB_2

Subscribers: hein, GB_2, davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D23158

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary: Not longer needed after 84c8dade.

Test Plan: Still builds fine

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24098

GIT_SILENT

GIT_SILENT

qApp->fontMetrics() calls desktop() which creates a QDesktopWidget and might do so on a non-main thread in case of threaded rendering.

BUG: 411953
FIXED-IN: 5.12.10

Differential Revision: https://phabricator.kde.org/D23980

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
Currently, Pinned Icons-Only Task Manager launchers are capable of showing progress
information even when they're not running, because the app didn't unset the progress
information before quitting, or crashed in the middle of an operation. But the concept
of an in-progress operation for an app that isn't running doesn't make logical sense.

This patch fixes that UI issue by only allowing pinned IOTM apps to show progress
information while they're actually running.

BUG: 409687
FIXED-IN: 5.17.0

Test Plan:
Pinned Elisa app no longer shows progress information on its icon after quitting while
playing a song

Pinned Discover app no longer shows progress information on its icon after crashing in
the middle of an update

IOTM apps still shows progress information while running

No change for regular Task Manager

Reviewers: #vdg, #plasma, ndavis

Reviewed By: #vdg, ndavis

Subscribers: broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24001

Summary: Side effect from trying to figure out what needs to be done for T11568.

Reviewers: plasma-devel, sitter

Reviewed By: sitter

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D23821

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
Use QIcon instead of QPixmap for icons. Use QPushButton for the filter menu instead of a QLabel.

{F7340233}

Depends on D23942

Reviewers: #plasma, ngraham

Reviewed By: ngraham

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D23868

plugin is now part of plasma-workspace, so other launcher can easily
re-use models.

CCMAIL: hein@kde.org
CCMAIL: plasma-devel@kde.org

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
Folder View items currently have shadows behind their labels, but not their icons.

This patch adds a very subtle shadow for the icons as well, which improves contrast
for some backgrounds and just looks classy IMO. :)

FEATURE: 411607
FIXED-IN: 5.17.0

Test Plan:
Before: {F7334103, size=full}
After: {F7334104, size=full}

Reviewers: hein, #plasma, #vdg, filipf, ndavis

Reviewed By: #vdg, filipf, ndavis

Subscribers: broulik, GB_2, cfeck, ndavis, filipf, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D23803

kglobalsettings. How to port them ?