1. 13 Dec, 2018 1 commit
  2. 05 Dec, 2018 1 commit
  3. 29 Nov, 2018 1 commit
    • Nate Graham's avatar
      [Folder View] implement a minimum width for icon view to ensure that labels... · 0b654afd
      Nate Graham authored
      [Folder View] implement a minimum width for icon view to ensure that labels are never rendered useless
      Currently with Folder-View-on-the-desktop, items' labels become illegibe when the icon size is very small.
      This patch implements a minimum width when using on-the-desktop icon view to make sure that the label is never uselessly short when using very small icons.
      BUG: 379432
      FIXED-IN: 5.12.8
      Test Plan:
      Smallest size, before: {F6426124}
      Smallest size, after: {F6426126}
      Equal padding on either side of the container itself still works: {F6426129}
      There is no change for sizes corresponding to the fourth tick on the slider and beyond
      Reviewers: #plasma, #vdg, hein
      Reviewed By: #plasma, hein
      Subscribers: abetts, broulik, plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D16901
  4. 28 Nov, 2018 1 commit
    • Eike Hein's avatar
      Fix group popup dialog · ed34cc5f
      Eike Hein authored
      Fixes regression introduced with ab26ebb1: That diff contained
      a change unrelated to the original submission, swapping a || out for
      && in response to a review note. This turns out to have broken things.
      Reviewers: davidedmundson
      Subscribers: plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D17219
  5. 27 Nov, 2018 2 commits
    • Nate Graham's avatar
      [Folder View] improve label contrast against challenging backgrounds · 10278e79
      Nate Graham authored
      Currently the shadow behind Folder View items' labels is very subtle. This leads to poor contrast against wallpapers that are light-colored, visually busy, or both.
      This patch attempts to improve the situation by tightening up the shadow so that it looks more like a subtle, tasteful outline.
      BUG: 361228
      FIXED-IN: 5.12.8
      Test Plan:
      Folder View items against various wallpapers:
      {F6439459, size="full"}
      {F6439458, size="full"}
      {F6439463, size="full"}
      {F6439457, size="full"}
      {F6439456, size="full"}
      {F6439455, size="full"}
      {F6439454, size="full"}
      {F6439453, size="full"}
      {F6439452, size="full"}
      {F6439451, size="full"}
      Folder View items against the default wallpaper:
      {F6439449, size="full"}
      Reviewers: #plasma, hein, #vdg
      Reviewed By: #plasma, hein
      Subscribers: abetts, svenmauch, matheusm, filipf, emateli, mart, plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D16968
    • Nate Graham's avatar
      [Componentchooser KCM] Make default browser app choice work even when combobox is not used · 26fb5ec2
      Nate Graham authored
      BUG: 350663
      FIXED-IN: 5.12.8
      When choosing a default browser app using the app list combobox, the choice was only being saved after the combobox was used, because its signal was connected to an inline function that saved the choice, while the radio button that enabled the combobox was not. As a result, if you clicked on that radio button and didn't need to use the combobox because it was already showing your preferred browser, that action was not actually getting saved.
      This patch fixes the situation my moving the inline function into a real explicit slot function and connecting the radio button to it as well.
      Test Plan:
      - Go to the component chooser KCM's default browser module
      - Reset to defaults, then leave the KCM and open it again
      - Click the {nav in the following application} radio button
      - Do NOT touch the combobox
      - Click {nav Apply}
      - Leave the KCM and come back
      With this patch, the radio button's state is preserved and the correct browser is selected in the combobox.
      Reviewers: #plasma, cfeck, davidedmundson
      Reviewed By: #plasma, davidedmundson
      Subscribers: davidedmundson, plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D17181
  6. 21 Nov, 2018 1 commit
  7. 19 Nov, 2018 2 commits
    • Eike Hein's avatar
      Revert unintended line · 45434737
      Eike Hein authored
    • Eike Hein's avatar
      Compress calls to `updateSize` · ab26ebb1
      Eike Hein authored
      Repeater+Flow has no reliable way to transactionize/batch insertion,
      e.g. `Flow.positionCompleted` is useless in a function that can change
      the Flow's size, and transition events like populated and similar
      aren't available. Refactoring this to be a ListView isn't appealing
      because it would mean the code loses the property of being reused for
      both the bar and the popup, and therefore is well-tested already.
      This brings down the number of `updateSize` calls when opening the
      dialog for a group of five from five to one.
      Reviewers: #plasma, davidedmundson
      Subscribers: plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D17006
  8. 18 Nov, 2018 1 commit
  9. 14 Nov, 2018 1 commit
  10. 02 Nov, 2018 1 commit
  11. 01 Nov, 2018 1 commit
  12. 29 Oct, 2018 1 commit
  13. 25 Oct, 2018 1 commit
  14. 23 Oct, 2018 2 commits
    • Eike Hein's avatar
      Remove. · 0e1aa9e0
      Eike Hein authored
    • Eike Hein's avatar
      Focus handling fixes · 03b17ac5
      Eike Hein authored
      * Fix keyboard nav on the desktop again.
      * Fix initial focus properly.
      * Make sure when using arrows after starting Plasma or after clicking
        into empty space, the first selected item is always 0, not 1 or
        some random item based on previous activity.
      * Make sure the view is always scrolled up when (re)opening the popup.
      Reviewers: broulik
      Subscribers: plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D16106
  15. 22 Oct, 2018 2 commits
  16. 21 Oct, 2018 1 commit
  17. 07 Oct, 2018 1 commit
  18. 04 Oct, 2018 3 commits
  19. 25 Sep, 2018 1 commit
  20. 24 Sep, 2018 1 commit
  21. 16 Sep, 2018 1 commit
  22. 08 Sep, 2018 1 commit
  23. 06 Sep, 2018 1 commit
    • Eike Hein's avatar
      Improve arrow key navigation of Kicker search results · 1692ae24
      Eike Hein authored
      Kicker already makes sure the first search result is highlighted
      and actionable while searching. This patch makes arrow-down after
      typing move to the second search result instead of merely moving
      focus from the search field to the list, so the user doesn't have
      to press arrow-down twice anymore.
      It also allows using arrow-left/right to jump to the other result
      columns, when the cursor is at the start or end of the text field,
      Reviewers: ngraham
      Subscribers: plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D15286
  24. 04 Sep, 2018 1 commit
  25. 27 Aug, 2018 1 commit
  26. 26 Aug, 2018 1 commit
  27. 20 Aug, 2018 1 commit
  28. 15 Aug, 2018 1 commit
  29. 11 Aug, 2018 1 commit
  30. 02 Aug, 2018 1 commit
    • Mathias Tillman's avatar
      fontinst quits after KJob is done · 690570a4
      Mathias Tillman authored
      As the summary says, when installing/removing multiple fonts to system the expected behaviour would be for fontinst to keep running after the first font has been installed or removed, instead it quits which causes a bunch of issues. fontinst uses KJob to authorize and internally KJob uses a QEventLoopLocker which causes the main event loop to quit when it's done.
      I'm not entirely sure why the event loop locker is enabled by default for KJob, but the patch I have attached works around this by completely disabling that functionality for fontinst. There's a timer that runs in the background which checks for any connected clients, so it will quit after a little while regardless.
      BUG: 379524
      BUG: 379324
      BUG: 349673
      BUG: 361960
      BUG: 392267
      Test Plan: Make sure fonts are still installed and removed properly.
      Reviewers: #plasma, dfaure, aacid, gateau
      Reviewed By: dfaure
      Subscribers: wbauer, ngraham, plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D14493
      (cherry picked from commit 60c89575)
  31. 01 Aug, 2018 2 commits
    • Kai Uwe Broulik's avatar
      [Desktop Toolbox] Emit contextualActionsAboutToShow before opening · 3485b7d3
      Kai Uwe Broulik authored
      The toolbox shows containment-specific actions, just like the desktop contextmenu does.
      The containment may update or creates its actions on-demand leading to outdated actions showing up in the toolbox.
      BUG: 384862
      FIXED-IN: 5.12.7
      Differential Revision: https://phabricator.kde.org/D14535
    • Eike Hein's avatar
      Fix bad model hygiene in Positioner::move() · 1cb71a2c
      Eike Hein authored
      Don't change the proxy maps prior to insert/remove transactions so
      rowCount() at transaction start time matches the count passed into
      the method. The old code hits an ASSERT in Qt 5.11 otherwise.
      Care is taken not to emit dataChanged() in the middle of another
      Also cleaned up vestiges of caching lastRow(): This cache was
      evicted all over the places but never actually filled anymore, so
      maybe we don't need it.
      Reviewers: davidedmundson
      Subscribers: plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D14243
  32. 30 Jul, 2018 1 commit
  33. 22 Jul, 2018 1 commit