1. 22 Jan, 2020 1 commit
    • Mikhail Zolotukhin's avatar
      [App Style KCM] Hide preview buttons, if previewers are not found · 74f7e064
      Mikhail Zolotukhin authored
      Summary:
      BUG: 416343
      FIXED-IN: 5.18.0
      
      Test Plan:
      # Open GTK page of Application Style KCM, the preview buttons should be present
      # Delete `usr/lib/libexec/gtk_preview` file or rename it to something else
      # Reopen GTK page of KCM - the GTK2 preview button should disappear
      # Delete `usr/lib/libexec/gtk3_preview` file or rename it to something else
      # Reopen GTK page of KCM - the GTK3 preview button should disappear too
      # Bring back the deleted/renamed files
      # Reopen KCM, the buttons should be present
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26770
      74f7e064
  2. 21 Jan, 2020 1 commit
  3. 20 Jan, 2020 2 commits
  4. 19 Jan, 2020 1 commit
  5. 18 Jan, 2020 1 commit
  6. 17 Jan, 2020 1 commit
  7. 16 Jan, 2020 3 commits
  8. 15 Jan, 2020 5 commits
    • Dan Leinir Turthra Jensen's avatar
      Switch the Plasma Desktop KCMs to using KNewStuffQuick · 442c43b3
      Dan Leinir Turthra Jensen authored
      Summary:
      This switches the KCMs which previously used a bit of a hack to show the old Widgets based Get Hot New Stuff dialog from a button in the Qt Quick based KCMs so that they instead use the new KNewStuff Qt Quick submodule. The modules affected by this are:
      
      * Colors
      * Cursor Theme
      * Desktop Theme
      * Icons
      * KSplash
      
      Reviewers: mart, ngraham
      
      Reviewed By: mart, ngraham
      
      Subscribers: bcooksley, davidedmundson, ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26544
      442c43b3
    • Mikhail Zolotukhin's avatar
      [Application Style] Add GTK Application Style Page · 268c5ced
      Mikhail Zolotukhin authored
      Summary:
      The GTK KCM is now moved to Application Style KCM as a sub page. The
      functionality is identical to the one, found in GTK KCM, as well for the
      bugs :)
      
      The page is only accessible, if the `gtkconfig` kded module is loaded,
      because only with the module the configuration can be changed.
      
      Depends on D26261
      
      Test Plan:
      # Apply D26261
      # **Restart kded5**
      # Open System Settings, go to Application Style KCM
      # The button for GTK Configuration should be present
      # Go to Startup and Shutdown > Background Services, disable `Plasma GTKd` {F7877157}
      # Return to the App Style KCM, the button should disappear
      # Return to the Kded KCM and enable `Plasma GTKd` back
      # Return to the App Style KCM - button is present now
      # Go to subpage
      # Happy (I hope) testing!
      
      {F7877153}
      
      {F7877154}
      
      Reviewers: #vdg, broulik, #plasma, ngraham, mart
      
      Reviewed By: #vdg, #plasma, ngraham, mart
      
      Subscribers: davidedmundson, ngraham, plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T10611
      
      Differential Revision: https://phabricator.kde.org/D26583
      268c5ced
    • Cyril Rossi's avatar
      KCM Notifications : fix applications behavior not properly updated in KCM · e236b520
      Cyril Rossi authored
      Reviewers: #plasma, ervin, bport, meven, broulik
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26683
      e236b520
    • Kai Uwe Broulik's avatar
      [Notifications KCM] Force re-evaluation of position radio buttons · db95a53c
      Kai Uwe Broulik authored
      The Settings object is kind of a write-only state and doesn't signal property changes unless "live" (where it would listen to other
      settings changing which we don't want inside the KCM) or only upon save().
      This is arguably a questionable design decision on my side :-) but usually it's not a problem as the KCM controls will have
      whatever state the user will put them in but it falls apart in case we switch to another page and back without saving.
      
      BUG: 414098
      FIXED-IN: 5.18.0
      
      Differential Revision: https://phabricator.kde.org/D26162
      db95a53c
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · ae4467ef
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      ae4467ef
  9. 14 Jan, 2020 3 commits
  10. 13 Jan, 2020 3 commits
  11. 12 Jan, 2020 2 commits
  12. 10 Jan, 2020 5 commits
  13. 09 Jan, 2020 1 commit
  14. 08 Jan, 2020 5 commits
    • Kevin Ottens's avatar
      DesktopPaths KCM: Remove the moving directory logic · db1ebdc9
      Kevin Ottens authored
      Summary:
      This simplifies greatly this otherwise mundane KCM. It introduced a lot
      of complexity while gettings things wrong anyway: it would miss if a
      directory is included in another one except in the "autostart inside
      desktop" case, it would also leave you stranded in case of an
      uncompleted move.
      
      So now the KCM has a clear purpose: edit the settings. Moving data
      around is still up to the user using a proper filemanager.
      
      Long term it would probably be better for the filemanager to edit the
      settings automatically when the user move on of those folders around,
      then the KCM could be decommissioned.
      
      Reviewers: #plasma, crossi, bport, meven, mart, davidedmundson
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26391
      db1ebdc9
    • Kevin Ottens's avatar
      DesktopPaths KCM: Move the view logic in a ui file · f9fb1115
      Kevin Ottens authored
      Summary: Now the revert/apply/defaults buttons work as expected.
      
      Reviewers: #plasma, crossi, bport, meven, mart, davidedmundson
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26390
      f9fb1115
    • Kevin Ottens's avatar
      DesktopPaths KCM: Move the settings logic to a KCoreConfigSkeleton class · ea8009b3
      Kevin Ottens authored
      Summary:
      Our KCoreConfigSkeleton subclass is interestingly hand written since
      it's too remote from what we usually do (the resulting file needs to be
      sourceable and we don't want the usual behavior of removing keys when
      they're set to defaults).
      
      The only one which was "more standard" was the autostart path, but
      really with the URL conversion on top and for just a single entry, I
      shoved it in the hand written class as well.
      
      Doesn't reduce the code much, but at least it separates that logic from
      the KCM and it opens the door to properly working defaults button.
      
      Reviewers: #plasma, crossi, bport, meven, mart, davidedmundson
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26389
      ea8009b3
    • Kevin Ottens's avatar
      Get rid of KGlobalSettings · 29c01adc
      Kevin Ottens authored
      Summary:
      After grepping in all our repositories, it looks like the SETTINGS_PATHS
      category is completely unused (at least I couldn't find anyone doing
      anything paths related on the slot end).
      
      Reviewers: #plasma, mart, davidedmundson
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26388
      29c01adc
    • Méven Car's avatar
      KCM/Component remove traces of Kdelibs4 migration · bde038c0
      Méven Car authored
      Test Plan: Compiles
      
      Reviewers: ervin, #plasma
      
      Reviewed By: ervin
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26515
      bde038c0
  15. 07 Jan, 2020 2 commits
  16. 06 Jan, 2020 4 commits