1. 20 Oct, 2021 1 commit
  2. 16 Aug, 2021 1 commit
  3. 25 Jun, 2021 1 commit
  4. 10 Jun, 2021 1 commit
  5. 27 Apr, 2021 1 commit
    • Ismael Asensio's avatar
      [AppletConfiguration] Reduce padding · 70f8d100
      Ismael Asensio authored
      Default paddings on the applet configuration dialogs were quite high
      (18px for contents and 12px for the button row)
      
      Set smaller padding values (Kirigami.Units.largeSpacing) to make
      them more consistent with the usual KCM margins and save unused space.
      70f8d100
  6. 01 Apr, 2021 2 commits
    • Nate Graham's avatar
      Fix applet config window's Apply button · a6490f73
      Nate Graham authored
      It was looking at the wrong page in the stack.
      
      CCMAIL: notmart@gmail.com
      a6490f73
    • Marco Martin's avatar
      Use a normal config dialog look · 1debef9c
      Marco Martin authored
      Maintain the implementation with ApplicationItem and the breadcrumb toolbar,
      but make the dialog look like a normal config dialog again,
      consistent with apps config dialogs
      
      The sidebar is not in the pagerow, as is not part of the page navigation
      (and such never appear on the breadcrumb)
      
      Separator lines are present only iff the content don't fit and there is a scrollbar to make
      scrollbar look right and items to be clipped with a line instead of in the nothing
      1debef9c
  7. 20 Mar, 2021 1 commit
  8. 19 Nov, 2020 1 commit
    • Nicolas Fella's avatar
      Rework the plasmoid configuration dialog · 4afadec2
      Nicolas Fella authored
      We put a ScrollView/Flickable around the whole content. When we embed a KCM (like we do e.g. in plasma-pa) that comes with its own flickable this creates problems.
      This can be seen in the plasma-pa case where it's currently impossible to scroll and the scrollbar placement is wrong.
      
      Instead of having a StackView wrapped by a ScrollView we now have a Loader that can either load a KCM or an applet config (this includes shortcuts and about page).
      The applet config is wrapped in a Kirigami.ScrollablePage to allow scrolling if necessary.
      
      BUG: 426998
      4afadec2
  9. 25 Sep, 2020 1 commit
  10. 24 Sep, 2020 1 commit
  11. 31 Aug, 2020 1 commit
  12. 04 Aug, 2020 1 commit
    • David Redondo's avatar
      Add an about page to ConfigView · 8868bb83
      David Redondo authored
      This is a copy of AboutPage from Kirigami with the following changes:
      - Property names have been changed to match KPluginMetadata instead of KAboutData
      - The license text is in a Dialog instead of an OverlaySheet
      - Supports only one license because KPluginMetadata only supports one license
      - Dropped the part about Qt and KF versions
      BUG:357790
      8868bb83
  13. 05 Mar, 2020 1 commit
    • George Vogiatzis's avatar
      Fixes for applet configuration layout. · d6731530
      George Vogiatzis authored
      Summary:
      Fix applet configuration overlap with top line.
      Change the margins to move scrollbar so that it touches the edge.
      and use margins for content.
      Set content to use available width.
      Prevent vertical scrollbar from poping on/off internally.
      Change the layout so that categories column can get the full height.
      Remove 2 unused properties.
      Fix bind loop for pageFlickable's width.
      Fix title alignment for RTL.
      
      Test Plan:
      Open desktop and audio configurations and make windows small.
      Select audio category and move content to the top. (If there is no
      scrollbar, increase and decrease height to exploit bug.)
      
      Before:
      At the right side (the main) scrollbar will have a margin, and overlap
      with content.
      {F8129291}
      Desktop categories stop above buttons cancel, ok.
      {F8129294}
      Main content, and category highlight are displayed on top of the line.
      {F8127259, size=full}
      After:
      Scrollbar touch the edge, and the content has correct margin.
      {F8129296, layout=inline} {F8129306, layout=inline}
      Categories height is not limited.
      {F8130962, layout=inline} {F8130963, layout=inline} {F8130965, layout=inline}
      Main content ~~, and category highlight~~(restored, see photo above instead for highlight) touch the line below.
      {F8127260, size=full}
      
      Reviewers: #plasma, #vdg, filipf, ngraham
      
      Reviewed By: #vdg, filipf, ngraham
      
      Subscribers: ngraham, filipf, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D27608
      d6731530
  14. 17 Feb, 2020 1 commit
    • David Edmundson's avatar
      [desktoppackage] Fix layout when an applet has no custom config modules · 1123cc4d
      David Edmundson authored
      Summary:
      There was some broken code to hide the sidebar when we only have one
      module. However at some point it seems half was removed, half wasn't.
      
      This leads to the content overlapping the sidebar frame, but the sidebar
      was invisible and it looks generally broken.
      
      This patch completes the removal.
      
      BUG: 410770
      
      Test Plan:
      Opened touchpad KCM
      Saw the one module (keyboard shortcuts)
      Sidebar was visible, and nothing was overlapping
      
      Reviewers: ngraham
      
      Reviewed By: ngraham
      
      Subscribers: broulik, ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D27398
      1123cc4d
  15. 25 Jul, 2019 1 commit
    • Filip Fila's avatar
      Redesign QML applet configuration windows · 34ea1e73
      Filip Fila authored
      Summary:
      This patch updates the sidebar appearance of QML applet configuration windows by painting them with the view color and separating them from the rest of the content with Kirigami separators.
      
      Margins around actual category content have also been tweaked to be uniform.
      
      Test Plan:
      Screenshots are without window borders.
      
      Breeze:
      {F6800904}
      
      Breeze Light:
      {F6800906}
      
      Breeze Dark:
      {F6800907}
      
      Reviewers: #vdg, #plasma, ngraham, abetts
      
      Reviewed By: #vdg, ngraham
      
      Subscribers: mart, broulik, GB_2, hein, plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T11153, T11279
      
      Differential Revision: https://phabricator.kde.org/D20908
      34ea1e73
  16. 29 Apr, 2019 2 commits
  17. 24 Feb, 2019 1 commit
  18. 29 Nov, 2018 1 commit
    • Marco Martin's avatar
      Port applet/containment configs to qqc2 · c2640f83
      Marco Martin authored
      Summary:
      port the applet config dialogs and containments to
      QtQuickControls2 and Kirigami modernizing it,
      using form layouts, Headings and inline messages.
      look is almost the same modulo fixing some misalignments and following
      the hig more closely
      
      BUG: 401472
      FIXED-IN: 5.15.0
      
      Test Plan:
      looked at every wallpaper plugin and
      loaded the config dialog of many applets
      
      Reviewers: #plasma, #vdg, broulik, ngraham
      
      Reviewed By: #vdg, ngraham
      
      Subscribers: abetts, ngraham, apol, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D17211
      c2640f83
  19. 09 Nov, 2018 1 commit
  20. 27 Aug, 2018 1 commit
  21. 06 Dec, 2016 1 commit
  22. 06 Sep, 2016 1 commit
  23. 29 Aug, 2016 1 commit
    • Kai Uwe Broulik's avatar
      [Applet Configuration] Only scroll down if item is barely visible · a2777a1a
      Kai Uwe Broulik authored
      The logic for scrolling a focus item into view was mostly meant for keyboard-navigating through
      a list of CheckBoxes. However, an inner ScrollView - like plasma-pa has in its config dialog - can
      also gain activeFocus. This had us try to scroll the ScrollView into view, usually scrolling away
      other view contents.
      
      With the added logic we only try to scroll if the control is barely visible at the bottom but
      not if significant portions of it are already visible.
      
      Differential Revision: https://phabricator.kde.org/D2585
      a2777a1a
  24. 11 Aug, 2016 1 commit
    • Kai Uwe Broulik's avatar
      [Applet Configuration] Match category sidebar style with Breeze widget default style · 817b27f4
      Kai Uwe Broulik authored
      This adjusts the category sidebar to look like the default Breeze widget style.
      The width of the sidebar also adjusts (up to a certain maximum width) based on
      the labels within so it doesn't grow as wide anymore.
      Moreover, keyboard navigation is greatly improved by indicating focus on the category
      sidebar and changing categories with arrow keys. Also, when tabbing through the dialog,
      the view is scrolled, if the item with focus would otherwise be inaccessible.
      
      As Plasma doesn't seem to be supporting Qt high-dpi scaling anytime soon this uses
      units to get the sizing identical to what it looks like in the other applications.
      
      Differential Revision: https://phabricator.kde.org/D2398
      817b27f4
  25. 30 Jun, 2016 1 commit
  26. 06 Apr, 2016 2 commits
  27. 11 Feb, 2016 1 commit
  28. 19 Jan, 2016 1 commit
  29. 30 Aug, 2015 1 commit
    • David Kahles's avatar
      Revert "[Appletconfiguration] Prevent binding loop in main stackview" · 2eb6d514
      David Kahles authored
      This reverts commit b90a8f63 because it
      broke the wallpaper configuration.
      
      quoting David Edmundson explaining the old behavior:
      
      What the code was doing before:
       height is either:
         the size of the child items
         filling up all the way to the buttons at the bottom of the dialog
      
      The problem it's trying to solve is we sometimes have content of
      variable height in a scrollview; which needs to know the content height.
      This is a bit of a loop logically.
      2eb6d514
  30. 27 Aug, 2015 1 commit
    • David Kahles's avatar
      [Appletconfiguration] Prevent binding loop in main stackview · b90a8f63
      David Kahles authored
      Calculate the height of the stackview without using the viewport height
      to prevent a binding loop, because te viewportheight changes when the
      stackviewheight changes. Thus, the height of the main stackview could
      not be reduced but only increased.
      b90a8f63
  31. 13 Jul, 2015 1 commit
  32. 08 May, 2015 1 commit
    • Marco Martin's avatar
      capability to load QML kcms in plasmoid config windows · f98326ac
      Marco Martin authored
      With the same mechanism as plasma 1, add the possibility to load kcms directly
       in the plasmoids config windows. this works only for qml based ones.
      the apply enable and trigger is correctly wired between the config
       dialog and kcm apis.
      
      REVIEW:123673
      f98326ac
  33. 21 Apr, 2015 2 commits
  34. 03 Apr, 2015 1 commit
    • Marco Martin's avatar
      move window on drag on empty areas · a4368a25
      Marco Martin authored
      like in qwidgets, drag the window around from any empty areas
      that doesn't have buttons or other items that can be interacted with the mouse
      a4368a25
  35. 02 Apr, 2015 1 commit
  36. 27 Feb, 2015 1 commit