1. 26 Feb, 2017 1 commit
  2. 24 Feb, 2017 1 commit
    • David Edmundson's avatar
      Avoid capturing MenuItem instead determine checked state from toggled signal · e5df3ded
      David Edmundson authored
      Summary:
      Due to JS lambdas menuItem is being captured by reference, and as such
      the call to menuItem.checked returns the checked state of the last item
      in the for loop. Instead of adding to the capture this patch uses the
      supplied boolean from the QMenuItem::toggled signal.
      
      Also unlike Array.concat Array.splice alters the current array, we don't
      want to create a new var.
      
      BUG: 376826
      
      Test Plan:
      Debug of menuItem.text showed we were capturing the wrong thing
      Clicked window into multiple activities and unticked them. All worked as intended
      
      Reviewers: #plasma
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D4757
      e5df3ded
  3. 23 Feb, 2017 1 commit
  4. 22 Feb, 2017 5 commits
  5. 21 Feb, 2017 1 commit
  6. 20 Feb, 2017 5 commits
  7. 19 Feb, 2017 2 commits
  8. 17 Feb, 2017 1 commit
  9. 16 Feb, 2017 5 commits
  10. 15 Feb, 2017 2 commits
  11. 14 Feb, 2017 1 commit
  12. 13 Feb, 2017 5 commits
  13. 12 Feb, 2017 4 commits
  14. 11 Feb, 2017 6 commits