1. 12 Jun, 2020 2 commits
    • Nate Graham's avatar
      Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it · 86329ca1
      Nate Graham authored
      Summary:
      This patch implements the part of T12441 that was virtually universally agreed-to:
      switching out the regular Task Manager for an Icons-Only Task Manager and pinning
      some apps by default. The panel is also thickened to to 46px (with the default font,
      since the calculation is based on GridUnits, which are font-aware). The panel remains
      in its current position pending further discussion about whether or not we want to
      move it to the left edge.
      
      Ideally I'd like for this patch to used for discussions about the implementation, not the
      general concept, so if you have concerns about that, please put them in T12441.
      
      Test Plan: This is now the default panel: {F8290193}
      
      Reviewers: #vdg, #plasma, niccolove, cblack
      
      Reviewed By: #vdg, #plasma, niccolove, cblack
      
      Subscribers: rikmills, mart, filipf, kmaterka, gvgeo, davidedmundson, ndavis, niccolove, The-Feren-OS-Dev, plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T12441
      
      Differential Revision: https://phabricator.kde.org/D27845
      86329ca1
    • Nate Graham's avatar
      Add a SpinBox (with draggability) to panel thickness adjustment UI · 876eedfb
      Nate Graham authored
      Summary:
      We receive many complaints and bug reports about the current UI for adjusting panel
      thickness. People don't figure out that they have to drag on the button, and when they do,
      they complain that it's too hard to set the value finely enough.
      
      This patch removes the draggable button and replaces it with a more conventional SpinBox,
      which in D29534 is given ability to adjust the values by scrolling over it or clicking and
      dragging. This yields the following improvements:
      - The way you adjust panel thickness is now more obvious
      - The existing drag-to-adjust behavior is much nicer and less buggy
      - Panel thickness can now be specified numerically
      - Fine-tuning panel thickness is now easier using any adjustment method
      - We have one fewer custom control to maintain
      - Bugs in custom scrolling implementation go away
      
      Touch friendliness is maintained because this SpinBox has an inherently touch-friendly design
      with large touchable buttons that can be held down to quickly adjust the value, and touch-and
      -drag still works after D29534 is applied.
      
      I wouldn't mind using this SpinBox design elsewhere too; see T9460.
      
      BUG: 418700
      BUG: 421169
      FIXED-IN: 5.19
      
      Test Plan:
      {F8301480}
      {F8301388}
      
      Reviewers: abetts, #vdg, #plasma, mart
      
      Reviewed By: #vdg, #plasma, mart
      
      Subscribers: mart, ahiemstra, cblack, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D29535
      876eedfb
  2. 11 Jun, 2020 6 commits
  3. 10 Jun, 2020 1 commit
  4. 09 Jun, 2020 2 commits
  5. 08 Jun, 2020 3 commits
    • Adriaan de Groot's avatar
      Avoid deprecated API · 845585d9
      Adriaan de Groot authored
      - setupBindings() was deprecated in 5.45, plasma-desktop requires 5.71
      - follow the suggested KDeclarative replacement of setupBindings()
      845585d9
    • Adriaan de Groot's avatar
      Avoid unused-member warnings in WindowModel::Private · e65c30d3
      Adriaan de Groot authored
      - The q-pointer isn't used right now, so Clang complains about it;
        removing it is an option, but then we might get surprising ping-pongs
        if more functionality is added to the private class. Use Q_UNUSED instead.
      e65c30d3
    • Adriaan de Groot's avatar
      Handle absent <crypt.h> · 3df00f81
      Adriaan de Groot authored
      The prototype for crypt(3) is in <unistd.h> on Linux and FreeBSD.
      The <crypt.h> header isn't needed at all. There's also machinery
      for detecting the presence of <crypt.h>, defining HAVE_CRYPT_H,
      but we don't need that.
      
      Reported and resolved independently in
      	https://phabricator.kde.org/D29847
      
      @nicofe tested that this works on Linux
      @adridg tested that this works on FreeBSD
      3df00f81
  6. 07 Jun, 2020 4 commits
    • Adriaan de Groot's avatar
      Normalize include-quotes · 59317865
      Adriaan de Groot authored
      - from local directory, use "" (esp. the header file for this .cpp)
      59317865
    • Adriaan de Groot's avatar
      Correct salting array: · bdca8c01
      Adriaan de Groot authored
      - Missing letter "w" and "W" in list of characters meant only 62
        letters, so less than 6 bits of randomness per salt char.
      - A char array like this one still has a trailing NUL char which
        affects the sizeof. Since bounded produces a number < its second
        argument, need to discount the NUL so we only index into
        the letters-part of the string.
      
      Add static_assert() to catch this.
      bdca8c01
    • Adriaan de Groot's avatar
      Sanitize saltCharacter() · 6b822924
      Adriaan de Groot authored
       - the array of salt chars should be const, it's read-only
       - the array of salt chars should be static, since it is
         initialized to a constant value anyway and can live beyond
         this one function
       - sizeof(char) is 1 by the standard, so remove the weird
         array-size calculation: here saltCharacters has type
         (const) char[63], and its sizeof() is 63
      6b822924
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 3be70eda
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      3be70eda
  7. 05 Jun, 2020 4 commits
  8. 04 Jun, 2020 5 commits
    • Giusy Margarita's avatar
      Increase values for touchpad acceleration that can be set from kcm libinput UI · ead253cc
      Giusy Margarita authored
      Summary:
      Plasma System settings can set only 11 values for touchpad acceleration. The option accept a float number between -1 and 1 but, because of the slider limitation, only 11 values in between multiple of 0,2 con be set.
      
      I think this is a great limitation since some touchpad models need specific values to give the user the proper comfort in handling the pointer. Libinput has already less options than the old synaptic, at least let's give the user the ability to set the acceleration with more precision.
      
      In example, the best value for my touchpad is 0,15, but I can't set it, and even if 0,2 is the nearest, I feel better with 0,15 and want to set it. Unfortunately I can't from the kcm UI and I have to modify //~/.config/touchpadxlibinputrc// config manually. I think this is unacceptable for a DE like Plasma that claims to be highly customizable.
      
      So, in order to increase values that can be set with the slider, I suggest to modify the formula in //touchpad.qml// to pick 41 values in the middle, multiple of 0,05.
      
      Reviewers: #vdg, #plasma, ngraham
      
      Reviewed By: #vdg, ngraham
      
      Subscribers: ndavis, ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D29365
      ead253cc
    • Friedrich W. H. Kossebau's avatar
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · a949c9f3
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      a949c9f3
    • Noah Davis's avatar
      [Colors KCM] Support Header ColorSet · 1a1b5549
      Noah Davis authored
      1a1b5549
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 008fedae
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      008fedae
  9. 03 Jun, 2020 5 commits
  10. 02 Jun, 2020 1 commit
  11. 01 Jun, 2020 2 commits
  12. 31 May, 2020 1 commit
  13. 29 May, 2020 1 commit
  14. 28 May, 2020 3 commits