1. 17 May, 2018 3 commits
    • David Edmundson's avatar
      Don't disable apply button when window is resized · 86dd0c2e
      David Edmundson authored
      Summary:
      Before this patch if I edit an option, and then resize the window the
      apply button became disabled.
      
      I'm not sure what this was trying to do, but widget size and whether
      we have changes to save seems very unrelated.
      
      Test Plan: Tested as above, no longer have the bug
      
      Reviewers: #plasma, apol
      
      Reviewed By: apol
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D12943
      86dd0c2e
    • Furkan Tokac's avatar
      Rewrite workspace KCM in QtQuick · 856f5895
      Furkan Tokac authored
      Summary:
      This patch renews the System Settings -> Desktop Behaviour -> Workspace.
      
      Basically it is rewritten in QML, ConfigModule. Also, its naming has been
      changed. It was called as kcm_workspaceoptions and workspaceoptions before
      but now, it is kcm_workspace like other renewed KCMs' names.
      
      Currently, ToolTip and VisualFeedback working fine. All the functionalities
      are tested. "Default", "Reset" buttons works like a charm.
      
      {F5852481}
      
      Reviewers: romangg, ngraham, #plasma
      
      Reviewed By: romangg, #plasma
      
      Subscribers: zzag, davidedmundson, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D12936
      856f5895
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 81137680
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      81137680
  2. 16 May, 2018 1 commit
  3. 15 May, 2018 2 commits
  4. 14 May, 2018 3 commits
    • Алексей Шилин's avatar
      Remove D10890 workaround · ada8fca9
      Алексей Шилин authored
      Summary:
      D10890 was a workaround related to KRecentDocument::add() bug (see D10863)
      which is fixed in Frameworks 5.46. Given that Plasma 5.13 depends on that
      Frameworks version, it's safe to remove this no longer needed workaround
      without breaking anything.
      
      Reviewers: #plasma, broulik, hein
      
      Reviewed By: #plasma, hein
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D12701
      ada8fca9
    • Kai Uwe Broulik's avatar
    • Eike Hein's avatar
      Port Language KCM to Qt Quick · 6055cfb9
      Eike Hein authored
      Summary:
      * Changed the overall design from two lists to one list with a modal
        sheet to add more languages.
      * Replaced a modal "You need to relogin for changes" dialog with a
        MessageType.Positive InlineMessage.
      * Reworked the way missing languages are handled: The old KCM silently
        rewrote config and showed a warning. The new design shows an
        informative warning and removes the missing languages on the next
        save. Until then they're flagged as missing in the list.
      * Manages Apply button state correctly (or rather at all ...).
      
      This depends on D12097.
      
      This implements T7247.
      
      This is currently not final code. It's a WIP upload to give Marco
      something to work with to fix various Kirigami and SimpleKCM problems.
      
      Currently known issues:
      * Does not save (code is from old KCM, might have been broken there)
      * Disabled SwipeListItem actions do not show disabled
      * Placement of actions button in SwipeListItem is wonky if the
        contentItem is a RowLayout
      * SwipeListItem spews errors about positionAnimation after using an
        action
      * SwipeListItem is awkward to use, we need a drag-reorderable list
        delegate
      * OverlaySheet spews numerous warnings about not being able to find
        applicationWindow and activeFocusItem
      * The sheet is parented to the SimpleKCM's parent since there's no
        app window to be modal too
      * The footer inside an OverlaySheet sometimes moves up above the
        content instead of staying down
      * Even though SimpleKCM is just a Kirigami.ScrollablePage like
        Kirigami Gallery pages, an InlineMessage that fills the page width
        gets cut off on the left and right, so wonky code to insert margins
        next to them
      * List has window bg color as background instead of view background
        color
      
      Reviewers: #kirigami, mart
      
      Subscribers: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, plasma-devel
      
      Tags: #plasma, #kirigami
      
      Differential Revision: https://phabricator.kde.org/D12102
      6055cfb9
  5. 11 May, 2018 2 commits
  6. 10 May, 2018 1 commit
  7. 08 May, 2018 1 commit
  8. 06 May, 2018 1 commit
  9. 03 May, 2018 3 commits
  10. 02 May, 2018 3 commits
  11. 01 May, 2018 1 commit
  12. 30 Apr, 2018 1 commit
  13. 29 Apr, 2018 2 commits
  14. 28 Apr, 2018 1 commit
  15. 27 Apr, 2018 2 commits
    • Kai Uwe Broulik's avatar
      [Icon KCM] Port to new design · 9496728f
      Kai Uwe Broulik authored
      This completely drops the icon customization with icon effects and only retains the icon size settings.
      Should there be any custom icon effects, pressing "Defaults" in the KCM will remove them.
      I also couldn't find any trace of that "animations enabled" check box it used to have.
      It adds drag and drop support for installing archives as themes. It can also download them from remote location
      when dropped from e.g. a browser.
      
      Installing theme files actually never worked in Plasma 5 as it got broken in the port from KIO NetAccess
      to storedGet.
      An animated preview is also added on hover showing a common selection of icons.
      
      Implements T7262
      
      BUG: 367619
      BUG: 334301
      CCBUG: 163992
      FIXED-IN: 5.13.0
      
      Differential Revision: https://phabricator.kde.org/D12459
      9496728f
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 9961a720
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      9961a720
  16. 26 Apr, 2018 1 commit
  17. 25 Apr, 2018 6 commits
  18. 24 Apr, 2018 6 commits