- 03 Sep, 2018 1 commit
-
-
Jonathan Esk-Riddell authored
QT_MIN_VERSIONS is Qt 5.11 for Plasma 5.14. Agreed at kickoff meeting. Set everywhere for clearity and consistency.
-
- 28 Aug, 2018 1 commit
-
-
Nate Graham authored
Summary: Most Plasma widgets and apps that have search fields show them by default. Two exceptions are Kickoff and Widget Explorer (for background, see D15011#315779). Kickoff is being addressed in D15011. That would leave Widget Explorer as the only case in Plasma (that I could find) where a search field invisibly has keyboard focus and appears when you start typing, but is not actually visible until then. This patch changes that by making the search field always visible, matching everything else in Plasma. Thanks to @sharvey for doing most of the work already to move the Search Field to its own row in the layout. This patch simply makes it always visible and removes the {nav Search} button that shows and hides it. Test Plan: {F6218550} Reviewers: sharvey, #vdg, abetts, #plasma, davidedmundson Reviewed By: sharvey, #vdg, abetts, #plasma, davidedmundson Subscribers: abetts, sharvey, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D15101
-
- 27 Aug, 2018 3 commits
-
-
Yuri Chornoivan authored
-
Scott Harvey authored
Summary: Move search to its own row to prevent it from being compressed BUG: 393427 Test Plan: - Recompile `plasma-desktop` - Bring up Widget Explorer - Press {nav Search} to see Search in new row - Select widget type category to see Title become elided Reviewers: ngraham, davidedmundson, #plasma Reviewed By: ngraham, davidedmundson, #plasma Subscribers: abetts, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D12855
-
Script Kiddy authored
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
-
- 23 Aug, 2018 3 commits
-
-
Kai Uwe Broulik authored
-
Kai Uwe Broulik authored
Plasma-integration's KHintsSettings keeps kdeglobals open, so we need to explicitly sync() before we go through the process of telling everything it's changed Differential Revision: https://phabricator.kde.org/D14672
-
Kai Uwe Broulik authored
Makes it consistent with other places where such an entry exists, such as Dolphin's context menu Differential Revision: https://phabricator.kde.org/D15018
-
- 20 Aug, 2018 3 commits
-
-
David Edmundson authored
-
David Edmundson authored
-
David Edmundson authored
This reverts commit 1cb71a2c. Causes breakages, needs further investigation
-
- 17 Aug, 2018 1 commit
-
-
Script Kiddy authored
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
-
- 16 Aug, 2018 4 commits
-
-
Albert Astals Cid authored
-
Albert Astals Cid authored
BUGS: 397206 Reviewers: hein Reviewed By: hein Subscribers: ngraham, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D14836
-
Script Kiddy authored
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
-
Script Kiddy authored
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
-
- 15 Aug, 2018 3 commits
-
-
Script Kiddy authored
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
-
Script Kiddy authored
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
-
Script Kiddy authored
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
-
- 11 Aug, 2018 3 commits
-
-
Kai Uwe Broulik authored
-
Kai Uwe Broulik authored
-
Kai Uwe Broulik authored
BUG: 397358 FIXED-IN: 5.12.7 Differential Revision: https://phabricator.kde.org/D14746
-
- 08 Aug, 2018 2 commits
-
-
Kai Uwe Broulik authored
Return rowCount of 0 for sub items Differential Revision: https://phabricator.kde.org/D14488
-
Kai Uwe Broulik authored
Makes it consistent with other places where such an entry exists, such as Dolphin's context menu Differential Revision: https://phabricator.kde.org/D14671
-
- 07 Aug, 2018 1 commit
-
-
Kai Uwe Broulik authored
For KCMs we get a relative entryPath() for our KService resulting in an invalid URL being created. BUG: 397070 FIXED-IN: 5.14.0 Differential Revision: https://phabricator.kde.org/D14647
-
- 06 Aug, 2018 1 commit
-
-
Shubham . authored
Reviewers: jgrulich, hein, abetts Reviewed By: hein Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D14652
-
- 03 Aug, 2018 1 commit
-
-
Script Kiddy authored
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
-
- 02 Aug, 2018 3 commits
-
-
Mathias Tillman authored
-
Mathias Tillman authored
-
Mathias Tillman authored
Summary: As the summary says, when installing/removing multiple fonts to system the expected behaviour would be for fontinst to keep running after the first font has been installed or removed, instead it quits which causes a bunch of issues. fontinst uses KJob to authorize and internally KJob uses a QEventLoopLocker which causes the main event loop to quit when it's done. I'm not entirely sure why the event loop locker is enabled by default for KJob, but the patch I have attached works around this by completely disabling that functionality for fontinst. There's a timer that runs in the background which checks for any connected clients, so it will quit after a little while regardless. BUG: 379524 BUG: 379324 BUG: 349673 BUG: 361960 BUG: 392267 Test Plan: Make sure fonts are still installed and removed properly. Reviewers: #plasma, dfaure, aacid, gateau Reviewed By: dfaure Subscribers: wbauer, ngraham, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D14493 (cherry picked from commit 60c89575)
-
- 01 Aug, 2018 6 commits
-
-
Kai Uwe Broulik authored
-
Kai Uwe Broulik authored
-
Kai Uwe Broulik authored
The toolbox shows containment-specific actions, just like the desktop contextmenu does. The containment may update or creates its actions on-demand leading to outdated actions showing up in the toolbox. BUG: 384862 FIXED-IN: 5.12.7 Differential Revision: https://phabricator.kde.org/D14535
-
Eike Hein authored
-
Eike Hein authored
-
Eike Hein authored
Summary: Don't change the proxy maps prior to insert/remove transactions so rowCount() at transaction start time matches the count passed into the method. The old code hits an ASSERT in Qt 5.11 otherwise. Care is taken not to emit dataChanged() in the middle of another transaction. Also cleaned up vestiges of caching lastRow(): This cache was evicted all over the places but never actually filled anymore, so maybe we don't need it. BUG:396666 Reviewers: davidedmundson Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D14243
-
- 31 Jul, 2018 2 commits
-
-
Jonathan Esk-Riddell authored
GIT_SILENT
-
Mathias Tillman authored
Summary: As the summary says, when installing/removing multiple fonts to system the expected behaviour would be for fontinst to keep running after the first font has been installed or removed, instead it quits which causes a bunch of issues. fontinst uses KJob to authorize and internally KJob uses a QEventLoopLocker which causes the main event loop to quit when it's done. I'm not entirely sure why the event loop locker is enabled by default for KJob, but the patch I have attached works around this by completely disabling that functionality for fontinst. There's a timer that runs in the background which checks for any connected clients, so it will quit after a little while regardless. BUG: 379524 BUG: 379324 BUG: 349673 BUG: 361960 BUG: 392267 Test Plan: Make sure fonts are still installed and removed properly. Reviewers: #plasma, dfaure, aacid, gateau Reviewed By: dfaure Subscribers: wbauer, ngraham, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D14493
-
- 30 Jul, 2018 2 commits
-
-
Julian Wolff authored
-
Julian Wolff authored
Summary: Font rendering settings are changed temporarily to render preview images. The changed settings were reverted, but never reapplied. This way rendering preview images could alter the user's font rendering configuration. Reviewers: ngraham Reviewed By: ngraham Subscribers: ngraham, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D14480
-