GitLab

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

This way we write to the same shared config instance as e.g. krdb and when we sync() it then also reads the current values.

CHANGELOG: Fixed font antialiasing and hinting settings not correctly saving

Differential Revision: https://phabricator.kde.org/D24562

Summary: Closes T7271

Reviewers: #plasma, mart, ngraham

Reviewed By: #plasma, mart, ngraham

Subscribers: GB_2, nicolasfella, mart, ngraham, plasma-devel

Tags: #plasma

Maniphest Tasks: T7271

Differential Revision: https://phabricator.kde.org/D23718

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

GIT_SILENT

This reverts commit 70bdf216.

This reverts commit 704555a5.

GIT_SILENT

GIT_SILENT

Summary: 1.5 was first released in July 2014, I don't see why keep it around.

Test Plan: Still builds

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24414

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary: If we're showing the icons in a horizontal layout, the < and > buttons feel like it should be selecting instead of switching pages.

Test Plan:
Tested locally

{F7514919}

{F7514920}

Reviewers: #plasma, ngraham

Reviewed By: ngraham

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24408

Summary:
This simplifies quite a bit the logic, we don't need to do the
bookkeeping ourselves anymore. Only missing would be a "isDirty" flag on
the settings object which explains the m_currentTheme member variable
which is still around to have something to compare against in
updateNeedsSave().

Reviewers: #plasma, mart

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24394

Summary:
It provides some improvements at least: first in code reuse, but also it
cleans up the config file behind itself when we get back to the default
value.

Reviewers: #plasma, mart

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24393

Summary:
The module had a somewhat convoluted logic around the management of its
settings. Sometimes it was reading through Plasma::Theme (mostly
proxying in some form what was in the config), sometimes straight from
KConfig. We now got rid of m_defaultTheme to avoid the temptation of
reading from it, KConfig is our only source of settings.

We kept a single call to Plasma::Theme on save, but that's simply to
ensure proper signalling of the change to the running shell.

Reviewers: #plasma, mart

Reviewed By: #plasma, mart

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24392

Reviewers: #plasma, mart

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24391

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Especially the TypeRole can be quite heavy.

Differential Revision: https://phabricator.kde.org/D23675

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
The button grid was not centered, the content inside the buttons was not centered, the
vertical spacing was too high on top and too low on bottom, and the explanatory text
got cut off.

This patch solves all those problems.

Big thanks to @davidedmundson for his help getting this merge-ready.

BUG: 409957
FIXED-IN: 5.17.0

Test Plan:
Before: {F7247447, size=full}
After: {F7247446, size=full}

Reviewers: #vdg, #plasma, davidedmundson, GB_2, hein

Reviewed By: #vdg, #plasma, davidedmundson, GB_2

Subscribers: hein, GB_2, davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D23158

Summary:
This way the panel toolbox isn't always visible, because with D23951 we're basically always in unlocked mode.

Depends on D24239

Test Plan: Open the desktop toolbox and then the panel toolbox.

Reviewers: #plasma, #vdg, ngraham, mart

Reviewed By: #plasma, #vdg, ngraham, mart

Subscribers: mart, plasma-devel, #vdg, #plasma

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24246

Summary: {F7431292}

Test Plan: Open the desktop configuration dialog.

Reviewers: #plasma, #vdg, ngraham

Reviewed By: #vdg, ngraham

Subscribers: plasma-devel, #vdg, #plasma

Tags: #plasma

Maniphest Tasks: T10165

Differential Revision: https://phabricator.kde.org/D24228

Summary:
Introduce a new config entry into kdeglobals AnimationSpeed that will
control /all/ animation speeds in kwin and plasma themes and Qt styles
and kirigami.

The value stored is a multiplier.
i.e 1 == normal speed, 0.5 = twice as fast, 2 = twice as slow.
0 is a special value meaning "disable animations"

The QML is a bit complex to represent a logarithmic slider that goes
4x, 2x, 1x, 0.5x, 0.25x, 0.125x

but still allowing a user to type arbitrary values into their config

Test Plan: Looked at config

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: ngraham, GB_2, broulik, anthonyfieroni, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D22885

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"