1. 23 Jul, 2018 2 commits
  2. 21 Jul, 2018 1 commit
  3. 20 Jul, 2018 4 commits
    • Nate Graham's avatar
      Show a vertical menu for the panel widget options pop-up · 9adb94dc
      Nate Graham authored
      Summary:
      This patch replaces the UI for the panel widget options pop-up with a vertical menu, replating the current horizontal bar with icons on either side of a label. This yields the following improvements:
      - Bigger hit areas; easier to click and much more touch-friendly
      - Buttons have text labels; easier to tell what they do
      - Fewer changes of direction required when mousing; it's possible to access all actions with only vertical motions
      
      Test Plan:
      All buttons still work.
      
      Before:
      {F6108835}
      
      After:
      {F6112474}
      
      Reviewers: #plasma, broulik
      
      Reviewed By: #plasma, broulik
      
      Subscribers: gregormi, abetts, broulik, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D14145
      9adb94dc
    • Kai Uwe Broulik's avatar
      Merge branch 'Plasma/5.13' · f6b55d5d
      Kai Uwe Broulik authored
      f6b55d5d
    • Kai Uwe Broulik's avatar
      6bec0944
    • Kai Uwe Broulik's avatar
      [Folder View] Improve file name text rendering · 5fca2b32
      Kai Uwe Broulik authored
      GridView pads out its delegate to ensure a uniform grid. This, however, causes items to be placed on fractional pixels,
      leading to blurry rendering and uneven hinting.
      Instead of adjusting padding calculation to return whole pixels, which will again cause a gap at the right side of the screen,
      since there's 20 icons in a row, slightly shift the delegate contents to move them back to whole pixels.
      Moreover, DropShadow renders the entire item with a drop shadow, so keeping the Label visible results in two labels ontop of
      each other leading to bolder text.
      
      Differential Revision: https://phabricator.kde.org/D14234
      5fca2b32
  4. 18 Jul, 2018 2 commits
    • Nate Graham's avatar
      Give file and folder names a bit more room in Folder View · 02dadc40
      Nate Graham authored and Nate Graham's avatar Nate Graham committed
      Summary:
      Slightly decrease the side margins within Folder View delegates, to give titles a tiny bit more room. This very slightly improves things for people who have desktop files with multi-line titles.
      
      CCBUG: 379432
      
      Test Plan:
      Before, normal-sized icons:
      {F5755097}
      
      After, normal-sized icons:
      {F5755128}
      
      Before: small icons:
      {F5755102}
      
      After, small icons:
      {F5755127}
      
      Reviewers: hein, #plasma
      
      Reviewed By: hein, #plasma
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D11358
      02dadc40
    • Robert Hoffmann's avatar
      Fix drop between shared views · cab9078e
      Robert Hoffmann authored and Nate Graham's avatar Nate Graham committed
      Summary:
      Remove trailing slash from folderUrl, too, when comparing to
      the file's url (minus file name minus trailing slash). FolderUrls
      like file:///home/user/Desktop/ may appear and fail comparing.
      
      Fixes regression introduced in 07001277
      (see https://phabricator.kde.org/D10729) which fixes urls like
      file:///home/user/foo (if using a different folder than Desktop)
      but breaks moving files from one screen to another using normal
      Desktop folder.
      
      Test Plan:
      1. Use folder view, Desktop folder, more than one screen.
      Create files and folders in Desktop folder and move them from one
      screen to another. The Copy/Move/Link menu must not appear
      and files/folders must be dropped onto the other screen.
      
      2. Use a different folder than Desktop (the same on both screens).
      Moving files/folders to another screen must work like in 1.
      
      Reviewers: mart
      
      Reviewed By: mart
      
      Subscribers: amantia, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D13612
      cab9078e
  5. 17 Jul, 2018 4 commits
    • David Edmundson's avatar
      Fix blur behind folderview context menus · 42a74c9a
      David Edmundson authored
      Summary:
      Breeze has
      
      if (!(widget->testAttribute(Qt::WA_WState_Created) ||
      widget->internalWinId()))
         KWindowSystem::blur(widget->winId(), ...)
      
      which makes sense as the style should not be creating surfaces in polish
      and I don't want to remove it.
      
      This is problematic with QMenu::polish which has a subtle behavioural
      change compared to QMenu::exec in that it calls ensurePolish before
      creating the surface.
      
      Plasma::ContainmentInterface accidentally has this workaround already
      for parent window setting.
      
      BUG: 395262
      
      Test Plan:
      Right clicked on desktop icon
      Looked amazing
      
      Reviewers: #plasma, hein
      
      Reviewed By: #plasma, hein
      
      Subscribers: hein, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D14174
      42a74c9a
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · e2acbba5
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      e2acbba5
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · ec4465f2
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      ec4465f2
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 6991252c
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      6991252c
  6. 16 Jul, 2018 1 commit
  7. 15 Jul, 2018 2 commits
    • Nate Graham's avatar
      Use a trash icon for anything that will remove a widget or a panel · 1f87cec5
      Nate Graham authored
      Summary: Like D14116, but for the remaining uses of inappropriate close icons for buttons that will remove widgets or panels. We change those to trash icons to make it clear what will happen.
      
      Test Plan:
      {F6108237}
      
      {F6108236}
      
      Reviewers: broulik, #plasma
      
      Reviewed By: broulik, #plasma
      
      Subscribers: gregormi, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D14138
      1f87cec5
    • Nate Graham's avatar
      Use a better icon for "Remove" on the widget handle · b00ef00b
      Nate Graham authored
      Summary:
      I often find myself clicking the widget handle's {nav Remove} button and accidentally removing the widget itself when I'm just trying to hide the handle, because the button's current icon communicates "close this thing" better than "delete this thing". By switching it to a trash icon, we communicate its true meaning better and it becomes clear that the button will remove the widget.
      
      This also brings that icon into consistency with the icon used in the context menu's {nav Remove this [widget]} entry.
      
      Test Plan: {F6104676}
      
      Reviewers: #plasma, #vdg, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: gregormi, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D14116
      b00ef00b
  8. 13 Jul, 2018 2 commits
  9. 12 Jul, 2018 3 commits
  10. 11 Jul, 2018 8 commits
  11. 10 Jul, 2018 1 commit
  12. 09 Jul, 2018 7 commits
  13. 07 Jul, 2018 3 commits