Summary:
This patch replaces the UI for the panel widget options pop-up with a vertical menu, replating the current horizontal bar with icons on either side of a label. This yields the following improvements:
- Bigger hit areas; easier to click and much more touch-friendly
- Buttons have text labels; easier to tell what they do
- Fewer changes of direction required when mousing; it's possible to access all actions with only vertical motions

Test Plan:
All buttons still work.

Before:
{F6108835}

After:
{F6112474}

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: gregormi, abetts, broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14145

GridView pads out its delegate to ensure a uniform grid. This, however, causes items to be placed on fractional pixels,
leading to blurry rendering and uneven hinting.
Instead of adjusting padding calculation to return whole pixels, which will again cause a gap at the right side of the screen,
since there's 20 icons in a row, slightly shift the delegate contents to move them back to whole pixels.
Moreover, DropShadow renders the entire item with a drop shadow, so keeping the Label visible results in two labels ontop of
each other leading to bolder text.

Differential Revision: https://phabricator.kde.org/D14234

Nate Graham authored Mar 15, 2018 and Nate Graham committed Jul 18, 2018

Summary:
Slightly decrease the side margins within Folder View delegates, to give titles a tiny bit more room. This very slightly improves things for people who have desktop files with multi-line titles.

CCBUG: 379432

Test Plan:
Before, normal-sized icons:
{F5755097}

After, normal-sized icons:
{F5755128}

Before: small icons:
{F5755102}

After, small icons:
{F5755127}

Reviewers: hein, #plasma

Reviewed By: hein, #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D11358

Robert Hoffmann authored Jul 18, 2018 and Nate Graham committed Jul 18, 2018

Summary:
Remove trailing slash from folderUrl, too, when comparing to
the file's url (minus file name minus trailing slash). FolderUrls
like file:///home/user/Desktop/ may appear and fail comparing.

Fixes regression introduced in 07001277
(see https://phabricator.kde.org/D10729) which fixes urls like
file:///home/user/foo (if using a different folder than Desktop)
but breaks moving files from one screen to another using normal
Desktop folder.

Test Plan:
1. Use folder view, Desktop folder, more than one screen.
Create files and folders in Desktop folder and move them from one
screen to another. The Copy/Move/Link menu must not appear
and files/folders must be dropped onto the other screen.

2. Use a different folder than Desktop (the same on both screens).
Moving files/folders to another screen must work like in 1.

Reviewers: mart

Reviewed By: mart

Subscribers: amantia, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D13612

Summary:
Breeze has

if (!(widget->testAttribute(Qt::WA_WState_Created) ||
widget->internalWinId()))
   KWindowSystem::blur(widget->winId(), ...)

which makes sense as the style should not be creating surfaces in polish
and I don't want to remove it.

This is problematic with QMenu::polish which has a subtle behavioural
change compared to QMenu::exec in that it calls ensurePolish before
creating the surface.

Plasma::ContainmentInterface accidentally has this workaround already
for parent window setting.

BUG: 395262

Test Plan:
Right clicked on desktop icon
Looked amazing

Reviewers: #plasma, hein

Reviewed By: #plasma, hein

Subscribers: hein, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14174

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary: If there is only one visible window on the virtual desktop show the title directly instead of "1 Window" + one-entry list.

Test Plan:
Before:
{F6069186}

After:
{F6069189}

Reviewers: hein, broulik, ngraham

Reviewed By: hein, ngraham

Subscribers: mart, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14026

Summary: Like D14116, but for the remaining uses of inappropriate close icons for buttons that will remove widgets or panels. We change those to trash icons to make it clear what will happen.

Test Plan:
{F6108237}

{F6108236}

Reviewers: broulik, #plasma

Reviewed By: broulik, #plasma

Subscribers: gregormi, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14138

Summary:
I often find myself clicking the widget handle's {nav Remove} button and accidentally removing the widget itself when I'm just trying to hide the handle, because the button's current icon communicates "close this thing" better than "delete this thing". By switching it to a trash icon, we communicate its true meaning better and it becomes clear that the button will remove the widget.

This also brings that icon into consistency with the icon used in the context menu's {nav Remove this [widget]} entry.

Test Plan: {F6104676}

Reviewers: #plasma, #vdg, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: gregormi, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14116

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Check for one already running before spawning a new one.
Also move the check for the isDirCache in one place.

Differential Revision: https://phabricator.kde.org/D14077

Creating a TextArea is surprisingly costly.

Differential Revision: https://phabricator.kde.org/D14079

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

It is not used and hasn't been touched since the original kde-workspace split

Differential Revision: https://phabricator.kde.org/D14055

Differential Revision: https://phabricator.kde.org/D14041

Fixes timeline and search URLs in "Computer" tab

BUG: 363337
FIXED-IN: 5.12.7

Differential Revision: https://phabricator.kde.org/D14029

This groups entries in Places under the same categories (Places, Recently Saved,
Remote, Devices, etc) as in all other places where Places are shown

Differential Revision: https://phabricator.kde.org/D14030

It is only used in one place and cached, so no need for a global static that is created
as soon as the plugin is loaded.

Differential Revision: https://phabricator.kde.org/D13999

GIT_SILENT

Avoids the other icons being visible in the highlight frame

No need to load 18 preview pixmaps of which 12 can only be seen during the animation.
Furthermore, cache the pixmaps as ListView deletes and recreates delegates as you scroll,
leading to us recreating the icon pixmaps as you scroll up and down with many
themes installed

Differential Revision: https://phabricator.kde.org/D13793

This entire thing is built on X technology and just crashes when opening it.
Don't show it in settings until it was rewritten to support Wayland.

BUG: 364746
FIXED-IN: 5.13.3

Differential Revision: https://phabricator.kde.org/D13920

It uses Xft unconditionally and crashes the entire module when run on Wayland.

BUG: 396214
FIXED-IN: 5.13.3

Differential Revision: https://phabricator.kde.org/D13919

Test Plan: none

Reviewers: lueck

Reviewed By: lueck

Subscribers: plasma-devel, kde-doc-english

Tags: #plasma, #documentation

Differential Revision: https://phabricator.kde.org/D13903

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"