GitLab

Right-clicking on multiple things is a real use case which got broken
in !591
while fixing the bug of un-clicked-on items remaining selected after
clicking one of them.

This commit fixes that.

BUG: 443743
FIXED-IN: 5.23.1


(cherry picked from commit 2b828c60)

David Edmundson authored Oct 14, 2021 and Nate Graham committed Oct 14, 2021

The Dashboard representation contains 3 views stacked on top of each
other with one visible at a time with an opacity animation.

Enabled was used (presumably) to ensure that only the active
representation gets input events.

Unfortunately this has a side effect. When switching views the icons on
the inactive view all get enabledChanged events. This triggers a redraw
with a greyed out effect on all icons. This is a very slow path,
especially for something not even visible!

Setting visible also stops input events, without the side effect.


(cherry picked from commit 7881fdf5)

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

GIT_SILENT

GIT_SILENT

Deletion of intermediate inputWindow is touchy, it interferes with the
switching probably because of focusing stuff.

BUG: 443323


(cherry picked from commit dbcc2e5c)

(cherry picked from commit 2e8b630e)

Fushan Wen authored Oct 01, 2021 and Noah Davis committed Oct 07, 2021

The scrollbar should have its own space instead of overlapping
the thumbnail or the media controller.

BUG: 443173
CCBUG: 439522
(cherry picked from commit 578a5db6)

(cherry picked from commit c499c36f)

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

BUG: 440308
(cherry picked from commit fd49cc02)

(cherry picked from commit e6e80d52)

It's a bit cleaner this way since the 2 related things are together.

(cherry picked from commit 0826af52)

(cherry picked from commit 683df961)

BUG: 443076
(cherry picked from commit 9d48efbb)

(cherry picked from commit 960eb8ba)

(cherry picked from commit 1bfc0351)

Bharadwaj Raju authored Oct 05, 2021 and Nate Graham committed Oct 06, 2021

This is handled in onReleased so as to distinguish between a drag and
click.

BUG: 424152


(cherry picked from commit 915aa97a)

Méven Car authored Oct 05, 2021 and Nate Graham committed Oct 05, 2021

Was missing the translation domain


(cherry picked from commit 6ad9dfe7)

Arjen Hiemstra authored Sep 15, 2021 and Nate Graham committed Oct 05, 2021

This uses the same style as radio buttons and grid KCM delegates to
indicate when one of the thumbnails has focus.


(cherry picked from commit d83e15ce)

Fushan Wen authored Oct 04, 2021 and Nate Graham committed Oct 04, 2021

Removes the warning: TypeError: Cannot read property 'applet' of null

BUG: 443287


(cherry picked from commit f2b940e5)

Méven Car authored Oct 04, 2021 and Nate Graham committed Oct 04, 2021

For the right click section, show it only if one its two options is available.

For the middle-click section, show it if at least one of its option is visible.

CCBUG: 408338


(cherry picked from commit c2b797ff)

David Redondo authored Oct 04, 2021 and Nate Graham committed Oct 04, 2021

QMenu::popup() takes a global position but we still want, the
new file position in local coordinates.
Tested both that the menu opens correctly and new files are created
at the correct position which triggered the introduction of setMenuPos.
BUG:443278


(cherry picked from commit 96067c0f)

Fushan Wen authored Oct 04, 2021 and David Edmundson committed Oct 04, 2021

The position of the panel config bar should follow the panel after
typing a new number in the spinbox and pressing Enter.

BUG: 443280


(cherry picked from commit b0a0b425)

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

The purpose of this line is to separate a panel applet's popup from the
panel, but when there is no panel, the line gets drawn anyway, has
undefined geometry, ends up too big, and looks weird. This commit hides
it for the popups of non-panel applets.

BUG: 439374
FIXED-IN: 5.23


(cherry picked from commit 864b04de)

After refactoring, keyboardLayout plugin is not accessible any more from
root Item object, so we pass the needed info from Action via signal.

BUG: 441239


(cherry picked from commit e41bb311)

Kai Uwe Broulik authored Sep 27, 2021 and Nate Graham committed Sep 27, 2021

It's annoying and unlike any other GridView to have the highlight
move around like this.


(cherry picked from commit ff6f3493)

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Aimi Robot authored Sep 24, 2021 and Nate Graham committed Sep 24, 2021

Now the list items, header, and footer are a little bit taller.

BUG: 442661
FIXED-IN: 5.23


(cherry picked from commit 61d7c9b7)

Fabian Vogt authored Sep 22, 2021 and Nate Graham committed Sep 22, 2021

Replace the custom code with Kirigami's implementation for consistency.

BUG: 442776


(cherry picked from commit 322854d2)

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Nicolas Fella authored Sep 20, 2021 and Nate Graham committed Sep 20, 2021

Set a KLocalizedContext, otherwise i18n and friends are not available

BUG: 442514


(cherry picked from commit 550f2f7c)

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

You can now move the focus in a specific direction by using arrow keys.

make focus switching between current page and footer more spacial

move menu button handling to views

don't move left or right in grid when searchField is focused

make main area to header navigation more spacial


(cherry picked from commit 39a469e6)

The previous behavior made switching between mouse and keyboard navigation very annoying because it was hard to tell where focus was.


(cherry picked from commit e693eaca)

Fixes weird looking tooltip corners glitch. the bug should probably be
fixed in plasma-framework too, but Plasma is on a different release
schedule and an attached tooltip is still normal for button tooltips.


(cherry picked from commit f0f7f8de)