1. 15 Oct, 2021 1 commit
  2. 06 Oct, 2021 1 commit
  3. 03 Sep, 2021 1 commit
  4. 08 Aug, 2021 1 commit
  5. 25 Jun, 2021 1 commit
  6. 23 Apr, 2021 1 commit
    • David Redondo's avatar
      Set a transientParent for the FolderView ContextMenu · 603c0b5a
      David Redondo authored
      We already had the possibility to specify a visualParent but never did.
      The positioning below the parent is not optimal because the Delegates
      include the spacing between rows at their bottom which was likely never
      discovered because the visualParent was never set. So just set it always
      to the cursor position.
      CCBUG:417378
      603c0b5a
  7. 08 Apr, 2021 2 commits
    • Nate Graham's avatar
      [folder view] Allow disabling click-to-rename when using double-click · 9574fbb6
      Nate Graham authored
      a911982e added a "Click on the label to
      initiate renaming when using double-click" feature, mimicking the one
      that Dolphin has. However Dolphin also has an option to turn it off,
      while Folder View thus far does not.
      
      This commit implements a simple setting to turn it off, placed in the
      same place in Folder View's config window as the equivalent Dolphin
      option. Ths option is not visible and has no effect when using the
      default single-click mode.
      
      BUG: 434827
      FIXED-IN: 5.22
      9574fbb6
    • Nate Graham's avatar
      Port to singleton Theme · 5ac5cf99
      Nate Graham authored
      We ported units to use the PlasmaCore.Units singleton earlier; now it's
      time to do the same thing for PlasmaCore.Theme.
      
      There are no UI changes or regressions detected.
      5ac5cf99
  8. 21 Jan, 2021 1 commit
  9. 16 Nov, 2020 1 commit
    • Konrad Materka's avatar
      Fix QML Binding warnings · ee9033b6
      Konrad Materka authored and Nate Graham's avatar Nate Graham committed
      Qt 5.14 introduced new restoreMode mandatory property. Fix warnings like this one:
      QML Binding: Not restoring previous value because restoreMode has not been set.
      ee9033b6
  10. 11 Nov, 2020 1 commit
    • Konrad Materka's avatar
      Fix Connections warnings · 31cef000
      Konrad Materka authored
      Qt 5.15 introduced new syntax for defining Connections. Fix warnings like this one:
      QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }
      31cef000
  11. 30 Oct, 2020 1 commit
  12. 21 Oct, 2020 1 commit
  13. 24 Sep, 2020 1 commit
  14. 29 Jul, 2020 1 commit
  15. 05 May, 2020 1 commit
    • Alexandre Pereira's avatar
      Fix folderview popup mode list view icon size inheriting icon view icon size · 1d557e8a
      Alexandre Pereira authored and Nate Graham's avatar Nate Graham committed
      Summary:
      The icon size is only selectable in icon view mode.
      but selecting a different icon size on icon view mode also changes
      the size of the icons in list view mode.
      
      This creates a problem since the list icon size is hardcoded by default to small,
      but it seems it is being changed on other places of the code.
      
      BUG: 418269
      FIXED-IN: 5.19.0
      
      Test Plan:
      I tested this on icon folderview and normal desktop folderview, changing icon sizes in iconview and listview
      and restarting plasmashell.
      
      Reviewers: #plasma, #vdg, ngraham
      
      Reviewed By: #vdg, ngraham
      
      Subscribers: ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D28057
      1d557e8a
  16. 04 Feb, 2020 1 commit
  17. 08 Jan, 2020 2 commits
  18. 21 Oct, 2019 1 commit
    • Marco Martin's avatar
      support global edit mode · ae555600
      Marco Martin authored
      Summary:
      desktop and panel toolboxes are only visible in "edit mode"
      edit mode can be triggered by
      * long press in desktop
      * context menu action
      * dbus property (to be eventually used by systemsettings)
      The desktop toolbox becomes a "toolbar" with just few selected actions
      the presence of that toolbar both fullfills "long press should usually show some
      contextual actions" and being a very visible hint that "we are now in edit mode"
      toolbox is still movable around in case would obscure any important stuff where it's
      by default
      
      Depends on D24263
      Depends on D24264
      Closes T10402
      
      Test Plan: ui works as planned, toolbox position is saved and restored correctly
      
      Reviewers: #plasma, ngraham
      
      Reviewed By: ngraham
      
      Subscribers: davidedmundson, ngraham, GB_2, plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T10190, T11094, T10402, T8751
      
      Differential Revision: https://phabricator.kde.org/D24265
      ae555600
  19. 09 Apr, 2019 2 commits
  20. 08 Apr, 2019 3 commits
    • Nate Graham's avatar
      [Folder View] Implement a user-configurable setting for label width · bad5d2b8
      Nate Graham authored
      Summary:
      It seems impossible to satisfy everyone's preferences regarding label width in Folder
      View. Some people want small icons with narrow labels (403412). Other people want small
      icons with wide labels (379432). There have been other complaints in the past too, which
      have led to the current settings, but because these preferences are opposed, the more we
      tweak the settings to please one group of people, the more we annoy another.
      
      Accordingly, This patch implements a user-configurable setting to determine the label width
      for Folder View items in Icons view. This should put the matter to rest once and for all.
      
      FEATURE: 403094
      FIXED-IN: 5.16
      
      Test Plan:
      Default settings (large icons + medium label width): {F6758619}
      
      Small icons + narrow labels: {F6758622}
      
      Small icons + medium labels: {F6758624}
      
      SmallMedium icons + medium labels: {F6758625}
      
      Large icons + wide labels: {F6758626}
      
      Reviewers: hein, #plasma, #vdg
      
      Reviewed By: hein, #plasma
      
      Subscribers: broulik, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D20370
      bad5d2b8
    • Nate Graham's avatar
      [Folder View] Use a more reasonable minimum cell width · 1c2dd97e
      Nate Graham authored
      Summary:
      With the goal of making Folder View items' labels more legible,
      78da28e7 increased the minimum cell
      width, resulting in each cell being much wider when icon sizes are small.
      
      The goal was achieved, but the change went a bit too far and people have
      understandably complained about the width being too high and looking silly
      when the icon size is small, especially for items with very short labels.
      
      This patch reduces the minimum width a bit to improve the situation.
      
      I still suspect that we may need to add a slider to control the label width just like
      the one Dolphin has (see D20370), but hopefully this patch should improve the
      situation for people using the LTS release, and reduce the pressure for yet
      another user-facing setting.
      
      BUG: 403412
      FIXED-IN: 5.12.9
      
      Test Plan:
      Smallest icon size: {F6758566}
      Small-medium icon size: {F6758568}
      Medium icon size: {F6758569}
      [No change for larger icon sizes]
      
      Reviewers: hein, #plasma, #vdg
      
      Reviewed By: hein, #plasma
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D20368
      1c2dd97e
    • Nate Graham's avatar
      [Folder View] Use a more reasonable minimum cell width · a86211b7
      Nate Graham authored
      Summary:
      With the goal of making Folder View items' labels more legible,
      78da28e7 increased the minimum cell width, resulting in
      each cell being much wider when icon sizes are small.
      
      Ths goal was achieved, but the change went a bit too far and people have understandably
      complained about the width being too high and looking silly when the icon size is small,
      especially for items ith very short labels.
      
      This patch reduces the minimum width a bit to improve the situation.
      
      I still suspect that we may need to add a slider to control the label width just like
      the one Dolphin has, but hopefully this patch should reduce the pressure for that by
      improving the defaults.
      
      Test Plan:
      Smallest icon size: {F6758566}
      Small-medium icon size: {F6758568}
      Medium icon size: {F6758569}
      [No change for larger icon sizes]
      
      Reviewers: hein, #plasma, #vdg
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D20368
      a86211b7
  21. 09 Mar, 2019 1 commit
  22. 30 Jan, 2019 1 commit
    • Eike Hein's avatar
      Defer initial positions apply until listing is complete · aaebb510
      Eike Hein authored
      Summary:
      This fixes the infamous "desktop positions partially scramble on reboot"
      bug that occurs when KDirLister completes listing in multiple model
      transactions.
      
      This also:
      * Disallows moves and drops while listing, for extra safety.
      * Cleans up wonky old defer-sometimes code that made little sense.
      * Removes a cache for lastRow() that was never actually used.
      
      BUG:354802
      
      Reviewers: #plasma, davidedmundson, chinmoyr
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D18598
      aaebb510
  23. 29 Nov, 2018 1 commit
    • Nate Graham's avatar
      [Folder View] implement a minimum width for icon view to ensure that labels... · 0b654afd
      Nate Graham authored
      [Folder View] implement a minimum width for icon view to ensure that labels are never rendered useless
      
      Summary:
      Currently with Folder-View-on-the-desktop, items' labels become illegibe when the icon size is very small.
      
      This patch implements a minimum width when using on-the-desktop icon view to make sure that the label is never uselessly short when using very small icons.
      
      BUG: 379432
      FIXED-IN: 5.12.8
      
      Test Plan:
      Smallest size, before: {F6426124}
      Smallest size, after: {F6426126}
      Equal padding on either side of the container itself still works: {F6426129}
      
      There is no change for sizes corresponding to the fourth tick on the slider and beyond
      
      Reviewers: #plasma, #vdg, hein
      
      Reviewed By: #plasma, hein
      
      Subscribers: abetts, broulik, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D16901
      0b654afd
  24. 10 Nov, 2018 1 commit
  25. 23 Oct, 2018 1 commit
    • Eike Hein's avatar
      Focus handling fixes · 03b17ac5
      Eike Hein authored
      Summary:
      * Fix keyboard nav on the desktop again.
      BUG:399566
      * Fix initial focus properly.
      * Make sure when using arrows after starting Plasma or after clicking
        into empty space, the first selected item is always 0, not 1 or
        some random item based on previous activity.
      * Make sure the view is always scrolled up when (re)opening the popup.
      
      Reviewers: broulik
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D16106
      03b17ac5
  26. 10 Oct, 2018 2 commits
    • Eike Hein's avatar
      Focus handling fixes · 480962c3
      Eike Hein authored
      Summary:
      * Fix keyboard nav on the desktop again.
      BUG:399566
      * Fix initial focus properly.
      * Make sure when using arrows after starting Plasma or after clicking
        into empty space, the first selected item is always 0, not 1 or
        some random item based on previous activity.
      * Make sure the view is always scrolled up when (re)opening the popup.
      
      Reviewers: broulik
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D16106
      480962c3
    • Thomas Surrel's avatar
      [Folder View] Remember selected item when navigating in subfolders · 6736bdaa
      Thomas Surrel authored
      Summary:
      When using the folder view in a panel as a popup, being in list view
      mode, getting into subfolders and back with arrow keys had a weird
      behaviour: the currentItem would just stay the same accross folders.
      
      This patch restores both the proper selected item and the scrolling
      position when navigating back.
      
      BUG: 359310
      
      Test Plan:
      - Add a folder view in a panel, configure it in list view mode
      - Enter a subfolder and go back
      The folder you had gone into should be selected and the scrolling
      position should be the same than when you entered it.
      
      Reviewers: #plasma, broulik, hein
      
      Reviewed By: #plasma, hein
      
      Subscribers: anthonyfieroni, ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D15840
      6736bdaa
  27. 06 Oct, 2018 1 commit
    • Thomas Surrel's avatar
      [Folder View] Fix right/left arrow navigation in popup mode · 0337f979
      Thomas Surrel authored
      Summary:
      This patch fixes several issues in the popup mode:
      - when using the Folder View in 'Icon mode', pressing the right arrow when on a folder would enter that folder instead of just moving the selection to the right
      - when using the Folder View in 'list mode', navigating in a subfolder and pressing the right arrow several times while selection is on a file would result in having to press an equal number of times the left arrow before it navigates back to the parent folder
      - using the left arrow now only navigates back. Pressing the left arrow while in the 'root' folder of the Folder View was also moving the selection up, which is inconsistent
      
      Reviewers: #plasma, #vdg, hein
      
      Reviewed By: #plasma, hein
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D15824
      0337f979
  28. 06 Sep, 2018 1 commit
    • Kai Uwe Broulik's avatar
      [Folder View] Disable the actions themselves rather than just not adding them to the menu · 75904877
      Kai Uwe Broulik authored
      Folder View is built on the assumption that actions can only be triggered from the context menu.
      This isn't true as keyboard shortcuts can trigger actions which will only get their correct state just before the menu opens.
      Moreover, often the action itself isn't disabled/hidden but just not added to the menu, which means it can still be triggered
      using a keyboard shortcut.
      
      This patch changes the context menu to always include all (most of them, anyway) actions but instead have updateActions() disable
      or hide them as needed.
      
      Also, take into account KFileItemListProperties for more actions (e.g. Cut, Paste, Rename, Trash, …) like Dolphin does it.
      
      Differential Revision: https://phabricator.kde.org/D15162
      75904877
  29. 27 Aug, 2018 1 commit
  30. 12 Jul, 2018 1 commit
  31. 18 Jun, 2018 1 commit
  32. 13 Jun, 2018 1 commit
  33. 05 Apr, 2018 1 commit
  34. 26 Mar, 2018 1 commit