GitLab

Right-clicking on multiple things is a real use case which got broken
in !591
while fixing the bug of un-clicked-on items remaining selected after
clicking one of them.

This commit fixes that.

BUG: 443743
FIXED-IN: 5.23.1


(cherry picked from commit 2b828c60)

Bharadwaj Raju authored Oct 05, 2021 and Nate Graham committed Oct 06, 2021

This is handled in onReleased so as to distinguish between a drag and
click.

BUG: 424152


(cherry picked from commit 915aa97a)

This is a follow-up change for new wrapping behavior in KCoreAddons
(and by extension in Dolphin) introduced in frameworks/kcoreaddons!132

frameworks/kcoreaddons!132

Also, editor now relies directly on model data instead of coupling to
label's text. There are many more cases there where direct access is
inappropriate, and should be replaced with properties of model and/or
root item's aliases.

It's logical that if the user disables this feature, they want it off
everywhere, not just in one of the two places where it can currently
appear.

BUG: 439557
FIXED-IN: 5.23

We already had the possibility to specify a visualParent but never did.
The positioning below the parent is not optimal because the Delegates
include the spacing between rows at their bottom which was likely never
discovered because the visualParent was never set. So just set it always
to the cursor position.
CCBUG:417378

a911982e added a "Click on the label to
initiate renaming when using double-click" feature, mimicking the one
that Dolphin has. However Dolphin also has an option to turn it off,
while Folder View thus far does not.

This commit implements a simple setting to turn it off, placed in the
same place in Folder View's config window as the equivalent Dolphin
option. Ths option is not visible and has no effect when using the
default single-click mode.

BUG: 434827
FIXED-IN: 5.22

We ported units to use the PlasmaCore.Units singleton earlier; now it's
time to do the same thing for PlasmaCore.Theme.

There are no UI changes or regressions detected.

This commit adds to Folder View a feature that Dolphin has: the ability
to rename a selected item by clicking on its title when it's already
selected and the user is using the double-click mode.

BUG: 392731
FIXED-IN: 5.21

Konrad Materka authored Nov 14, 2020 and Nate Graham committed Nov 16, 2020

Qt 5.14 introduced new restoreMode mandatory property. Fix warnings like this one:
QML Binding: Not restoring previous value because restoreMode has not been set.

Qt 5.15 introduced new syntax for defining Connections. Fix warnings like this one:
QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }

Steffen Hartleib authored Oct 30, 2020 and David Edmundson committed Oct 30, 2020

* moving icon's on the desktop around with touch
* open/launch icons with tap (only singe tap, regardless of mouse workspace behavior)
* access the icon's context menu with tap and hold

BUG: 366462
BUG: 408051

This commit ports away from units.* to PlasmaCore.Units.*

Alexandre Pereira authored May 05, 2020 and Nate Graham committed May 05, 2020

Summary:
The icon size is only selectable in icon view mode.
but selecting a different icon size on icon view mode also changes
the size of the icons in list view mode.

This creates a problem since the list icon size is hardcoded by default to small,
but it seems it is being changed on other places of the code.

BUG: 418269
FIXED-IN: 5.19.0

Test Plan:
I tested this on icon folderview and normal desktop folderview, changing icon sizes in iconview and listview
and restarting plasmashell.

Reviewers: #plasma, #vdg, ngraham

Reviewed By: #vdg, ngraham

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28057

Summary:
Depend: D26691
BUG: 415917

Test Plan: Drop files into desktop folder layout/folder widget, the menu is shown correctly in all cases.

Reviewers: #plasma, davidedmundson, broulik, hein

Reviewed By: #plasma, hein

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D26514

Summary:
BUG: 415816
FIXED-IN: 5.18.0

Test Plan:
Rename an item on the desktop
Start a drag within the text area
While dragging, move the cursor out of the text area
Other filed no longer get selected by a rubberband

Reviewers: hein, #plasma

Reviewed By: hein, #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D26482

Summary:
desktop and panel toolboxes are only visible in "edit mode"
edit mode can be triggered by
* long press in desktop
* context menu action
* dbus property (to be eventually used by systemsettings)
The desktop toolbox becomes a "toolbar" with just few selected actions
the presence of that toolbar both fullfills "long press should usually show some
contextual actions" and being a very visible hint that "we are now in edit mode"
toolbox is still movable around in case would obscure any important stuff where it's
by default

Depends on D24263
Depends on D24264
Closes T10402

Test Plan: ui works as planned, toolbox position is saved and restored correctly

Reviewers: #plasma, ngraham

Reviewed By: ngraham

Subscribers: davidedmundson, ngraham, GB_2, plasma-devel

Tags: #plasma

Maniphest Tasks: T10190, T11094, T10402, T8751

Differential Revision: https://phabricator.kde.org/D24265

Summary:
This is more technically correct and doesn't leave any empty space on the right side
of the screen.

Test Plan: {F6763177}

Reviewers: hein, #plasma

Reviewed By: hein, #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D20420

Summary:
Without rounding the result, sub-pixel rounding errors accumulate over time, making the
label blurry.

Test Plan: Nice and crisp now: {F6762000, size=full}

Reviewers: fvogt, #plasma, hein, filipf

Reviewed By: filipf

Subscribers: abetts, filipf, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D20407

Summary:
It seems impossible to satisfy everyone's preferences regarding label width in Folder
View. Some people want small icons with narrow labels (403412). Other people want small
icons with wide labels (379432). There have been other complaints in the past too, which
have led to the current settings, but because these preferences are opposed, the more we
tweak the settings to please one group of people, the more we annoy another.

Accordingly, This patch implements a user-configurable setting to determine the label width
for Folder View items in Icons view. This should put the matter to rest once and for all.

FEATURE: 403094
FIXED-IN: 5.16

Test Plan:
Default settings (large icons + medium label width): {F6758619}

Small icons + narrow labels: {F6758622}

Small icons + medium labels: {F6758624}

SmallMedium icons + medium labels: {F6758625}

Large icons + wide labels: {F6758626}

Reviewers: hein, #plasma, #vdg

Reviewed By: hein, #plasma

Subscribers: broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D20370

Summary:
With the goal of making Folder View items' labels more legible,
78da28e7 increased the minimum cell
width, resulting in each cell being much wider when icon sizes are small.

The goal was achieved, but the change went a bit too far and people have
understandably complained about the width being too high and looking silly
when the icon size is small, especially for items with very short labels.

This patch reduces the minimum width a bit to improve the situation.

I still suspect that we may need to add a slider to control the label width just like
the one Dolphin has (see D20370), but hopefully this patch should improve the
situation for people using the LTS release, and reduce the pressure for yet
another user-facing setting.

BUG: 403412
FIXED-IN: 5.12.9

Test Plan:
Smallest icon size: {F6758566}
Small-medium icon size: {F6758568}
Medium icon size: {F6758569}
[No change for larger icon sizes]

Reviewers: hein, #plasma, #vdg

Reviewed By: hein, #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D20368

Summary:
With the goal of making Folder View items' labels more legible,
78da28e7 increased the minimum cell width, resulting in
each cell being much wider when icon sizes are small.

Ths goal was achieved, but the change went a bit too far and people have understandably
complained about the width being too high and looking silly when the icon size is small,
especially for items ith very short labels.

This patch reduces the minimum width a bit to improve the situation.

I still suspect that we may need to add a slider to control the label width just like
the one Dolphin has, but hopefully this patch should reduce the pressure for that by
improving the defaults.

Test Plan:
Smallest icon size: {F6758566}
Small-medium icon size: {F6758568}
Medium icon size: {F6758569}
[No change for larger icon sizes]

Reviewers: hein, #plasma, #vdg

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D20368

Summary:
This fixes the infamous "desktop positions partially scramble on reboot"
bug that occurs when KDirLister completes listing in multiple model
transactions.

This also:
* Disallows moves and drops while listing, for extra safety.
* Cleans up wonky old defer-sometimes code that made little sense.
* Removes a cache for lastRow() that was never actually used.

BUG:354802

Reviewers: #plasma, davidedmundson, chinmoyr

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D18598

[Folder View] implement a minimum width for icon view to ensure that labels are never rendered useless

Summary:
Currently with Folder-View-on-the-desktop, items' labels become illegibe when the icon size is very small.

This patch implements a minimum width when using on-the-desktop icon view to make sure that the label is never uselessly short when using very small icons.

BUG: 379432
FIXED-IN: 5.12.8

Test Plan:
Smallest size, before: {F6426124}
Smallest size, after: {F6426126}
Equal padding on either side of the container itself still works: {F6426129}

There is no change for sizes corresponding to the fourth tick on the slider and beyond

Reviewers: #plasma, #vdg, hein

Reviewed By: #plasma, hein

Subscribers: abetts, broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D16901

Summary:
* Fix keyboard nav on the desktop again.
BUG:399566
* Fix initial focus properly.
* Make sure when using arrows after starting Plasma or after clicking
  into empty space, the first selected item is always 0, not 1 or
  some random item based on previous activity.
* Make sure the view is always scrolled up when (re)opening the popup.

Reviewers: broulik

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D16106

Summary:
* Fix keyboard nav on the desktop again.
BUG:399566
* Fix initial focus properly.
* Make sure when using arrows after starting Plasma or after clicking
  into empty space, the first selected item is always 0, not 1 or
  some random item based on previous activity.
* Make sure the view is always scrolled up when (re)opening the popup.

Reviewers: broulik

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D16106

Summary:
When using the folder view in a panel as a popup, being in list view
mode, getting into subfolders and back with arrow keys had a weird
behaviour: the currentItem would just stay the same accross folders.

This patch restores both the proper selected item and the scrolling
position when navigating back.

BUG: 359310

Test Plan:
- Add a folder view in a panel, configure it in list view mode
- Enter a subfolder and go back
The folder you had gone into should be selected and the scrolling
position should be the same than when you entered it.

Reviewers: #plasma, broulik, hein

Reviewed By: #plasma, hein

Subscribers: anthonyfieroni, ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D15840

Summary:
This patch fixes several issues in the popup mode:
- when using the Folder View in 'Icon mode', pressing the right arrow when on a folder would enter that folder instead of just moving the selection to the right
- when using the Folder View in 'list mode', navigating in a subfolder and pressing the right arrow several times while selection is on a file would result in having to press an equal number of times the left arrow before it navigates back to the parent folder
- using the left arrow now only navigates back. Pressing the left arrow while in the 'root' folder of the Folder View was also moving the selection up, which is inconsistent

Reviewers: #plasma, #vdg, hein

Reviewed By: #plasma, hein

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D15824

Folder View is built on the assumption that actions can only be triggered from the context menu.
This isn't true as keyboard shortcuts can trigger actions which will only get their correct state just before the menu opens.
Moreover, often the action itself isn't disabled/hidden but just not added to the menu, which means it can still be triggered
using a keyboard shortcut.

This patch changes the context menu to always include all (most of them, anyway) actions but instead have updateActions() disable
or hide them as needed.

Also, take into account KFileItemListProperties for more actions (e.g. Cut, Paste, Rename, Trash, …) like Dolphin does it.

Differential Revision: https://phabricator.kde.org/D15162

Creating a TextArea is surprisingly costly.

Differential Revision: https://phabricator.kde.org/D14079

Summary:
Now matches Dolphin behavior.

BUG:395155

Reviewers: broulik, davidedmundson, mart

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D13508

Ensures the shortcuts are shown in the menu.
We need to accept the event if we handled it or else the containment will trigger the action
leading to double activation.

BUG: 392730
FIXED-IN: 5.12.5

Differential Revision: https://phabricator.kde.org/D11953

By accepting the key event we also keep the TextArea from trying to move the cursor itself potentially undoing our selection in the process.

BUG: 392318
FIXED-IN: 5.12.4

Differential Revision: https://phabricator.kde.org/D11708