GitLab

Makes it consistent with the other KCMs

newly ported kcms need at least 5.10

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

QMenu doesn't really support maximumWidth. The window's size would be limited but its
content just cut off rather than nicely elided.
Instead, we manually elide in a crude way using TextMetrics.

Differential Revision: https://phabricator.kde.org/D7181

* Implement undo delete feature
* Introduce currentIndex property instead of indexOf() method
* Make GHNS dialog window modal instead of application modal
* Support drag and drop to install themes
* Use InlineMessage for installation error/success notifications

Differential Revision: https://phabricator.kde.org/D12503

Also remove the "reload" action as the "refresh" action is being used in both cases and setup by usedByContainment

CCBUG: 392730

Differential Revision: https://phabricator.kde.org/D11955

The icon generation code was still there but the UI didn't show it.

Reviewed-By: David Edmundson

It's not like this is public API or anything.

Differential Revision: https://phabricator.kde.org/D10571

When FileDialog is created with visible set to true it will open the dialog immediately before
its properties are set leading to a dialog with no title and filter.

When FileDialog is created with visible set to true it will open the dialog immediately before
its properties are set leading to a dialog with no title and filter.

Differential Revision: https://phabricator.kde.org/D12495

* Support drag and drop install
* Open file dialog directly rather than opening a dialog with an input field and then having to click "Browse" again
* Use inline message instead of message box for "you need to restart for changes to take effect" (if applying fails)
* Port from deprecated KIO::NetAccess to using QTemporaryFile and make downloading async

Differential Revision: https://phabricator.kde.org/D12491

Test Plan:
 * Menu looks the same with new code
 * Menu has icons if changing default value on the config file

Reviewers: hein

Reviewed By: hein

Subscribers: plasma-devel, #plasma

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D12063

Summary:
Does what you imagine it would.
It's akin to KWin's compositor settings, designed to be hidden away and
not used by 99%.

Test Plan:
Set some values
Looked at config.
Unset set values

Reviewers: #plasma, mart

Reviewed By: #plasma, mart

Subscribers: abetts, mart, graesslin, alexeymin, sebas, broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D7934

Summary:
On my install i have various application names that don't fit on units.gridUnit * 14
so let the list grow if needed. It only grows to a limit, we don't want the list to
be huge for some weirdly long application name.

Test Plan:
Use the menu editor to rename Development to Development 22222222222222222222222222
Check the root menu shows all the name
Search and check the search bar sizing is correct at all times
Open submenus with applications whose name previously was cut and check now it displays correctly

Note: I get
	TextFieldStyle.qml:46:17: QML QQuickItem: Binding loop detected for property "implicitHeight"
when entering text on the search bar, but i can also reproduce this with a simple testcase like
https://paste.kde.org/pi1hopivh so it seems it's not a bug in my code. Also i can't see the search
bar misbehaving so it seems to be "harmless"

Reviewers: #plasma, hein

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D12171

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
The fonts kcm offers different font rendering settings. Currently, one needs to apply the settings and
reopen the application to see the changes.
This patch adds a way to render fonts at different settings (mostly based on existing code in kfontinst) and
adds preview images to the sub-pixel and hinting comboboxes.

This is part of a planned redesign of the fonts kcm. See the discussion in https://phabricator.kde.org/T7927

Test Plan:
Open the fonts kcm, click on the sub-pixel combobox. The preview images should look different.

{F5743556}

Reviewers: #plasma, harmathy, mart, davidedmundson, ngraham

Reviewed By: #plasma, harmathy, mart, ngraham

Subscribers: ngraham, davidedmundson, abetts, broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D11064

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

This reverts commit 5e6353d2.

Reviewers: #plasma, broulik

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D12324

Summary:
* Changed the overall design from two lists to one list with a modal
  sheet to add more languages.
* Replaced a modal "You need to relogin for changes" dialog with a
  MessageType.Positive InlineMessage.
* Reworked the way missing languages are handled: The old KCM silently
  rewrote config and showed a warning. The new design shows an
  informative warning and removes the missing languages on the next
  save. Until then they're flagged as missing in the list.
* Manages Apply button state correctly (or rather at all ...).

This depends on D12097.

This implements T7247.

This is currently not final code. It's a WIP upload to give Marco
something to work with to fix various Kirigami and SimpleKCM problems.

Currently known issues:
* Does not save (code is from old KCM, might have been broken there)
* Disabled SwipeListItem actions do not show disabled
* Placement of actions button in SwipeListItem is wonky if the
  contentItem is a RowLayout
* SwipeListItem spews errors about positionAnimation after using an
  action
* SwipeListItem is awkward to use, we need a drag-reorderable list
  delegate
* OverlaySheet spews numerous warnings about not being able to find
  applicationWindow and activeFocusItem
* The sheet is parented to the SimpleKCM's parent since there's no
  app window to be modal too
* The footer inside an OverlaySheet sometimes moves up above the
  content instead of staying down
* Even though SimpleKCM is just a Kirigami.ScrollablePage like
  Kirigami Gallery pages, an InlineMessage that fills the page width
  gets cut off on the left and right, so wonky code to insert margins
  next to them
* List has window bg color as background instead of view background
  color

Reviewers: #kirigami, mart

Subscribers: plasma-devel

Tags: #plasma, #kirigami

Differential Revision: https://phabricator.kde.org/D12102

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
The new asserts added in qtbase in commit 00c09e752f (Qt 5.11) are triggered
by this invalid code, which sets up the model before the begin* methods.
So Qt already sees the new rowCount in that method, which is wrong.

Test Plan: Opening the K menu

Reviewers: hein, davidedmundson

Reviewed By: davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D12275

The preview code could luckily be left completely untouched.

Differential Revision: https://phabricator.kde.org/D12248

Summary: redically simplifying the code, port the ksplash kcm to the new design

Test Plan: selecting and preview work correctly, resize behavior is correct

Reviewers: #plasma, #vdg, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: ngraham, abetts, davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D12088

Summary:
use the new design for the look and feel kcm, together with
a massive code simplification

Test Plan: pply does work, as preview of themes

Reviewers: #plasma, #vdg, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D12090

BUG: 391145
FIXED-IN: 5.12.5

Differential Revision: https://phabricator.kde.org/D12146

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

You can load custom icons through icon dialog, so support non-square icons just like Kicker does. Code mostly from Kicker.

Differential Revision: https://phabricator.kde.org/D12161

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"