GitLab

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
We changed desktop shadows in 10278e79, but we also need to reflect this change in the Trashcan applet which renders its own label and shadows.

Settings have been copied. This also made it obvious that the label will be blury with non-integer placement so a workaround for that is also provided.

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D21545

BUG: 408116
FIXED-IN: 5.17.0

Summary:
In file applets/kicker/package/contents/config/main.xml an option 'showIconsRootLevel' is mentioned. It has following description:
"Whether to show icons on the root level of the menu."

This change provides implementation for this option.

Test Plan:
Manual test:
1. Change menu to 'classic menu' (kicker), notice root level menu items have no icons
2. Open menu settings widget
3. Notice new checkbox 'Show icons on the root level of the menu'
4. Check that checkbox and hit 'Apply' button
5. Root menu items should now have icons similar which look similar to icons in 'modern menu' (kickoff)

Reviewers: hein, #plasma, #vdg, GB_2

Reviewed By: hein, #plasma, #vdg, GB_2

Subscribers: GB_2, ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D19829

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
Initially, there was a spacer which took up a significant amount of space at the bottom of the window without any apprent justification.

I removed a spacer to allow the folder list to occupy the available space.

It seems like it was added intentionally, so I'm not sure if removing it breaks something. I couldn't find any broken behaviour with this change.

BUG: 407709

Test Plan:
1. Open kcm_baloofile. Check if the exclude folders section fills all available space.
2. Resize the window to make it larger. Check that the exclude folders section resizes to match the window.
3. Open the KCM standalone to and try to resize it smaller than the default size to check if the sizehint is set properly.

Reviewers: #baloo, #vdg, ngraham

Subscribers: GB_2, abetts, bruns, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D21414

In Component.onCompleted we might not have a window yet which we need to make the events configuration dialog transient to.

Differential Revision: https://phabricator.kde.org/D21482

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Otherwise this will erroneously match applications that don't have such an entry

BUG: 387590
FIXED-IN: 5.16.0

Differential Revision: https://phabricator.kde.org/D21439

We prefer applicatons over services, however, when configuring a KDE application we get passed both an application and a service.
That application might be NoDisplay and then we end up not finding an index and event configuration files.

Differential Revision: https://phabricator.kde.org/D21434

We don't need any of its session restoration capabilities but it still talks to ksmserver just to then have us discard all the info anyway.

Differential Revision: https://phabricator.kde.org/D21431

Medium hinting and None subpixel rendering was default options added
when we used Oxygen fonts, however freetype recommends slight hinting as
seen in this blog post from 2015 [1].

Also RGB hinting is most-recommended over the None. See linked bug
report as well.

BUG: 389598

[1] https://www.freetype.org/freetype2/docs/text-rendering-general.html

We used to write a configuration for the anti-aliasing using the
startkde script, startkde script would write to kdeglobals and then read
this configuration in the krdb.

This had un-intended side-effect of $XDG_CONFIG_DIRS/kdeglobals settings
or settings set by ~/.config/fontconfig/fonts.conf not being used.

D21335 fixes this by not writing to kdeglobals anymore, this transfers
the defaults used by startkde here.

CCBUG: 389598
CCBUG: 407754

The fonts kcm did only parse a local config file. Global and default settings were not recognized.
With this patch, all global config files are parsed before the local file is parsed.
This allows us to drop the "Vendor default" option.

This patch also fixes some changes not recognized (apply button disabled).

CCBUG: 386566

Test Plan:

Delete `~/.config/fontconfig/fonts.conf` and `~/.config/kcmfonts` .
Run `kcmshell5 fonts`. The default/global settings should be displayed.
Change some settings. The apply button should be enabled.
Save. A new config file should be created.

Follow up of the D12925

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
the code path of kcm without xcursors was broken since over a year,
meaning is not tested at all and can't be guaranteed to be supported

Test Plan: ino build error when xcursor is not found

Reviewers: #plasma, apol

Reviewed By: apol

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D20375

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
Plasma uses inconsistent terminology to refer to KRunner, calling it "Run Command" in
Kicker/Kickoff/etc, but "Plasma Search" in System Settings. For reasons explained in
{T10966} neither term is ideal, and the inconsistency is bad too.

This patch unifies on "Show KRunner" for the action and "KRunner" for the KCM name,
transforming it into a recognizable brand name like Apple's Spotlight.

This patch also makes the icons consistent and adjusts some strings to more clearly
indicate what KRunner is and does.

Test Plan:
{F6842587}

{F6842586}

Reviewers: #vdg, #plasma, ndavis

Reviewed By: #vdg, ndavis

Subscribers: ndavis, plasma-devel, kde-doc-english

Tags: #plasma, #documentation

Maniphest Tasks: T10966

Differential Revision: https://phabricator.kde.org/D21343

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

in order for the lnf apply to fully work more than once m_package needs
to reflect the current theme when a new one is applied