Gabriel Craciunescu authored Oct 28, 2019 and Nate Graham committed Oct 28, 2019

Summary:
The kcm UI has right now a step size of 24 with a max size of 1000 and a minimum of 1.

Max size need to divide to step size and the lowest possible value should be the step size
because  0 means disabled.

Reviewers: davidedmundson, #plasma

Reviewed By: davidedmundson, #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D25004

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Done by clazy

Summary:
All the other platforms that have implemented this feature offer a little inline
explanation of what it is and what it does, but we do not. I think it makes sense to add
our own, since it's not a totally intuitive thing.

Test Plan: {F7659929}

Reviewers: #vdg, #plasma, ndavis, zzag

Reviewed By: #vdg, #plasma, ndavis, zzag

Subscribers: ahiemstra, davidedmundson, ndavis, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24906

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary: Settings for icons effect where removed in plasma 5.16, cleanup config file and code

Test Plan: Added manually entry to my config file and after script was run the entry was not there anymore

Reviewers: #plasma, mart, broulik, ervin

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24845

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

GIT_SILENT

Mirai Komachi authored Oct 22, 2019 and Nate Graham committed Oct 22, 2019

Summary:
LIBINPUT_PROP_ACCEL_PROFILE_ENABLED contains two values,
valueWriterPart<bool> function didn't handle it correctly.

BUG: 398713
FIXED-IN: 5.17.1

Reviewers: #plasma, romangg, ngraham

Reviewed By: #plasma, romangg, ngraham

Subscribers: anthonyfieroni, ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24711

Summary: This depends on https://phabricator.kde.org/D24821

Reviewers: mart, bport, crossi, #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24822

Summary: little work to remove warning before moving LnF KCM to KConfigXT

Test Plan: Should compile and remove Plasma::Package deprecated warnings

Reviewers: #plasma, ervin, mart, bport

Differential Revision: https://phabricator.kde.org/D24820

KCM LookAndFeel : Remove unused Q_PROPERTIES, getter const, internal method private, typo in enum declaration

Summary: Clean up before moving LnF KCM to KConfigXT

Test Plan: Compile

Reviewers: #plasma, ervin, mart, bport

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24819

Reviewers: #plasma, ervin, mart

Differential Revision: https://phabricator.kde.org/D24731

Reviewers: #plasma, ervin, mart, bport

Reviewed By: bport

Subscribers: plasma-devel, apol

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24730

Reviewers: #plasma, ervin, mart

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24729

So it doesn't fall under Lost & Found

BUG: 413227
FIXED-IN: 5.17.1

Differential Revision: https://phabricator.kde.org/D24854

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary: Now you can enter "1 minute" and it will be parsed correctly

Test Plan: Enter "1 minute" and tab away from the box

Reviewers: #plasma, zzag

Reviewed By: #plasma, zzag

Subscribers: zzag, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24838

Summary:
Otherwise they're annoying to use because you can only interact with them using a scroll
or by clicking on the tiny arrows.

Test Plan: You can now enter text in the spinboxes

Reviewers: #vdg, #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24814

Summary:
Currently it's a text box that doesn't give you any indication of what the units are.

BUG:413249
FIXED-IN: 5.18.0

Test Plan: {F7639735, size=full}

Reviewers: #vdg, #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24813

Summary:
desktop and panel toolboxes are only visible in "edit mode"
edit mode can be triggered by
* long press in desktop
* context menu action
* dbus property (to be eventually used by systemsettings)
The desktop toolbox becomes a "toolbar" with just few selected actions
the presence of that toolbar both fullfills "long press should usually show some
contextual actions" and being a very visible hint that "we are now in edit mode"
toolbox is still movable around in case would obscure any important stuff where it's
by default

Depends on D24263
Depends on D24264
Closes T10402

Test Plan: ui works as planned, toolbox position is saved and restored correctly

Reviewers: #plasma, ngraham

Reviewed By: ngraham

Subscribers: davidedmundson, ngraham, GB_2, plasma-devel

Tags: #plasma

Maniphest Tasks: T10190, T11094, T10402, T8751

Differential Revision: https://phabricator.kde.org/D24265

Test Plan: Looked at it

Reviewers: #plasma, ngraham

Reviewed By: ngraham

Subscribers: broulik, ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24763

Summary:
I changed the "forceStripes" checkbox string in D19280, most likey because I thought it wasn't super understandable.

The new string I pushed doesn't, however, match what the option does.

So reverting the change.

BUG: 412801

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24534

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

At least where trivially possible.

Differential Revision: https://phabricator.kde.org/D24757