GitLab

Summary:
BUG: 409915
FIXED-IN: 5.17

Reviewers: #plasma, ngraham, broulik

Reviewed By: #plasma, broulik

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D22552

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary: The type is used, but was not directly included. Fixes build with Qt 5.13.

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D22522

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

the dialog should be binded to the preferred size hints first
and then only if not found, the current item size should be used

Test Plan: none

Reviewers: ngraham

Reviewed By: ngraham

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D22464

The settings are loaded after the QML is created, and once it is loaded, it becomes indeterministic which property
(checkbox checked or spinbox value) is re-evaluated first and the Binding ends up resetting the config.

BUG: 405572
FIXED-IN: 5.16.4

Differential Revision: https://phabricator.kde.org/D22397

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary: requestShutDown is replaced

Test Plan:
Bodged the code so that it made my system think it had firmware support
Clicked checkbox, pressed button. Got my shutdown prompt

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D21763

GIT_SILENT

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary: The libinput include path was missing for the x11 touchpad kcm.

Reviewers: ngraham

Reviewed By: ngraham

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D22284

The list-based comparison approach already covers rejecting anything
which specified a majorversion other than 5

Summary:
Following a lengthy discussion on the topic[1], the first step
towards getting themes cleaned up and hidden when they don't
work is to get the ones hidden which are only for Plasma 4.
We do this by filtering out any theme which is tagged as
being for the major version 4 of plasma. We also allow themes
through which have been tested to work on both, by accepting
themes which are tagged as both 4 and 5.

[1] https://phabricator.kde.org/T8126#184198 and down a few pages

Test Plan:
See themes tagged as plasma##majorversion=4 being hidden, except when they
are also tagged as plasma##majorversion=5. This can most easily be done
by launching the plasma theme dialog and opening Get New Themes from there
and turning on debugging for KNewStuff(Core) like so:

`QT_LOGGING_RULES="org.kde.knewstuff*=true" kcmshell5 kcm_desktoptheme`

and then watching the output, and seeing that content is being rejected
by the InequalityFilter for plasma##majorversion when appropriate.

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D21510

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
We're currently using a custom style for song titles and artist info in tooltips.

This patch applies the common KDE title & subtitle style as seen in e.g. Kickoff or plasma-nm applet.

Test Plan: {F6960690}

Reviewers: #plasma, #vdg, ngraham, hein

Reviewed By: #plasma, #vdg, ngraham, hein

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D22230

Summary:
This patch makes Kickoff tab indicators glide (patch D22108) on the tab bar separator in all 4 orientations.

I had to give up on the separator matching the width\height of the tab indicators because it was just never pixel perfect.

Test Plan:
Screenshots made with patch D22108 applied

{F6939067}

{F6939066}

{F6939065}

{F6939070}

Reviewers: #plasma, #vdg, ndavis, ngraham

Reviewed By: #vdg, ndavis, ngraham

Subscribers: ngraham, ndavis, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D22128

Reviewers: #plasma, ngraham

Reviewed By: ngraham

Subscribers: plasma-devel, kde-doc-english

Tags: #plasma, #documentation

Differential Revision: https://phabricator.kde.org/D22214

Summary:
The logic tried to do an early return, but that doesn't work with ||, so
use && and check if there are >0 elements in the list, otherwise return
a list containing only 0.

This fixes a qml error message:
file:///usr/share/plasma/plasmoids/org.kde.plasma.taskmanager/contents/ui/Task.qml:375: TypeError: Type error

Reviewers: #plasma, hein

Reviewed By: #plasma, hein

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D22208

Summary:
model.AppPid is documented to not always exist, so use the same check
that is used in othere places in the file.
file:///usr/share/plasma/plasmoids/org.kde.plasma.taskmanager/contents/ui/Task.qml:347: Unable to assign [undefined] to int

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D22207

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
Fix warning messages such as : file:///home/$USER/kde/usr/share/plasma/plasmoids/org.kde.plasma.kickoff/contents/ui/KickoffItem.qml:142:9: Unable to assign [undefined] to QString
Occurring when hovering items in the document history section of kickoff.

Test Plan: No more warning messages in ~/.xsessions-error

Reviewers: #plasma, mart

Reviewed By: #plasma, mart

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D22090

GIT_SILENT

Makes the difference between Breeze and Breeze Light more pronounced.

Differential Revision: https://phabricator.kde.org/D22077

Avoids loading huge screenshots just to show them in a tiny thumbnail.
It's using GridView.cellWidth instead of width to avoid reloading the image as the layouting
is done. Everytime sourceSize changes, the image is reloaded.

Differential Revision: https://phabricator.kde.org/D18322

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"